From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A53E4E8180B for ; Fri, 22 Sep 2023 19:38:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A9126B030A; Fri, 22 Sep 2023 15:38:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 059866B030B; Fri, 22 Sep 2023 15:38:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E63FA6B030C; Fri, 22 Sep 2023 15:38:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D61656B030A for ; Fri, 22 Sep 2023 15:38:25 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A9FEC14118D for ; Fri, 22 Sep 2023 19:38:25 +0000 (UTC) X-FDA: 81265244970.02.C3ECC4E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 6B7B6160009 for ; Fri, 22 Sep 2023 19:38:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=J+2aR6VV; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695411504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TwghE0UWvedzbS9x4AhHOtwKLQCqsKJyy8dRVBG0BLM=; b=40oZhPtHa+zDM7ohkHSEXt1sRazW2rwkXIwOpuEZmkKm9f1pbg7Syo3LAB1gNxMufBAk/c hpKZQiwPcCG2tZ4vwMFcbnLeY1MwiGMvQtDoKnmDwE+cfcczLk6UooCG1ax/7u2v2iPuW6 xCH3iEn9wPk1KgZb1ISeRcKXcuMPFo0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=J+2aR6VV; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695411504; a=rsa-sha256; cv=none; b=5O7hjXQHzwfHSSk/3VuXqIsv8C+G4biPGay7iYu68snjeZknkl4U9nHL2MbZJL2ELsrLGn Bz4hfdIFTgtyD4h2tKAINsksT/HX41hwIW2ulzHe9pUdkr6u2am/oVbrVQFV6qAi6uzvka gphxjKw/QBBA0u2F2miuw97IS1WYSHw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TwghE0UWvedzbS9x4AhHOtwKLQCqsKJyy8dRVBG0BLM=; b=J+2aR6VVMtP3vyHszk4csseJuH cHY42l/HKolxgTYY1E1HcC6ojrTdLFolrI31cdR/vAFPJq3sYRWZ8odsSrTte74EyWyjpaq8ro1gY AqnjXNxiPbMV/Z7/4xU17R8I4yXrdHd0w54moXRI+LrEq1SJEVXPDCBOajVnyQyLFdw0ujB0remek l/oGsO8Gke0LF7eHik74oK+w314N7cqkDf9a6hIdyDCzDJWnkqGb9pDflISC2vW8t8jICY4fjfbAf Eh3DKfCJd8PMRQyZqo03OKf+6v6/PUahX0ytz3bluv7VVVKc6qO3HTaH/ZOd8an84LQPNFbQriI5c Tv5T5aMQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qjlyZ-002Tkn-BO; Fri, 22 Sep 2023 19:38:07 +0000 Date: Fri, 22 Sep 2023 20:38:07 +0100 From: Matthew Wilcox To: Dave Chinner Cc: Luis Chamberlain , Pankaj Raghav , Pankaj Raghav , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, gost.dev@samsung.com, riteshh@linux.ibm.com Subject: Re: [RFC 00/23] Enable block size > page size in XFS Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <806df723-78cf-c7eb-66a6-1442c02126b3@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6B7B6160009 X-Stat-Signature: tdqp7f8o6773yr5cfdtpofewkmfes3yz X-Rspam-User: X-HE-Tag: 1695411503-240147 X-HE-Meta: U2FsdGVkX1/xg+E8G6n0CQiuxqLigScOtE0WkN0gPlMW7lmq+VrDM6YE660IYt4fsPGhNJJW14XthvxSIdPRD05pkExc0My0/yBTspNWfEdBjdNEC6fdRERy7tNuBHkow/fHzgQ3CqSz9anqR9tkO8tNWH0PBWcNmodOQviVwmDckJ2SBMjm1nEzRDQOuTdMpbNegdxtKnRptjS6/fXQp6oolml4N0kWP9704D9IfZaktr7PoBg90M6/fNm1oY1a9Esd+jwOV57COZLOdu5pNfjJ/psm0XCACOY31gGuZr0vD5PKhCJHs4EcFSkT807iUMr6mx9HfLod5bTlkynBmaLP5/08f30arpqyPRrJCjJ4Qa7EmsM+2cyfBoVvBHmDwYmk2gEUsDrF1Z9K11ZlAXcisfDquWZDlEjoKpv2eLYEHxHBQQtX4fmH6aadNke6Fcu7GtEpJOwVp+RVN4bITLTncrAanb2Eqo0KssFV+LsqEnDrAPEwSMhPcn0Bfj3dkJO029oJ8n3NfggmZNxwrEfTBQ90dAAjyj+zhr72vLZgoCamQRWiAMmKZnKfK9ZwYKi/siWX1lmxdZpWhRhFkSlyHo0pF+l2WcOlRr8+GOX1ZscvHPtr5OQqYfaRNOsN162ZtKF8wmBDY98OqGZJiOugJM9WhfKFnOCQsJQ4/LjTtmttkDWHQJhra+Nte1CV2BhMxAw9bVt9llOPjmZrLUy+N8RRQxYZsi7wwLcez54LBd2UxxzF2ovP+fiQU+e7OYRiCXG9VN0uTuSVw7mmcRnjuNJiB+SKdY++ZccM+doomvx5TQ518jfoyJKH9lCm7cZjePP9VM8DoosQPVRpZ4KTupEJnW5CruXUPfsnahitr+Q6pUJTZPcJwnNwp41RZtYjPHb5RKTqDKcD7NKF/vxk1NSKH3vXEtx3fL6AK73wcKaFSOuOekpMWUJ1k/aF5doUp2HCsmm7VAwWTN6 ni2+20d0 Bgc6oY0xnkYHntdXIhmwVHxXCTtuHkirkd2gH95Htf6/+NWw06TAppOCSGErPVwAQAwvjbforeciim6djmTYWXawGwApj/YS+qmGfYyHKyNMDxH8wcLR0V8iKmS2syFb2LIosfx/fioPvmXw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: lOn Thu, Sep 21, 2023 at 04:03:56PM +1000, Dave Chinner wrote: > So there's clearly something wrong here - it's likely that the > filesystem IO alignment parameters pulled from the underlying block > device (4k physical, 512 byte logical sector sizes) are improperly > interpreted. i.e. for a filesystem with a sector size of 4kB, > direct IO with an alignment of 512 bytes should be rejected...... I wonder if it's something in the truncation code that's splitting folios that ought not to be split. Does this test possibly keep folios in cache that maybe get invalidated? truncate_inode_partial_folio() is the one i'm most concernd about. but i'm also severely jetlagged.