From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8CEEED615 for ; Fri, 15 Sep 2023 15:37:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B3506B037C; Fri, 15 Sep 2023 11:37:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03B716B037E; Fri, 15 Sep 2023 11:37:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1EB26B037F; Fri, 15 Sep 2023 11:37:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CF4C46B037C for ; Fri, 15 Sep 2023 11:37:22 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AADCE1C9CB9 for ; Fri, 15 Sep 2023 15:37:22 +0000 (UTC) X-FDA: 81239235924.17.E36FD67 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id EAC5F12001B for ; Fri, 15 Sep 2023 15:37:20 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FNQLLzaj; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694792241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=weIH6q/GO+uKb6SAS3pj9bawpU6jDya1ZswVdnm0Tks=; b=iMjwDfM748AKdn3LImVK8dgIqGM3oujwN8qus2cL0YQrhiWXXoUNjo5qSFhQ8LITaajQbc edcQKwWwWY26xJA4vlfhR6DC+wNfOKo37T8D5n4z04hh8isi8S8rBdhVqY7wINZ2MZjhGD E2wJw6uUlfGH3ARiI2NXKD1+8Q0ARuE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FNQLLzaj; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694792241; a=rsa-sha256; cv=none; b=T0eP6EDJ72oDZqzF2chB9uYAkhVI8tgPUWmXwCGVGNdPmHgr5nHd5LRz1FBZYNRPnM4N4W O8boo8Uj0FDL6zH2VGD1Va4ukZct3nWq/iv/LPR1wChI5jOF9uIZm8ZWS8DDYOaorYn+By SDbRYp97F2DMDD5QRYSbHXBtUk63vuo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=weIH6q/GO+uKb6SAS3pj9bawpU6jDya1ZswVdnm0Tks=; b=FNQLLzaj1CwiOfRn1Lldn35Jzd DT1YcE7xPmC0F7GEMiORREJofQ5NNNTGAQI7J+AqKLze307fPYBF4pD21N1aXmQBzerFdswgRnS1P vQEC9UpHQ30gq48dA2CCNeO4beU8Ov7SPJerssNhILXF8Bz7B2jghZCzL/bnD2HQLRNipXg6cyqQh NDdoodU50PsoE+QaJ4cT4Tsj5+F7RrpFH+DKCBEUQwoOVUzRBLZfsRXYmx0tEwn+9EpC8BRJsoDSe 8QuvQvtLKPbEMGNxJ/xCcqM7EHZ/S6uyUme27VK0mA5QF5i7f5rq9PyQBBo5mrrt00e/kjrfWefhO Iu6wRUNg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qhAsc-00AX14-Cv; Fri, 15 Sep 2023 15:37:14 +0000 Date: Fri, 15 Sep 2023 16:37:14 +0100 From: Matthew Wilcox To: Daniel Gomez Cc: "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [PATCH 5/6] shmem: add file length in shmem_get_folio path Message-ID: References: <20230915095042.1320180-1-da.gomez@samsung.com> <20230915095042.1320180-6-da.gomez@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915095042.1320180-6-da.gomez@samsung.com> X-Rspamd-Queue-Id: EAC5F12001B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: o6pshpnpy7wk8t34767ws6ncw67uuzpr X-HE-Tag: 1694792240-301889 X-HE-Meta: U2FsdGVkX1/tmRVom7nNPn2xnzesBEg1ojoBlv20HuaQ0LiJ/w153+0ntE9LOX3m2z0KpTj8efKLXOx8AkbRZ9lCOSV3zfQF8Jv61WkBc673lZ6/IyyyNhNrSEWfv8K2RMeVXPA7UiGBxH8HstFcA6i5KUTBFVq3TMN/lv8ak3EIIVYYQODGXOaW26eQT/QU9XjT+lvowC5xJz5GRdyH5QQf8ewDhX4ipHP1I+R0KQYWn5rj23tmat7k5YRe7I6qtmYjyM6HdcBYfwy5zvrNOkFQAGulapd1rjNhOfNOGwGOtXmykwwEbPo0ehckEXGGAVHRFJ3rJwlKIpo7J4s32DL3DU9SNX29AaQdGVLEle/T/bCLL3/X6vNe7m93raoeVCQZHOmEmyI6V248VedzVZYuC3EyrOfXzmL5Zzk6WiEEcQllsZ/noEro9HRwb/NIVJIvm/r/j7pUSsEb48ZmjLIAsTbF7HZYSpSXSO1+QYLxV9US/5MrGdoRQefZ/KpZL/j0PZMehck2LxhemN36upnNw1Beiirw4Q3gGVw5mlllzHGbdDTqUXGDpfK4VStkiQkOO4a600dQr9JjPZgxQ/OmYSzTOJ372DMf0bhT+oMVZYT4S5hjNy6bR+R6HLJTULQ40XykEymuwvIZqLXY4PtPCvo4T4q3/7t857fRdUp3A66E7KS0QhNgBA9UndnggMbkjfEJUJsGuyouh742aJVp8eLXZzqIBRYmq1xmp27hQ/abB7kOKG5v3ibAj6HkuFnVXj0ahFc1WCSfMRUPQ4GcsExnwEQbwV8gq9p8krTlDBnqMmA5IiMTHDByZT1eWaXjzFan/GCAoT6tSDsKArPIIGUGtRGCOy2OHgbeVNTbiq/KrXs7YngtepD3gtmaFv3yCqed9l6OxC7ou+VXyFHqat/HdIRBV3sVGOMxtjg+j79SJGDiRTpLXTbw6FH3ya8X3WtKQkJtTpwiobS ajx0s5Ff /2qqIU6u07c87Z9tmYkY0UnehOq9/otmRo9//ZhdT3Fw36uJ7XjlW8dsP6dnIPDX7nXbOpIkxUdWaXibceWEd2mrvpACEB8h+jXuCezDGKlmi0cSfaDa2jI1Ib8KrRXJ4ejPA3FlYt49d9VgI4VnT5R+A4zz1m/98VdpWzVTYynsukGS6XZT8PyvOMV/IJNYBuLXnI+0lS42M0/eBOBr0hc73L1wa1dd3jWO+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 09:51:29AM +0000, Daniel Gomez wrote: > @@ -2251,7 +2252,7 @@ static vm_fault_t shmem_fault(struct vm_fault *vmf) > } > > err = shmem_get_folio_gfp(inode, vmf->pgoff, &folio, SGP_CACHE, > - gfp, vma, vmf, &ret); > + gfp, vma, vmf, &ret, i_size_read(inode)); Surely this should be PAGE_SIZE not i_size? > @@ -4923,7 +4927,7 @@ struct folio *shmem_read_folio_gfp(struct address_space *mapping, > > BUG_ON(!shmem_mapping(mapping)); > error = shmem_get_folio_gfp(inode, index, &folio, SGP_CACHE, > - gfp, NULL, NULL, NULL); > + gfp, NULL, NULL, NULL, i_size_read(inode)); Same here?