From: Matthew Wilcox <willy@infradead.org>
To: Daniel Gomez <da.gomez@samsung.com>
Cc: "minchan@kernel.org" <minchan@kernel.org>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"djwong@kernel.org" <djwong@kernel.org>,
"hughd@google.com" <hughd@google.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"gost.dev@samsung.com" <gost.dev@samsung.com>,
Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH 3/6] shmem: account for large order folios
Date: Fri, 15 Sep 2023 13:14:55 +0100 [thread overview]
Message-ID: <ZQRKv6NcfYCr0aWo@casper.infradead.org> (raw)
In-Reply-To: <20230915095042.1320180-4-da.gomez@samsung.com>
On Fri, Sep 15, 2023 at 09:51:26AM +0000, Daniel Gomez wrote:
> @@ -1810,13 +1815,14 @@ static void shmem_set_folio_swapin_error(struct inode *inode, pgoff_t index,
> return;
>
> folio_wait_writeback(folio);
> + num_swap_pages = folio_nr_pages(folio);
> delete_from_swap_cache(folio);
> /*
> * Don't treat swapin error folio as alloced. Otherwise inode->i_blocks
> * won't be 0 when inode is released and thus trigger WARN_ON(i_blocks)
> * in shmem_evict_inode().
> */
> - shmem_recalc_inode(inode, -1, -1);
> + shmem_recalc_inode(inode, num_swap_pages, num_swap_pages);
Shouldn't that be -num_swap_pages?
> swap_free(swap);
> }
>
> @@ -1903,7 +1909,7 @@ static int shmem_swapin_folio(struct inode *inode, pgoff_t index,
> if (error)
> goto failed;
>
> - shmem_recalc_inode(inode, 0, -1);
> + shmem_recalc_inode(inode, 0, folio_nr_pages(folio));
>
> if (sgp == SGP_WRITE)
> folio_mark_accessed(folio);
Also here.
next prev parent reply other threads:[~2023-09-15 12:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230915095123eucas1p2c23d8a8d910f5a8e9fd077dd9579ad0a@eucas1p2.samsung.com>
2023-09-15 9:51 ` [PATCH 0/6] shmem: high order folios support in write path Daniel Gomez
[not found] ` <CGME20230915095124eucas1p1eb0e0ef883f6316cf14c349404a51150@eucas1p1.samsung.com>
2023-09-15 9:51 ` [PATCH 1/6] filemap: make the folio order calculation shareable Daniel Gomez
2023-09-15 13:40 ` Matthew Wilcox
2023-09-18 8:41 ` Daniel Gomez
2023-09-18 18:09 ` Luis Chamberlain
2023-09-18 18:24 ` Matthew Wilcox
2023-09-18 18:42 ` Luis Chamberlain
[not found] ` <CGME20230915095126eucas1p2cf75674dab8a81228f493a7200f4a1ba@eucas1p2.samsung.com>
2023-09-15 9:51 ` [PATCH 2/6] shmem: drop BLOCKS_PER_PAGE macro Daniel Gomez
[not found] ` <CGME20230915095128eucas1p2885c3add58d82413d9c1d17832d3d281@eucas1p2.samsung.com>
2023-09-15 9:51 ` [PATCH 3/6] shmem: account for large order folios Daniel Gomez
2023-09-15 12:14 ` Matthew Wilcox [this message]
2023-09-15 13:44 ` Matthew Wilcox
[not found] ` <CGME20230915095129eucas1p1383d75c6d62056afbb20b78a3ec15234@eucas1p1.samsung.com>
2023-09-15 9:51 ` [PATCH 4/6] shmem: add order parameter support to shmem_alloc_folio Daniel Gomez
2023-09-15 12:19 ` Matthew Wilcox
[not found] ` <CGME20230915095131eucas1p1010e364cd1c351e5b7379954bd237a3d@eucas1p1.samsung.com>
2023-09-15 9:51 ` [PATCH 5/6] shmem: add file length in shmem_get_folio path Daniel Gomez
2023-09-15 15:37 ` Matthew Wilcox
[not found] ` <CGME20230915095133eucas1p267bade2888b7fcd2e1ea8e13e21c495f@eucas1p2.samsung.com>
2023-09-15 9:51 ` [PATCH 6/6] shmem: add large folios support to the write path Daniel Gomez
2023-09-15 18:26 ` Yosry Ahmed
2023-09-18 8:00 ` Daniel Gomez
2023-09-18 18:55 ` Yosry Ahmed
2023-09-19 13:27 ` Daniel Gomez
2023-09-19 16:00 ` Yosry Ahmed
2023-09-19 21:46 ` Luis Chamberlain
2023-09-19 21:51 ` Yosry Ahmed
2023-09-15 15:29 ` [PATCH 0/6] shmem: high order folios support in " David Hildenbrand
2023-09-15 15:34 ` Matthew Wilcox
2023-09-15 15:36 ` David Hildenbrand
2023-09-15 15:40 ` Matthew Wilcox
2023-09-15 15:43 ` David Hildenbrand
2023-09-18 7:32 ` Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQRKv6NcfYCr0aWo@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=da.gomez@samsung.com \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hughd@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=p.raghav@samsung.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).