From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E38C3EE6457 for ; Fri, 15 Sep 2023 12:20:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68CD26B0347; Fri, 15 Sep 2023 08:20:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61FA46B0348; Fri, 15 Sep 2023 08:20:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B6996B034B; Fri, 15 Sep 2023 08:20:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 38CFC6B0347 for ; Fri, 15 Sep 2023 08:20:08 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 02AD7160F77 for ; Fri, 15 Sep 2023 12:20:07 +0000 (UTC) X-FDA: 81238738896.24.36CF8A1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 4E44A40020 for ; Fri, 15 Sep 2023 12:20:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KwvJgFZD; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694780406; a=rsa-sha256; cv=none; b=ktVFt0jQvUc0u/RNLe0Ds8hIYgMvUoHlWP/SdXb18l5n2l2DZ/LjsX8JjT45T/Rcx8b7Oo pW0nWQswl+Jx/BidrN2UdUV3S7Ty9XwH7da2p74DuAgf7vNjgNDCUGVHIjpSAgVAJaiMud wz7MxIRUkibAcXs8A/fGBmcMzNI3OJ8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KwvJgFZD; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694780406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zcm9ZNAum/1OuCWgAEkVFo/U1hKtH0j593KfRJ82drQ=; b=AsG8cv6ynykXbvXvyBNYrHBaXJ1cQBOARKMteN2QRgxqlsjWOSOeTR/1tuUG7qANXlPjTi 1xz2QpCb+RqqNKfkKJoghuOSy3IEYapnGx/X/rV8PInrmHYTgP+/GoGKEGRwRh5dBFcQWm SwOzaJLqYmPrSjdpC6xxn+tB+/jH7QU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zcm9ZNAum/1OuCWgAEkVFo/U1hKtH0j593KfRJ82drQ=; b=KwvJgFZDEOT76rMuRHZbISa1sV RZE1VGxea/J7HxIU2mbnRkiki3wprSXcNf3J92Y/LvYxcBq47TmwVdEw7iYaypEAht1fBIi8d+ef4 qQxWh3TeW1Uu6w4RqTElSTO6jpM1pOR/YcwV0A6ZrsozQ/XGy3hZoS7GPeRkExwMxBbZqdWrLoWtW CxiN+19fzF5gxam3lWayx1PHzl5WJ1gFM949cfpU8gZZYlmma3umCLK9UFJknwDElEjrnV25R/Yth F89C6Js6Isw/FXrMpUwpOFjvgcLAArVa3e64MuUIFvAkK4WPrqhVxvwiMJRxu33P0+/vMigoeAUHR lbMYxD7g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qh7ng-009cY9-Hn; Fri, 15 Sep 2023 12:19:56 +0000 Date: Fri, 15 Sep 2023 13:19:56 +0100 From: Matthew Wilcox To: Daniel Gomez Cc: "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [PATCH 4/6] shmem: add order parameter support to shmem_alloc_folio Message-ID: References: <20230915095042.1320180-1-da.gomez@samsung.com> <20230915095042.1320180-5-da.gomez@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915095042.1320180-5-da.gomez@samsung.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4E44A40020 X-Stat-Signature: 1qms8hdjcxrj961pyxfernrcb6gr38h7 X-Rspam-User: X-HE-Tag: 1694780406-109089 X-HE-Meta: U2FsdGVkX1/rGvmwq/x8R1OqM+IFdWj5WpNX4X8wUcJwfAfps7cU1DWMwlAacFhbI6NOPKM2cPeuOnC9Ti5W3DAyvdqXNdDqxcN4QRms4xru6x7na2q/RxoHl5adw7taWF1/X7sKyMLjJYlKWeXdsPqyhbAPZ+/w1wGaw4ILaAM5ww/KU7ccjppTCWAJVPeY86xkflye5PoD46yuGGg8O4VDU0+uLSBrwfJEsMnEgDWuia56KXT/0x8XWLUR8HY9c8VKPMseu53fCEsAwLerZM0z3MCGN8hd4oqgmbQThzZcUPSOCDvzE6HXo4reGcEshDcDVkVrYKI7H287UpApkFWfNZ1h5Y/pc37sXUgAfwlsl0DnO9Xy2+LPw7ynGl2Gt/J003nG6QALdOyQXE8ZWRgP4nRFZB7AXajz84bklIEGgJLw2EOf78SQLIUxKQ57vhOWcWwM4VhR+0/bwf6X0qFo1gnbffz+iVpghlc3psBgjNfFHcbnshdZzUBVP/56xzhB9v4SGmYFbire5cQ38yJ9nJSgtRTy7/uGtjR2lUj6PW6h+L8KmAiLlFktN+08g6VS191VA9T4ilXGZD62RfUKoDdBM5qo5qRuMvoDJKmgFMOxAbe7BTcYVJdqq83IaKrZH8Lme8JMhW4k2m3qVZZnhuawIUYLqhV+eQzJ/HHK/UsM2GwIAZjh/wnGUzFW2anrIUIPz5xG8D6vpSMtxE/6hDNjkkvffWEoM3tCO9+3SJuPWXcUZuuxn20dTV3anxj+4HBiIN1HxT6OK5M56s7Mgn/JTWfnUToWtlHOOngHqBY+HNkBwGcTSExAx3pO4YXTvrUb35+8K2yWPp4gUGFEtYRXDMD694/vBNMahWLPq6qE3D+R3179KwG7Dcls5GZX3XkbsQKuL6E/LYid5zqRDgnlvZm7GpWGs/olGv9nMlagaYvPqVLLhFJRVNdUvi+X5iKwHi/9eIhKnBU xQ49AJa/ UxE7jQ7dPrYoDNLR8iqYB/zY0qnsVzyVLFoWprMLMjoUeqD9qDHZUGygt+BigjquNjJxiqgDxgYumDn4anSrr4OeitP2zmuoHh/dcMlT9fBLzkulxRGGgYyumcgeyP3JvLemZ0idjTdqzRuXZmuJLQ2eWM1qURDF/9QCl2+r+piHJn+9TdMrdOv8+cZaeX9hmVJmuK/MMrGITO89GnGlkdVr2x/BdJIQnabqw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 09:51:28AM +0000, Daniel Gomez wrote: > In preparation for high order folio support for the write path, add > order parameter when allocating a folio. This is on the write path > when huge support is not enabled or when it is but the huge page > allocation fails, the fallback will take advantage of this too. > static struct folio *shmem_alloc_and_acct_folio(gfp_t gfp, struct inode *inode, > - pgoff_t index, bool huge) > + pgoff_t index, bool huge, unsigned int *order) I don't understand why you keep the 'huge' parameter when you could just pass PMD_ORDER. And I don't understand why you're passing a pointer to the order instead of just passing the order.