From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F60EE6457 for ; Fri, 15 Sep 2023 13:40:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 505726B0368; Fri, 15 Sep 2023 09:40:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48DB16B036B; Fri, 15 Sep 2023 09:40:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32E6D6B036F; Fri, 15 Sep 2023 09:40:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 202F06B0368 for ; Fri, 15 Sep 2023 09:40:21 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D5591C056A for ; Fri, 15 Sep 2023 13:40:20 +0000 (UTC) X-FDA: 81238941000.10.4DAA644 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 8C1CF4002B for ; Fri, 15 Sep 2023 13:40:18 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Q4md8y4/"; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694785219; a=rsa-sha256; cv=none; b=aOZL7M0IXwjNB5Tibt/xoUYh3p5VkkyvezRHM5246gpJEyO7rIMA4D/BTierLFXJlE5jLu hFarbEzaJDQ+mojFQMBEQwcsZ3pdq5Zvv+oyW7YlgIsy/BQ28C6DS/Q6/FzRWMbbJLsA0p ckm4rc7nDRNU1TeOF1SjNN/RjYE19uw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Q4md8y4/"; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694785219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I+/YKQ4i+/r6yo756aOfG+7UGEVhIuZROLbZ9WTDM80=; b=GFpCsemw1TdEYO7Vh30WfFVnDB5pDnFS7ymFZKi6EjMPIQzOqLXUSAUEfgP2QhQDqry/1L 9i/PU41RusJocINkn/mbN0VV1dMfBX8w2GUcmg8uCik9b0SCyaVixRXip2HwaD2nIXEjPq 32dE+LdBHrNAFoWUwBKbQWjy7ttDRx0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=I+/YKQ4i+/r6yo756aOfG+7UGEVhIuZROLbZ9WTDM80=; b=Q4md8y4/PXXCS6tFFXDCy+1Czx d1uDYKzf8x3eeThB0v0clHgFcJllTbJ/w+dM5rjEDs5ESW0hubWUmOtTW/Y73skTLMG0JAo4hZSDE lv5TM8HdRzUdIQ1Q85nKx+zVtMEPNzscnYBZzmYj+Y07Z8jMeCbtvzO01G5iekEMJtwyI/0Hb+nI4 c4HqyL1w0pNyrxMo/8iQRiyG7Q+lUiCtDZQxtNcGxf8IGUjO35cUCFccj3Syt8iKHPNYnULskYB6I A40s8+3gs8SVNvuf20h5Lvs0o91dLEKLPp0AkFXpGkL26fO9eKxcZFBEnOVEs5LV0rYcrr0WtNK0S mkSA6d3A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qh93H-009z79-Vc; Fri, 15 Sep 2023 13:40:08 +0000 Date: Fri, 15 Sep 2023 14:40:07 +0100 From: Matthew Wilcox To: Daniel Gomez Cc: "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [PATCH 1/6] filemap: make the folio order calculation shareable Message-ID: References: <20230915095042.1320180-1-da.gomez@samsung.com> <20230915095042.1320180-2-da.gomez@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915095042.1320180-2-da.gomez@samsung.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8C1CF4002B X-Stat-Signature: h531axhk5g7pepqb383ekzjofwwrg9er X-Rspam-User: X-HE-Tag: 1694785218-449430 X-HE-Meta: U2FsdGVkX18r/euP01sANIPKBeYeVEwxaXN8BvhTMHBcUDHmvzTmEpTPwBSY1wOmmpU8Vh6Xwu7KWFFAV4hLk9FptkSriror3ky+WCPnCYGH4xn7Bk9i1bbA6IC1vtU+UDDWk6L3t5zc3H4caajqO8WGAw2g3jbGUiZIRnZxXHtruQq2anq10Dy4nR1J3+tjm2xRlDuWkoPDk1vaOLA9ovk8kjgPH8eAOnL2ugFjPpp6orvT4cViULL0RblQB/9OmT2ZBj0b71ulxGFlZ1Hi6ZoEWvmatzKrziYrvTlh2VABrJbUMFjs9mN60nY+Mp21DqLfAyxJHjsDJllnBjyvJi4MZs1XKh3+4wlRs2Hul37ndiTKae1kH2dFng3Ln0DDpVWXGjlT/5fCsCXcl8/SxbmSrzvid4y5VD+9UyBsgMI/02CxKJg8jvy8kTChfOXxzYFxuACj5rYQGAaKADnx6E/7T4Ysh3pxQmOAqONKOgAUJ4ShqGQeNEHrUTDU6KZoJJoqvb78PEv0TLCBrSLFI1cQinpIgQ57VtSD2Lr84hICrmxgVu5uNrtmr7i2bPaIcM9vNKb5XPINCpSb+8b/0y8FFKUCYqwn+xCtlhe83JwY7g5G3wa4HptUvKNfIlvdCIbo9ZCOwdO3y0JdzRveSUApTEf55iS7KBNDRnUCmOmQfiw3RP6ZVuYjFzsY8nJDaD8KYGBXUAPNZ0/zgpunys7uwxjHSOTpl6uQnL+9QrEtLJjSs/EN+kFq8RUkDtVws/4PDzeDQs8SA73nosd/et+ARChLJKb3BIFA5wnqRORqFT8rckrb4tH1dmGwp7hIK9ApFfSuaBZOkY/z31ZwSNlcSV6Ctval5f0tQY4wY0+S8YNnCkYtmw+orsOpEHkfqWzdQbzRdkNJ2AXXQ5xNC5cbV/nEllpDygUlEtIKat8WqcmdcU51LacZxtxPMEuG8slgYTxtmUXPs4oa+7e LD+bwUEv 4afgzUB73CLPmBzhl3Z4qGgq/OARn9eJpTwfyG7OSc4CwmWJNPShH7c8B5CamZazUnZJFazYh7FG5DV61nnZRSDPPQYOul86EmW0dKnghcxa+vLbcS7YFu9Hk/68I49DHScE2QTmNPBt/pF4jM7tcNRYVO8gcSTxzKJL9CHOOzI1oHX9bWj3VbOsbuV+F/UKVGous/YV++mzEQEO3s0MgsPXORZXDpOlGLoSo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 09:51:23AM +0000, Daniel Gomez wrote: > To make the code that clamps the folio order in the __filemap_get_folio > routine reusable to others, move and merge it to the fgf_set_order > new subroutine (mapping_size_order), so when mapping the size at a > given index, the order calculated is already valid and ready to be > used when order is retrieved from fgp_flags with FGF_GET_ORDER. > > Signed-off-by: Daniel Gomez > --- > fs/iomap/buffered-io.c | 6 ++++-- > include/linux/pagemap.h | 42 ++++++++++++++++++++++++++++++++++++----- > mm/filemap.c | 8 -------- > 3 files changed, 41 insertions(+), 15 deletions(-) That seems like a lot of extra code to add in order to avoid copying six lines of code and one comment into the shmem code. It's not wrong, but it seems like a bad tradeoff to me.