From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6612CD37A7 for ; Fri, 15 Sep 2023 19:48:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77C0B6B03E0; Fri, 15 Sep 2023 15:48:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72C126B03E3; Fri, 15 Sep 2023 15:48:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F3CA6B03E5; Fri, 15 Sep 2023 15:48:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4D52E6B03E0 for ; Fri, 15 Sep 2023 15:48:58 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 261DE160717 for ; Fri, 15 Sep 2023 19:48:58 +0000 (UTC) X-FDA: 81239869956.02.278ED4C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 8DD5C10000C for ; Fri, 15 Sep 2023 19:48:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pdDlku3m; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694807336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WBVxEdKN63NHXHCCRu/fwhuDd28XfSSWxEv7k+XBY9g=; b=0CbJDcgIkFxQITm+/pfSIVLzrU44gVXzo/bxbp6gDnbi1WUF505XDKIuPsNR+PEjgv1C1P FoXIc8UsyCoSubXRY8nJIq/gPYdwN5aE21uX4eCc//zV5VyulSbe2c4sC9T5/77w8GpgIC KRXb4PPTSG6Dnzsx5d6kqx4VIcPZ7W0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pdDlku3m; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694807336; a=rsa-sha256; cv=none; b=R7ueO+Iyb7KuHJ3uuxeFJFQBjIu42IdU/rlKAHxe/8qFeG/Vl3SKfiixmXUr8YnWRM5KP1 GRszjuCkGpNyI1cQWF1GQQj2vpx4H/o8zXoEy4YjOJ0fgfi864X3joeJTEKmN14BfGuwPM DdE5gKwGHdWgyZ/mLYd7BRpHcqM+5MI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WBVxEdKN63NHXHCCRu/fwhuDd28XfSSWxEv7k+XBY9g=; b=pdDlku3meiiSaPWPouNeoL+qTk DyxzV6ISQSsbD96x6LLvz7Yf+Y4VXboIabhv290t6LoSU+18OMGD1TLoKwU0e0++Yl/CCStyXOy3u NmWvq8lTTDms3yCsr0gzXYed2aVqi29iAMbBNv6tISsFNGYNVlXAr+fheDkqcj4xOznWR0Cr5VxD8 jATaiH2xdOTWs4NfAWx2f45kk/WuTNKR7bCRmHuRjhnUHGS92H5zh6jl0CwzQKTLnm6biC01F+NC9 cAYqKQ+F9fzrONcTJpiUz9AJgL32udasHPs3SXXGUsZCLFJ9ktZCf8f/pOrOBYExgN1KuFnNdEHGV sJ9SzQtw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qhEnz-00BgCA-GT; Fri, 15 Sep 2023 19:48:43 +0000 Date: Fri, 15 Sep 2023 20:48:43 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, mcgrof@kernel.org, gost.dev@samsung.com Subject: Re: [RFC 07/23] filemap: align the index to mapping_min_order in __filemap_add_folio() Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-8-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915183848.1018717-8-kernel@pankajraghav.com> X-Rspamd-Queue-Id: 8DD5C10000C X-Rspam-User: X-Stat-Signature: 3r5qiu7ii93owsetw14z8z6h5chnsasn X-Rspamd-Server: rspam01 X-HE-Tag: 1694807336-907197 X-HE-Meta: U2FsdGVkX18MeKyK/DGS/WJE9vMdhnZh+b8rA5pLaBmg410Ao1kRspM7SOukekHGBg70G3MeKpDAZWzRbrvS1iLSpMwvgtkiGGXA/z5o68d8fBjmtXO/lmN+pYUQLqtFy4kxctQoYlZDHX/SfLIyxbRdjdBzHjLqmaDzX5Gr7FxL76oTdTm94qmg0c9oRMIHJJOcwSAi3MWYMAEXzqeVQFJzd+LxoPo91Se5rz+Hag/DNpmBaUYv+mGrL84UbFAM3bF33w8G011R2mQD/3SmegDc6WOmJ40jeGxDtxMZklTFziI9VN4VU4YVf9qeX8hBuHuCsBJIH29srqSE1ZmbBqX46NemQj0Dy3i9IPU9yMZtrZuBWteJOCyx2mEkCm/PiLoTDI0tyow4xHaGruIO0KE9rHZA5iyo4F6vvSfYskcY+Dopy+YszD5jjyi88RzQpYhvU6AzbJwsqtO3VA19WoekQX402Gse/w7XHXDuOM4MeR61qPz6sl1X8Fr135G0xQiQ8aCfO/2Bz+bMuQHVmtHN5r90G2xhYOTLliormyxN4pch3ooE2iAyLyYrPd4QPZ/ULrCRChNRG7+1PRiuSVlu7MI13mtvQh3f0o6VZre+/jh+aaXOrEIJLcElc+hV8Hz376zCZEC4JQMf8uJxDApFKhZ6ahuqDEvJ0zOI8Tq0hqNlCGhlwCraiLexAxXbPue9lZGEwmUF/tZkqQTud2zEJ6TOJaqa+jkpd4hYuxwCu09rJ7Fs0qgsNFVckw0MX6OM0EQydVxk4MtSxx3EuTUghL4l8epOn/B1GH5k2uA1p/LNKf7Cxam8uV2V+UPqaZBQMGnbXbnn4BVsFJif0U5IcAqMFpg8hhdGMMCvMMWKXvq1FooaIWGTyH6cZHuQxqItWpl4Bx+KnxNVcvWBZCGuEIO8g00Qeq/LJnZt833efwhnh7Gl3EGxvXAi98yelBDNU3TwP/aT2BBqliH cbQ+AE+d W+orl9+6nl4gFDRzmvSFtRvSqcqaZTkZ2Stcgi7xVnFwTPkekg3qgmzfqRgR/BbjE7Dz6IammRF5bMQxTt5j6+ufIa4CNAkXpI69HurBV55vC70jQAJlphQ9W0vhWQohZoE7FPYlDMWH4hnuQev2Eu/v6Sf5gVCe1ovORYCoCOovUL8IqB+mp8kgyfzeGZMRqQLZ2+Nc0OPPCg5mlUnCZ8RB+J4FT1pKHlCB7SfBNqli1eARFvDh3GbSbMZCvlA9x8l3iopIfxNyGUgo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:38:32PM +0200, Pankaj Raghav wrote: > From: Luis Chamberlain > > Align the index to the mapping_min_order number of pages while setting > the XA_STATE and xas_set_order(). Not sure why this one's necessary either. The index should already be aligned to folio_order. Some bits of it are clearly needed, like checking that folio_order() >= min_order.