From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA6F1CD37A7 for ; Fri, 15 Sep 2023 19:54:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 389966B03E6; Fri, 15 Sep 2023 15:54:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 337ED6B03E8; Fri, 15 Sep 2023 15:54:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 227C56B03E9; Fri, 15 Sep 2023 15:54:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0D3A16B03E6 for ; Fri, 15 Sep 2023 15:54:19 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B9555C0546 for ; Fri, 15 Sep 2023 19:54:18 +0000 (UTC) X-FDA: 81239883396.22.18C9DB4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 1B5181C0030 for ; Fri, 15 Sep 2023 19:54:16 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T5Bw5jLf; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694807657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yb0aXGGdlsQgU/B8FX1uy5m2GcMPKzwXuAhrykJSyg0=; b=QCQWEQhIC4WMn5raEqawvs9wZJ60BTd8aADG2lyFTKFxQFoDms6YalEXi6MC7NYBFn23zC 8R5i4Nb7KVQA2q9LuXsm+BPDqTcTR28FcTCAZxIIfUXTRZsEwpTSInfdsI7uLGBR0koqaS nv8u1roKBU2TgFfXKNtmAv1f8t9Ur0M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694807657; a=rsa-sha256; cv=none; b=EA4/L0tfGQ9bCe1LEDTIpScUd4GdgJl0nsB8SVvfQdl8mJvia2+qCNa8mbyexdtWUypcIe 7jewMF4qw2xquJEgrGNj+U1cbInpIhwykIV5Na2uHyRaShx/PwE41LE6qQTn74ym9mbhj/ x7te2dkHOUhnSasuXCH4AOzUnV4uiV4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T5Bw5jLf; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Yb0aXGGdlsQgU/B8FX1uy5m2GcMPKzwXuAhrykJSyg0=; b=T5Bw5jLf+rV8lN51oBY/eYf7vW 4tVlsQ1NaKbz7asS3ljwbDo3W5nrMMKRr8bNPLdR1/fWWAi0BWpXgJeEowhVaJmqlX4BMJB3w9nkm 6hP+2/dTfCEc5h87HFBqbPje020S4imv4jMOAs8vNP+UjzGGXlPeC1fbe1hh8p3pvxhAYVMf29HeC ehtemRFVopME8CgLhmZFeWsRnfESAWaW9SZe3WlzTsQgdmaDOTU4GM7PeNFpKBlBMk2POlni1Z28I 8//nYNO8rWCG3R5JHP68kXv0kOnIQB42fxbSS1S3dDFkJkDJP1Fi+J5dipw95Xa4po122Jmk+Ybo9 sjlUu0iQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qhEtD-00Bip8-8T; Fri, 15 Sep 2023 19:54:07 +0000 Date: Fri, 15 Sep 2023 20:54:07 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, mcgrof@kernel.org, gost.dev@samsung.com Subject: Re: [RFC 09/23] filemap: use mapping_min_order while allocating folios Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-10-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915183848.1018717-10-kernel@pankajraghav.com> X-Rspamd-Queue-Id: 1B5181C0030 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: jobtsog6k68e4c5s13y7tjib7rgdtssr X-HE-Tag: 1694807656-185362 X-HE-Meta: U2FsdGVkX18Kmaf8ZS4Fn/o6rW/NvwEpVxTcpxCFPX9s47zoDWFncZ2IBr+pZ/7jDDN45SbnPdyMWNorYpKOkMMelHzXzz+RRU5hPQrpzm3ghjjXv9AVauani7SnkLoTC3Wz8Q2xtI/gMg5C4EUnmYvDkQ0I0XH0bkyIKKw2pcZWxBi2e/nxJ9dXRAOYd7SmVFurYdVW9iBXXf9yXU9Z53S8mtiNAt/B9pwKcvYR8ArmIfOKlKhrfomWWe20GZ6N46GhDCaHtSgBLvkVmBYZqcYqJvlhfbLHFe63kvs56h3vOXQ0aBsJ989fFf3+i9xZMrJj+ZOV0HrLHGn8A8OwqBPCBy3lOrafhVB1p7OtFyffVm+6LZEIOHp9sij6V5yNTmv3UmKaL7AKiRqBggusrSBr2qh8R/4XdTEJG5M9IedTGUDU6XISZ6Kvry2C+bjpIaHSBmlKC+1aJu1CCcmWgpRNI21AlTaAik1ZKB72OvBn2Nh9sk2lX/mbdK11haqr0r03B4c3WK5tjJriSXTU0xCSSkdoqqtcHBElYzjN+Ukuo8DXzRLPRaxDtogyQ4npjBZD6oFaIH0pIWozDeRRghPS7CH/06So3/DsjihFgMoC+QBBU+QrQU/9seys/ePkjSEvPZqzB9VnMSe1VLA/F7Gv0PzXVHCEPh6mBOvgG/aBxzXMKBN7M+z3iD1NSBXe8MhSA937SxHEwYyFBZ1/r6peQIdJh/0m8CkevAwxCqyhakihRa61A6CWg3LpImcnJx6f01DkW7zM0qHi5uHXNpxuHA14WSYw2ih15eZRAefBcpyUjTzFZYQkOP+LuMYDsFtRKdgoFySklT+2HLbJW8TiB4i4AnsUe7Q8GSIyKzgT6CwEwvVtlyjTkyGMZcfNOWs9R5W7+NvVdoifF+3KqjBZoJlGGVw+y6lpb9+KUz6zq7rcgNOdtxh8OMYMBB+UxdsKBcPi5cOHrf1k4vP fjKetv3c h32bx8mOwVTwsQEJpaxXFiXvq0JYU9IhvdAU1c1SqX+tmDWqEmj+34WEQF4/8rrSmdCrosyx2llMORRS5paYfU1FlAAZqyZSocN88F0JiGdenRNzqW9HLTrhdOBrkMgWtqDBUA/U1VlT6hjkL9rwd5MU+J/g87/1ts5P9g9i4Hv/IBZeeWU90oS9HCDVaI/ABCuVFQHqkd6uVh/7x3kkwJYu50A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:38:34PM +0200, Pankaj Raghav wrote: > From: Pankaj Raghav > > Allocate al teast mapping_min_order when creating new folio for the > filemap in filemap_create_folio() and do_read_cache_folio(). This patch is where you should be doing: index &= ~(folio_nr_pages(folio) - 1UL); (or similar) > Signed-off-by: Pankaj Raghav > --- > mm/filemap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 21e1341526ab..e4d46f79e95d 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2502,7 +2502,8 @@ static int filemap_create_folio(struct file *file, > struct folio *folio; > int error; > > - folio = filemap_alloc_folio(mapping_gfp_mask(mapping), 0); > + folio = filemap_alloc_folio(mapping_gfp_mask(mapping), > + mapping_min_folio_order(mapping)); > if (!folio) > return -ENOMEM; > > @@ -3696,7 +3697,8 @@ static struct folio *do_read_cache_folio(struct address_space *mapping, > repeat: > folio = filemap_get_folio(mapping, index); > if (IS_ERR(folio)) { > - folio = filemap_alloc_folio(gfp, 0); > + folio = filemap_alloc_folio(gfp, > + mapping_min_folio_order(mapping)); > if (!folio) > return ERR_PTR(-ENOMEM); > err = filemap_add_folio(mapping, folio, index, gfp); > -- > 2.40.1 >