From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D5A6EEB596 for ; Fri, 15 Sep 2023 19:00:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 934AA6B03E1; Fri, 15 Sep 2023 15:00:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E3A56B03E3; Fri, 15 Sep 2023 15:00:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AB8B6B03E4; Fri, 15 Sep 2023 15:00:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6A0F56B03E1 for ; Fri, 15 Sep 2023 15:00:24 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3C2C3160D75 for ; Fri, 15 Sep 2023 19:00:24 +0000 (UTC) X-FDA: 81239747568.02.AB712C3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 711F81A0010 for ; Fri, 15 Sep 2023 19:00:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dNxhWAjf; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694804422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3p6LB8CUVtVpbNZXHYcZX6Y+ucECGrNpDuWVv6vgFXg=; b=ecJxzGPfa7fUIQGPlUB6w+Oz4ShxPXY5KxH54YJUW5p9TzINNhe0QHTCyZA6G+rC/McLj4 g4zsVxbBzGzBGbVbO1rusHL2F7/kS+wMaXVTCbdnWWI+lqfDSFq86o25a4BDgSrGvS4Ii8 QvqQ9F0NrF9werteeg1Rcr+m8v/HuRQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694804422; a=rsa-sha256; cv=none; b=dAtM51MpegUFy0OXoVmc23CBK8y0hXDzIMRWCPWiMvRwHeH50Lugq5jRpKUdxXNEZ4VyBw BmlXlLI9xtPZxnZiqAYqB2xCXKupenJaNuCcoRHzAz9VfYGFkZxx38nMMlEffv/O4ERTA5 1vk7dfeiZ4+2m/ujEdA1ZK6K1Ndfi/c= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dNxhWAjf; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3p6LB8CUVtVpbNZXHYcZX6Y+ucECGrNpDuWVv6vgFXg=; b=dNxhWAjfCz0PbN7mvJZP6JwFY5 5fCPxIkPJOoCSBE85XQGJvvRkZC2/YAQxa/+f5Vv6bKKfu81JKW58q9ZhErtujzXMWWsN3Y4vJ89O F2rAR1D6mK5LHeBUsq2HM/KUiCkia0SIHKzi4txeFdrF0AAwVO3ryczOHA8RNYzFyEySKyMs9ZaWN UZ2BzBig0eC0X9vDFqF2kHgJBmiU4+25LnK6Buvpm9KjqCath/hceLMcD7jqherGHfno4EW3liwgf KLVKD+FlFd6igEsNbCDpz7t5PFR56mmng7nwR+9R2NPGD9P9oMpAqrlCNKbiMMBjq2G5HSljBsQhu 9GcC7+uQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qhE2w-00BSCj-T7; Fri, 15 Sep 2023 19:00:06 +0000 Date: Fri, 15 Sep 2023 20:00:06 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, mcgrof@kernel.org, gost.dev@samsung.com Subject: Re: [RFC 03/23] filemap: add folio with at least mapping_min_order in __filemap_get_folio Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-4-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915183848.1018717-4-kernel@pankajraghav.com> X-Rspamd-Queue-Id: 711F81A0010 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: pgpfiak9xxrixtz8mn3nqni9a8j8isiy X-HE-Tag: 1694804422-99205 X-HE-Meta: U2FsdGVkX19ENycBTqb4EwJd6byZyeYi1WnM8k3kbULq2LKXF0o1VOJHwZbm2hEnZ7BCDD9cn6ezIG+DrjRd/QufxARHocS30zW5Zwu99uC4byYfpfYZ624X2mfxk6Sr7i4HK9fSvCSKPC9Q7cTWTYYHF72pYOjCMMSZ0yMARZry+F2UwzSeYnYBf1qXXKGAjDWMrRAWUNiGlJzewBePaF1WsC6wLKLwiTtUrDc77JDyrTf6K4krOaYXhziP8DvqJSBH9iMupYq5NWZOuN+opD68A9vnKG7RU0appPaiFHqSOTV9jFyitx1YYJj9ZIhll4lKG4z0Q1wBhtHMJnKoutKSJ79SMK3WrH9GkvRoP7IFwPd0zz6rWkmVoeRW5yhjyiBTtACJksgqVE4NWlJY+GiLc/fMlbkBflSuIkv8o8XthOChlTVZ78/K/eNS5GOKYrMJx7c55iUlU95Z2ZR4TbotHbu06d+UTSFYB28XSxFBWecPkcAwKTpCYnMc1Nywh6HzW5uA69e7WMIgRZK4pQhbXo9AL594Z/suR1u+LnspgH0HcULKw/hYvsUAHEXOzNOTkmsMR4dQ6QHnySVI67OhUHuVY17fpYF9VtZKY2Sl8a9JhJYlLLwsIqRxK8DENs775+f8Bn3lDQe/82KoU1crkUhtNJhdj5T1q32lNGs+mofzO8+pq+WPB7n1NE1rEQpfIeqQ5FtOxexCfQwwSLGOMOpjrfShtfAPafDDru9FLS8HtcVoqI9xY9ADcOFcwdudYUrLRdZMrut8sAUxM7UBJA+RdXf/YX0kLcw8Q7gmQ3yuaCYCnFm0xchexAjmnPUQSvGpiQoGoTtN/eTACwC8UntxPjcIfnghQ9aP+7rT6lukPlgUmsE7WRaeZLuyA0n6LFZTstaTAAbzBTT8moOjrFuKmKDLfGGEpNXinX6BOzoN9DPqRk185I2lIKJf8lgtz1LAYrv20uGe/yx 3ww8mg8L HVW0+MYkj2li2bDyBbUaxJIMF34XlkUL5tySs/bM54B1X0li0QUd2PYxqeOIX4GKgf3rC8yn1M7tf+6M0IHfkKvC2r4J4jUFfl3pFtyy5uPCWMQI1AovdWQhgMWgOdelXkxihX95TBDZZMIB1A4Fvm2VtpeQp2L/HBCYkzrTtQRDzp81mMCVOlQ1O3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:38:28PM +0200, Pankaj Raghav wrote: > +++ b/mm/filemap.c > @@ -1862,6 +1862,10 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > fgf_t fgp_flags, gfp_t gfp) > { > struct folio *folio; > + int min_order = mapping_min_folio_order(mapping); > + int nr_of_pages = (1U << min_order); > + > + index = round_down(index, nr_of_pages); > > repeat: > folio = filemap_get_entry(mapping, index); > @@ -1929,8 +1933,14 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > err = -ENOMEM; > if (order == 1) > order = 0; > + if (order < min_order) > + order = min_order; ... oh, you do something similar here to what I recommend in my previous response. I don't understand why you need the previous patch. > + if (min_order) > + VM_BUG_ON(index & ((1UL << order) - 1)); You don't need the 'if' here; index & ((1 << 0) - 1) becomes false.