From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16AD5CD379F for ; Fri, 15 Sep 2023 19:43:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83C066B03D6; Fri, 15 Sep 2023 15:43:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EC4A6B03D8; Fri, 15 Sep 2023 15:43:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DA8C6B03DA; Fri, 15 Sep 2023 15:43:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 60AD66B03D6 for ; Fri, 15 Sep 2023 15:43:43 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2AE28A064D for ; Fri, 15 Sep 2023 19:43:43 +0000 (UTC) X-FDA: 81239856726.07.1DC4C49 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id F11B340005 for ; Fri, 15 Sep 2023 19:43:40 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="C9/rSjco"; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694807021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0azTSzwIO5wB3GjrjXO4srn8WzFckAJ3B02EBtBBaAM=; b=txcyqAcUmdjtmTACSZiJigs54bF1oXP3JG2jjxmmEhJvMP6yUv9geWdJzrSacYJBLCemva UBf1xAuTiFLUt86E1KRivKVr+RrwU6BGaARlCk1SHZjU3hpH5lr9+KPWp5ze9dFu2Tjpvq MdRdVi6PUr8Oqp9eG/MjtKTQDG6Du6w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694807021; a=rsa-sha256; cv=none; b=o6B9pf4tOSekcHE7vi5nAnFy9sst6vMCjS8Bagh5G6SntsS/7bPzQGo+BNNqR+ZpA3W5vJ sGYHzEcWXeEXkEg+evgnQe7oGEcIC/rlGeA9W+SIScXo1EtajvCW6PmclHAp20OTUGvnnk y1x2aMfJPRBInIP9B8AZFjwF9xaU2Uo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="C9/rSjco"; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0azTSzwIO5wB3GjrjXO4srn8WzFckAJ3B02EBtBBaAM=; b=C9/rSjcoPUh83yvuYT6V9HdPDk 6NZtX7sEyAlPQ+xzU2EUKDtgrkAYfJ/sDrJ0RRW3Hl7HCLdA/HGZcClVAs+2MrrcwQgSIVqPsqbHn kMypNEs/d22C3W1VJp9oSnmdUwXQ8l52qTb4no+CrXXKt4CqRj9uN4IrJ+ku5dsLYxilzy+t6bBtX hqcksK4ufOtltzXJepTD3NjIOc0KzbxzYmJPJbxJ5eL9HdOBJLGbnNPOzBgFHbz2G9OS7wRmuRSbs D/gBMKLBS1PjL4GRTudevFiq5/W0OkDwgT26S7PaRIZGwQsSKKHmm4A6MWvjR/4qz2uC+9zgoMDDP ZS85RvVA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qhEiu-00Bfub-Ib; Fri, 15 Sep 2023 19:43:28 +0000 Date: Fri, 15 Sep 2023 20:43:28 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, mcgrof@kernel.org, gost.dev@samsung.com Subject: Re: [RFC 04/23] filemap: set the order of the index in page_cache_delete_batch() Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-5-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915183848.1018717-5-kernel@pankajraghav.com> X-Rspamd-Queue-Id: F11B340005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: smb77gje6x8uscjyfni1kb5ztmm1rjcd X-HE-Tag: 1694807020-326758 X-HE-Meta: U2FsdGVkX19/6OPUMc1dENXFc5gRjWmrlgbmfIJw/JM7qNuyIxjyg5wCx8Otu/t8Tz0hnpKfwwQ6kgMYVo3AMMv6UD/rAN4MPvRCCxG5s1sDLtV81cmDhiH5TvKQSw+ixIGmlAyuA32/20MOgp5pm5+rlnYnUij/EfZ24B1rIjbvq72ZB1Gc0DDdgKMD28K0cXNk1bQ42aiXCtGG6SUPOGoFCvt16GT7MY3WfofFWIpc54tlxWJROwchs+64WqfMaGerQMSuoigOIkiz1A/10sinpZGnyIo/Ws0uXJVNT+2hbdG0QU4z5On1i+xCSEcP2aSpZPxeOdJOui68nTaAjnC24fRuURfNGtBEFl24ah6vgJWi6EibK0Bj3jWQ1Uq0EXcwf0/FdHECq4btnSBjcZHFpucjGCES87NVRB1/R4zbs3iqNDOn2FiOeYY9mlJ0IE3KTuBdnko6z/G+tqamdDaBvJGp+VwTOK8fTskalRZYsCjKMCjLc2SGaGi6WDOYhrh386lW+u8vschLFjXSSLi7WvgEIcyczy+qRsHffw/6Q9BUmdW3XBauz1CzQ30vcBWUCgrmoa2vnGyFu9Ytxfa7vc9JCUnBmbgELd9SjXnxpV5/NtiUiTsq4Icee/yHi/vLdgr5WiZz2vt30omzqulpA2N8BSXNoLR2B5UuPDNqyIgt5PQ2ZZLLefpz8LCNzFCWYq0uyD64kH+0JCiUuNltcX7VnAMKszFa8doBcxTKKWR5HGmLpCbeBvswJXvHH+joyx+p3mSVWDkC5q1tcEBudBh+3hGObBrxY47KA8gxdMunhvJNE2n1tQ+OhjwMUSjMxe0ClZbKhGGmEEQTy+9VTRe5exGc8D34X/0tDWVmmECMzIh97UJ+HyG6LyiHiYz+kUGBBQL7Y3fmu8dF3T+T4kTUJuUL3sufaV7FhzHvjDI3CGqcRAotC4NXkve00+cLf8D8kGlvbi9k6TM pAQ7tmZN gYPllJ8eNDw795MZ8dK+mP/o9279knqjag6LL6xCSgiq+3p7QojpUP6VXjXlHvN0MK+vs85jdV/qyIFr2UmpMZMo9qdcJSucpjzlAy3HzokbCd1C6I33fY6XS4Tn22WSQkG0HAM0MN/yIWLmrcsLDtalE0G/6qCK57cFrI/7Z9Z6sThbx9rMsjYQ6CiuMY8Nd0/Cvjj1SHZZKhoFDiUOsqa8RAZ5tLkci3AeSGGl/42MLStTyFXzfO6s/fA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:38:29PM +0200, Pankaj Raghav wrote: > From: Luis Chamberlain > > Similar to page_cache_delete(), call xas_set_order for non-hugetlb pages > while deleting an entry from the page cache. Is this necessary? As I read xas_store(), if you're storing NULL, it will wipe out all sibling entries. Was this based on "oops, no, it doesn't" or "here is a gratuitous difference, change it"?