From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF54CD13D9 for ; Mon, 18 Sep 2023 18:09:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73F3C6B0408; Mon, 18 Sep 2023 14:09:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EF576B040B; Mon, 18 Sep 2023 14:09:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B81A6B040D; Mon, 18 Sep 2023 14:09:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4D23E6B0408 for ; Mon, 18 Sep 2023 14:09:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 12609B3151 for ; Mon, 18 Sep 2023 18:09:10 +0000 (UTC) X-FDA: 81250504860.06.E4F3DA6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id 856621A000B for ; Mon, 18 Sep 2023 18:09:06 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=v51lvSCH; spf=none (imf19.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695060547; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PSl3YIBcOMlI28KGljTBp5+6rpOLjzI4VlDZcO+V47g=; b=CziWl6MEOMB6PhTH4mJw4IvavAVDPmfin/awkmBeCRpdjwHK3bSGmsyWk7B+UD++VYvKUt uU0lz2yD71o+ZYshXT8+EsFDgdRaVTIjpgsP4NBcP97Gb8Hpd/mjYBsTfv/41aj56IdIcg qdxIlWDQStiSFQPHo/Ny7AtoNXxIQXI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695060547; a=rsa-sha256; cv=none; b=M4c6+s6XBha3FKyJZKsePnsBt6yVvPZRyl2lsvyxMUl4MrhN0ibCxHyPZt/emznbTodB65 vAARp0KNDoSsz4E3HYKlrpBjHaXEpuNE0PjlG4U0NddfU605n6DJakzAa0jx+382AXcnuA +mCvNDxhTWUfsRgzz/EkgX16ZMKgXTo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=v51lvSCH; spf=none (imf19.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PSl3YIBcOMlI28KGljTBp5+6rpOLjzI4VlDZcO+V47g=; b=v51lvSCHJ27MH9SVEXRHAJB7qA w2bmT2C1j4sY40YT0/lBFqUnUQofZY/n9WBhFCJUODtoIRh1Yhi6dOTCfiid1DAA5T9ItyXXUffq4 69/1uJ9eBsRomdm0UojreSlngN5GpIIKlXYZaHSmiyDSTmmkIMIiiVlFRkStsGO2zmdKi1zUQ1h2X UXxxarA3pXN01KQqteWffiqwvCtCnZZm4fyutmKct5sD9jNukJltAcKA6UGwwL/ZKljZR3P/wzI82 KePlKSnNqxk7hiuBh+qjfn0mBcRw3fv4ieCqpCkY0JMkZM3bhv4I4UYRAZW/TlYeyKnXA6lPMOB0B 2/05ZOPw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qiIg8-00G33u-1d; Mon, 18 Sep 2023 18:09:00 +0000 Date: Mon, 18 Sep 2023 11:09:00 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: Daniel Gomez , "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [PATCH 1/6] filemap: make the folio order calculation shareable Message-ID: References: <20230915095042.1320180-1-da.gomez@samsung.com> <20230915095042.1320180-2-da.gomez@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 8sy49j34ktixcn7um46wyr1mw64qucxs X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 856621A000B X-Rspam-User: X-HE-Tag: 1695060546-861892 X-HE-Meta: U2FsdGVkX18N8/PPwYZgCW7oZbqY0uOL+HD4djGOh0SmQXuLl83N93gUJj/8/fhambsPXVnfOy0AmBk2lrjoFlL5U/hDpI3vtpWF0u3lW8Sol+XpRRlKrqlhWZZJkZ+BMYXwNgd3N5xHbSVy5M2qB1LLpyhhVSxCtPsCdlh0MMBGEsiwRhiYO8D3pnxzZ5f/E6RqjHiVT8YdK742VY4MCjABqO1mKCnoIiNx/60S3zVrnDYeSWkGeFqzuqjvjiMXtqxfEmIYsu7p4HZtbmyl8yCsVTMOp0oiPtAUaWyaf5aBeH19L+2zSk/W/TIOp8sU+Cs14DV9u4Bt3mxGjUj8un10m51iKrHtJ5eUulbP8OGVegto/sl3/6tWBb5/G3NiQMBRk5eviwce63lIxuTNEQWMCPUg/EXBZbZoWpVVV2xt0+eOwcABtzE851PYWSe7jCOE1omXCwgJDdxqErEVohV4XiiuoT+ZS1EYPEIr4zSYe96XLxj/AuKQL69LD0lsSaCoTmUsgW8Ds3staASoIFQBpHODR6GFAf0lVx4E8MjGjIyw9Z1S1XdITtmTS6H9kqZZv2yKsMqQaJNIr0kSQ36SKaaeMuNbo80/sDHmPBaiBZUX2WTlS/ZD41z4/nwWz4sn6KAfD+jyFQlniGe0TKP1E1lfm8AkXld0gpXVDWCWb2Uakch1+KGaEzsMCwvoCF+Zk92euL0lzNA53lpPPKadiOwthgtFwvzRQ99RckxjzEvfD6YBm7lnqswrKOeaz7ZL1Dw890zx3fg273JliMz3BllG44hS0BmePTuyy68r/Wqq2dEEORF4P0lzahJ4qj1taKOToaRjbB7VJwCSNWE8NYqEXJcPW42Frg2TFEdQjHk5givJZRAwtcGIlfuNGgk5Piw+oaPrx0Axqd7PKvs/OdSOY7pNg8TkSqjJDeVC732tYRFyOpwWM5oQ6CUS3pqD7iW9k9pBqdB808y tA92mPWm 8aLgM6NkiViJi4PSdTwXUrCGJLwEtWlJ9RxNF1c1lLbVTAPpnadhGY+wmqfgFbcMjoqOGvAkuteYLmMKFyQJHfyrtrSCSjEln4oUj6ZP4O6LBkspid+jLMljcrq+95JaN5WwtUPFLB84ek17iaiMJBVJY0VvGxSFKXXjB0OXr6ynob4rS/LPIKFpZ0u/woXdkVwnflol2WV5SoYC2Lu4cUM4yRRLbB2MN/4gHJwVSMilKswEACK3myuVkn7BsH7tPGlejMOrd/XQqDVo4gh58hx6ZpTl7k4qegwNIms1IudidRQGLhxJffjOijVW9a9WhstWa4WJWc6QR2JcSzrvjuZH1n/6BUBw2hGQINldS/a/wZWRhcw44IOw5SQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 02:40:07PM +0100, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 09:51:23AM +0000, Daniel Gomez wrote: > > To make the code that clamps the folio order in the __filemap_get_folio > > routine reusable to others, move and merge it to the fgf_set_order > > new subroutine (mapping_size_order), so when mapping the size at a > > given index, the order calculated is already valid and ready to be > > used when order is retrieved from fgp_flags with FGF_GET_ORDER. > > > > Signed-off-by: Daniel Gomez > > --- > > fs/iomap/buffered-io.c | 6 ++++-- > > include/linux/pagemap.h | 42 ++++++++++++++++++++++++++++++++++++----- > > mm/filemap.c | 8 -------- > > 3 files changed, 41 insertions(+), 15 deletions(-) > > That seems like a lot of extra code to add in order to avoid copying > six lines of code and one comment into the shmem code. > > It's not wrong, but it seems like a bad tradeoff to me. The suggestion to merge came from me, mostly based on later observations that in the future we may want to extend this with a min order to ensure the index is aligned the the order. This check would only be useful for buffred IO for iomap, readahead. It has me wondering if buffer-heads support for large order folios come around would we a similar check there? So Willy, you would know better if and when a shared piece of code would be best with all these things in mind. Luis