From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DABACD13D2 for ; Mon, 18 Sep 2023 18:20:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB45D6B0419; Mon, 18 Sep 2023 14:20:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B64496B041C; Mon, 18 Sep 2023 14:20:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A52E46B041D; Mon, 18 Sep 2023 14:20:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 96D536B0419 for ; Mon, 18 Sep 2023 14:20:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 68B6E120415 for ; Mon, 18 Sep 2023 18:20:36 +0000 (UTC) X-FDA: 81250533672.09.C6CF2B7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id BA0D140013 for ; Mon, 18 Sep 2023 18:20:34 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xP8ctjwJ; spf=none (imf11.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695061234; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YtFZ4aIMH+wK5gxLvaFez4GPeCFUiImPTsyXwfH5C7Y=; b=7rvIE/U33Vxg4pzCvjUSE4MYuVz7hKPx4bM988JJyp/tOISuWjxiGczlCmuC6RWLFf2t+u Rm63t5StED9wwP7403VMb4WM/3HzNTZOA3VkEBfX943Y7e2frXFZc8HCyCQxJOSEDO+Fec sDXIK8n2B8dKxz7p9R6PsThaqInp5ZE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695061234; a=rsa-sha256; cv=none; b=vuShXL8OSEkiRN+CD07j4RW54e6AZmHwPZNNpFHSMp4QiQwtzCmWx+SGqykBP9xEfSDP88 CxjtqutTrG+6nHY5kn4olu8/xy0EIiv3qBrwTyMUL5lsDWWZJaLFZ/LMTbaG87Vluds/An vpYCwrkl5aVrLf6gegkKk7OGWLkXKog= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xP8ctjwJ; spf=none (imf11.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YtFZ4aIMH+wK5gxLvaFez4GPeCFUiImPTsyXwfH5C7Y=; b=xP8ctjwJh6nbn8EmKDuPATY+1P bebaZJXtSL6UspdqmjCpgGWN7G4EFwZl4o8h8y0gFUPPGp9L8nFi+3VaH0gOf7kX+whvSsQRjV1or 1u1KVmuArHYxagGNl7R9/xWe3FEjATP2Rf5uVeFt7Vr6y21uk3O9IzWk0eb7Qm5JaXG6PHClEqu91 8vw4ZCb6P3fRhMRzfM9OkcYS72jaD2p9s6Q+keZZEVtUFeddKHtVfHyhxq+c7vo2rm5SeV16avKib EmjyxF3KYOAIVWGBeeyJjjOiVkmeGaa0W7G6Zf6Su7hGbq284xw8f66CI3ZBDx/+/D3lXbXo6Pu1j mmCMH6Cw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qiIrD-00G4Zw-0J; Mon, 18 Sep 2023 18:20:27 +0000 Date: Mon, 18 Sep 2023 11:20:27 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: Pankaj Raghav , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, gost.dev@samsung.com Subject: Re: [RFC 04/23] filemap: set the order of the index in page_cache_delete_batch() Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-5-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: BA0D140013 X-Rspam-User: X-Stat-Signature: ppfxnnyas9rk8izbab6tg6xbuso7x9ha X-Rspamd-Server: rspam03 X-HE-Tag: 1695061234-303486 X-HE-Meta: U2FsdGVkX1+fqBhhoz7xA5msK9j1jd/XUVtO+YGeTt7Xhdj0tFgI+nxi7q634TimN7QxmecIx5uNT+L913WlCRSSgxuo/4jd5KiPOtyCSWWJ05Q2Apo9Z+8sV6uo+inm05ioYkEQmDeNcPAsXbxGJpmZSp0KaFSvpvvAEOgGjJJQ/McHLEJy6c8FPX4qDLHb0CWfIuZMUG3aW4OAxtunwf+smsakACDjwlFXkuphND4sHkYVCTNF3X7lwJmbIqIpS/oahA3o8ic93WDLfJtOxFmvpX4fi3V6aGlI4X5dSypJCRwqpMmN/xd+OS14OK8gNJuaHLWE1qZVStEHXdKVPSbLG9NFbXVS9xA4owfQuY61PlYhqBLeinj0ikWTpMfbXIkwVmH0Gg12hLlg41J7Z2cTFI1eGcrLFTIfr4p0RAvfquLsNgZ/xe/SkST7LDBfBIcfYX6SwFBYBY2eBX9T08oRRJ1GY2lPlbyWSamDM0BUSVOYXFFxxq+Q+XkpEajWjH9pjt40j28owxaMQMzvtLC619N+YH4o6BqR1+635nY3zq1cAldzy9MsG9sVWX0+t+PHfMZeRcV4wbBInqruFUZVPxZuJsU6SNPxeb3g+jpoeqObQuop9TFG2/oz0X1uyuMqdvUqERGHG/ifUnszf7+o2gIzFo1DQtTqlsUk4xfza5RXd6ImoyC8X1mTL4jHzchC4HCE+65HJBOdE7hF2ua6RmLUAomuFSRn+/38vOZFgCSvQStHtkaeK5GsVRbKo/h5k5Wv5tFvfFKq29aviUe1fddseESZeFsjAPp6H2+fFc48/H7yZsFWQJjuKzC6oaq7/H/TxyYuxONQ9cJ2iO9yeXq9zZyA/XLZuaE3IpD5B56fSHw2exU8UIzdLppsfC4bGyiI0tremYvCzZYar2lRAD2aSViD2ySRWapZK0Ox3UKZFXGZFyr9t8/EKfPxZTmHy5ADvoaywVXh2Dz wpVd6yK3 0uRvag9Z6R4LkGtPidh1weaxXVXXdKiBQa/YRyHCHOF85KaJ4meXEfb7oWfwSasleL3N0hasQJapdMkpetvADPbf2ZY3+0SAFx8S4KuWMdVjbvIpEmJxBPzxVxfCNauVV1lbwSlhh3tkjcVaLkTGjlosDQ1ofXD4G3LNub05k1Kmq+BO0g0jsdGdbxwdTj7O86cDoal7wg/Lhy0atzIDnV0kGOYjvFAcmdrnZ8x/j8+WTUF9wCdZqWALJKWOOBrrpmvuuXcB722pkc64m1IGrWY0hN2dmfuvvVBSEjYlE4cTd65F4Uf9K8w1MeJAUFa5c4myyh2KT1QUffEgnPM/9aYYin86+m2SeOq0ou92hUnEMiKylEriKKRrKrumod2xL0JFujNFWvaM+sk+GtUQg8baYwp1N8X5PNXPw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:43:28PM +0100, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 08:38:29PM +0200, Pankaj Raghav wrote: > > From: Luis Chamberlain > > > > Similar to page_cache_delete(), call xas_set_order for non-hugetlb pages > > while deleting an entry from the page cache. > > Is this necessary? As I read xas_store(), if you're storing NULL, it > will wipe out all sibling entries. Was this based on "oops, no, it > doesn't" or "here is a gratuitous difference, change it"? Based on code inspection, I saw page_cache_delete() did it. The xarray docs and xarray selftest was not clear about the advanced API about this case and the usage of the set order on page_cache_delete() gave me concerns we needed it here. We do have some enhancements to xarray self tests to use the advanced API which we could extend with this particular case before posting, so to prove disprove if this is really needed. Why would it be needed on page_cache_delete() but needed here? Luis