From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06999C46CA1 for ; Mon, 18 Sep 2023 18:27:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 773906B0421; Mon, 18 Sep 2023 14:27:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 723936B0424; Mon, 18 Sep 2023 14:27:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 612986B0425; Mon, 18 Sep 2023 14:27:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4E37A6B0421 for ; Mon, 18 Sep 2023 14:27:55 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 206C6120B55 for ; Mon, 18 Sep 2023 18:27:55 +0000 (UTC) X-FDA: 81250552110.21.883AA75 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 6C9DFC000C for ; Mon, 18 Sep 2023 18:27:53 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=PnfRPAkB; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf28.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695061673; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ioEeAGr+2NV3niPRdLLhdMSROTGhWvYL7RpL0QlpWXo=; b=ZHOCXQnojs+CBEclFhx+1Oob5UtJjwjf88myval4fRz6k//nSfzk3Vvk8iFSetmxu0G123 5/SbllhqlwN8lKbPx/8PMLvBqjhyXqOfbNuCtJeEzF8H0zg8sZ7MaaAqvnRSovnhExj9Nq /Juk4g/scdw7g+mdu+akY+es1oW9Adw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=PnfRPAkB; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf28.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695061673; a=rsa-sha256; cv=none; b=fO1LbhWPJLmzC0ua20MxRP+mTFPPrVpOf4ZEJrP3WRUw4tZareUKsa4UkVT6QLM/NwhC6p J2PINGhCHNJ9ZgsUsMBEJgQZynhW9bOnrGgar5tOqsGM8xq64oHIAQL76sV8BfWjAd3leK V9T0ZP44+MSBQKDaZgM5mCYwvqwEcHY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ioEeAGr+2NV3niPRdLLhdMSROTGhWvYL7RpL0QlpWXo=; b=PnfRPAkBF0mMzSlbZyC87L/2P8 hax/k2KlhyAoApjRDSwNcg5w4O1qCwBtBHRybKE1zQzj80vHiy2j2dI7X15GAb+Znu7FGbDdGgVvB wfujJfBcPFioDiKB9xDpcKdWf8/uuQYl5rdvhzoAhGwudtXTUVzsInO4Am7F16uE7T337/N27315u yCoK0kwJjAy0BKVDORUH++3XKnAdP0w8pihdcPs/3P4p26/tTXg2b/o1hJ5/i9H2W7Ao2rJG4Xf9z I382YPvkdujLoFZ8+274K28EB5kjsINTeIpRuxcj+BmmX3IhAKOC+QK4a0I1a8+LzIBFDs+/1eM8R pckEMDIw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qiIyI-00G5AT-1k; Mon, 18 Sep 2023 18:27:46 +0000 Date: Mon, 18 Sep 2023 11:27:46 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: Pankaj Raghav , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, gost.dev@samsung.com Subject: Re: [RFC 06/23] mm: call xas_set_order() in replace_page_cache_folio() Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-7-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6C9DFC000C X-Stat-Signature: yzmwn9szxw97jqz1qi8afjg4byxzk6it X-HE-Tag: 1695061673-520837 X-HE-Meta: U2FsdGVkX18xuFIjaLIpSQhZAxZ7KMqzgwo4dagYaHLs9KazxhlqbkXOgxhXnrE6UH0Ey3E8kyKGCDBrgV4o0gz7wc8MrHN4Sp4IBFENAU4+xyplB/hoegSgpZf5KKw45WklehInTPrV0aMbc3exKuVTdhtt1tOYh5sCsD8rK5eJVJIL85OSiw5ltxgLC1gda/9AoFbbjUV2mBn7gFOA5deQKZ6Nx7+T4UaIfDbrXKoTs0s4qSrAlfY1Lh4Ns6/CXYUf+77lZp89Hla5pPPOwsrDQBQq+r4sfenYUcwKyhihudVVMqTROAZEtP6fbmNwgW1+a5TtiogkMsBixCsbEXdlgilNvlq88fqwSoEFkIklEF4ogMkQgr7dNGcf7l4nvmgi+2SxWOEpRjFmfpUlNBkBI5gJBKN639CILsvam8IhNrjZM5qrdizcxqBxSVYAU0SjVSOYa875Uac0QWb1s7paVsGFPTpURTEzQX5l3Z33njzhCnfI9+xvLEeQpAzK8PJACz35CIODThL8IvXuJifV1vJjb2k8PcODx4z8GpmnPWCAMzOm7Lr9DKg0dHJQQS1waTNeZO7A8huNYGH/bsbO0NrsAqi9RDpXNZ8ujoDQXHI4cf8VJ4hz4KFo+6PcCqq4hGIi1JA5hgcjTQSzEragMk/iRe8YP1nnXEwna3A5nZYKK/LpEIQhjR0LeA5wE6pXHjHB2eVaWLqvvq7UeWepmiwTW2aAZjWjUvDmSJPZIe8P0vhToU5ft8dg55Sq2GUm5M55Vn9KYJQxBpPaVxAxBNyFmpKudub/GzCQYBivVXHGcbK7jggYNhJ1226hdh/r1dOLpy64LVtISPHvGfbaZoxGH74xzepEI5r35dHgHzGK8rThRoM0ETXTwY7vqs9UzLFDGI9GRHW39LMPQU53gYq1TnbS+3lfYzjsNypHGYv2y1Nx/JLDUvppds4ah1Qio8vVq82CMnQHYIq H39pI7Qa LFvmquy0ULtSIbEEWYJujZH1TMVvR3s+mctxFssIRwAQt+jNV2Xd90+6TohEvsfsvIyo9JogqqAMXIGAEKoJBlqsri4OsqOzwLbW48QzEPpSYvD4MomCaULmRzz3TEKhi4JtpMzRuxqlNL9yhiY0bvhWGjc2dUMLkBfmd6h50PtUpK9SX1tMhVM1GWN+yYosCOJ1UdpFCNMLlvy0m6uM/F2LQ516qe38l1/MyICXveUikJ8T2bqzvW32YWtIQ/eiiEtgHjsWjNdEDI9zJ1q+oMEP7RMBw+drP1cNiA2OSJ/KEAknBTQCcCyqh3s2HCGASdDLnx6G/hOwkTxCIvAm29CiEPElqkHs83QhDYcpmQI2aDEJ0+o/hObh10OPZn3gTIv/Q6ABR8ogBTrN3k+ixSrCukqwVHiOq/yKYrl7e8MFU4G7HapOLL6r/7N80nJmfQMUL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:46:10PM +0100, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 08:38:31PM +0200, Pankaj Raghav wrote: > > From: Luis Chamberlain > > > > Call xas_set_order() in replace_page_cache_folio() for non hugetlb > > pages. > > This function definitely should work without this patch. What goes wrong? As with batch delete I was just trying to take care to be explicit about setting the order for a) ddition and b) removal. Will drop as well after confirming, thanks! Luis