From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E514ECE79AD for ; Wed, 20 Sep 2023 03:57:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 799426B0101; Tue, 19 Sep 2023 23:57:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 749C96B0102; Tue, 19 Sep 2023 23:57:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 638466B0103; Tue, 19 Sep 2023 23:57:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5087F6B0101 for ; Tue, 19 Sep 2023 23:57:44 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 29BAF141055 for ; Wed, 20 Sep 2023 03:57:44 +0000 (UTC) X-FDA: 81255616848.02.AA87911 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 8E40A20025 for ; Wed, 20 Sep 2023 03:57:42 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=swRfjP1T; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695182262; a=rsa-sha256; cv=none; b=eUV73s9rgMPZNtwShqEDuXTIirvGkrvHTiwdk4QFSOdcSACZ5MnghixGTcZEEoziwRGMHi r5tFzqc1b9OV2D7JJo/5vWgfBbxFBOXYgeOTBK3uysV6VJbJ7O6CoYrurBcTJZ3SkUJHcZ Vp4A1c977Ppa/xSd+G9Bb2S+fe4HPkE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=swRfjP1T; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695182262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A1BPMwH2UDIlMDkUUSRsazWTjzTwQxn28F0/xEN7Fd4=; b=hVNhTop9Dfz80agkYWDcu4qOok/l6OPA2zsle9TXATc/tgrQts5S5h6nSsXKxpwKmzHE9p 34zGAd6fLtweczo+B9+zdrTSsKPnoclAv4fr9dZ9atta0icxZ7HRuXucjdLByfun0jhuEz XpxwQaoYoZ4jHx90la9Nu05GD6mvRDw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A1BPMwH2UDIlMDkUUSRsazWTjzTwQxn28F0/xEN7Fd4=; b=swRfjP1TPecEPIMAREeGgZUpCV gyR9XRsySpjeM4V6BJvBRG2OpeK6665cqxzP2t59HDLQ4KawzavOowyjJVBtf+HuZ0ijua423WLzF SbDyI8V1NzhvMSjyD2HCWnEYr18f3vzWkCL/Tu/x9m+VhA/rcg+sXuJrkspvNuhvPBDNBiFQkW5eC PUa3IH/XU+OQC25+8qO5IzX/3JQ9b2IHHwgpDkZqvlLjt49Jzzbte8o6HQwxQCmqH6yY/CEQkA+S3 xHbUsbfwH1vCG22QG69ZrBp4NFP8L/JxgpQbtwtw0pUE33jYQCEYj+LaGc92BjHt/L42kLS+NLqZk oK3dPDpg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qioLF-003aQw-7D; Wed, 20 Sep 2023 03:57:33 +0000 Date: Wed, 20 Sep 2023 04:57:33 +0100 From: Matthew Wilcox To: riel@surriel.com Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, muchun.song@linux.dev, mike.kravetz@oracle.com, leit@meta.com Subject: Re: [PATCH 1/2] hugetlbfs: extend hugetlb_vma_lock to private VMAs Message-ID: References: <20230920021811.3095089-1-riel@surriel.com> <20230920021811.3095089-2-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920021811.3095089-2-riel@surriel.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8E40A20025 X-Stat-Signature: a7uuzkq9edhoc4z7f7b5k8bbtkkdbimx X-Rspam-User: X-HE-Tag: 1695182262-845243 X-HE-Meta: U2FsdGVkX1+ebE5b4JIroukxj+f58nswd3a6BcAG8zlDlMvEPw47cRH6EgLZUczUt/4Sr+Ig0YPS6y/k4nFlLW3q6vH5lyptZs1aVrIlLI7dDxz37VRGh1v8b8EOthdrBUVTOSwgkT1p/mIvzUKrYtqwQzFMKdaQ7IJmFzqn/jtda23lLSAa2DJ0qxaJVRyh2FspRZqG9mwnxLdPRyIFxidLXg1HPynKhabqua/ZikHn2BVhPpKPCH9nrqlq0K+PDDPFs9SuICF/5Xy++LqQGs2pD7aHtFHinxcUAikHzGJgE2aFwZapKh7GZAGqx84tnkvV+q3VBMWmV6/yfeQbIivJHhvAqRTC13ZGYi6gG3AWgbmwkJhn2Dh/nzTF3P99ZX/nN2HEuC9VLmo9vpjcnoYUt9mx3rew5+xHKWFDz2X9lC3lNyHWWTWkRja5BHY4f1P0NBFcPBSdwTPCGHkXGV6s/vuydcZmReQRvqVCpOeu4H51ZFTYGVfzd0Tfx6ZoOiCLeeSLYgTceN2dkyPGd1rCbu1NtIHkBVii+84g/WY7lkshENBaxr4u63g0vVbLGAPhFEf2LD/t0i5W6UfsYe00HzCFUhNLnEEJ9mswZkXH5wUBaDykPufBX72DbJRECM8P+j1SSAlbhNroDxLBEEYOpFNhk8ZZM5NJGb0Cut3fhKVj7ztdGCJX+j1YspBwCU1wKO73KJ3pM0VKti1IJtmq32sp++tKcHPqo6o7fqvBXPO3V1kM7kZiwQUQqhkrVcBn2hhlDw1nwBxDJzunNgQT92vQ8ROTaByLoVJJck+LBMwY+AMZ6Kic+5XAyG4ljfY11qKLE0+nOq4SCSzbUEbEbHPcokY8UUjgmpXJQef/zy1ME0DrlxY6jtmJGXcFme/i5dWXP0Y7w/uGeS4nzX61Un+bOzPKRuJbFHy7NBWIQ3RpKpbM75ozT/J5LuVQ3XRA8Iud39xPQYqFWue NbWaBcnL ySziwMiM5hwLJAjK279VmV/2BxINpPnqJZGMwd1yS0KDsqzHec/sMf+6NPOeAs5vDRlOn8NjqDoTs9p6hqN8XPNyL7ycTegHaloJnRNlEQRkrUaAHM5WNtSAxe7KYtcCVJHxlNKZ/QmiB1EhhXxVuxdNlSpOhU7DQeZ/IZWz0XbSI5w7SsKDkJh30utS8XCXZ3HyP3IUWYKZrK4F+YvoVUcsGxrKvgKr1czezTRVG5Bail8I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 19, 2023 at 10:16:09PM -0400, riel@surriel.com wrote: > From: Rik van Riel > > Extend the locking scheme used to protect shared hugetlb mappings > from truncate vs page fault races, in order to protect private > hugetlb mappings (with resv_map) against MADV_DONTNEED. > > Add a read-write semaphore to the resv_map data structure, and > use that from the hugetlb_vma_(un)lock_* functions, in preparation > for closing the race between MADV_DONTNEED and page faults. This feels an awful lot like the invalidate_lock in struct address_space which was recently added by Jan Kara.