From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE344C05028 for ; Wed, 20 Sep 2023 21:03:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED2F16B01A3; Wed, 20 Sep 2023 17:03:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E834E6B01A4; Wed, 20 Sep 2023 17:03:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4AD96B01A5; Wed, 20 Sep 2023 17:03:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C47346B01A3 for ; Wed, 20 Sep 2023 17:03:53 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A00D7C065A for ; Wed, 20 Sep 2023 21:03:53 +0000 (UTC) X-FDA: 81258202746.25.E7E1411 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf16.hostedemail.com (Postfix) with ESMTP id D947718000C for ; Wed, 20 Sep 2023 21:03:51 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gdC7dzcp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of 3Nl4LZQYKCE89vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=3Nl4LZQYKCE89vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695243831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=dQNu0IeOSMrWyXebZAW549Tyo0u81eOO/aawLbAoARR3zetEhuc7Rxyu+j/SoHYtuR8Ikj 8VOpJLtQeLCkgb0kXAk0V6mefBo+IjxaoZ70Pj0jaShrOwEgkZvPhnhDt9wtKnlBcO2GHr 4EcCXxx5hfsKtLC2v6/ZSK1aGqi55QM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gdC7dzcp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of 3Nl4LZQYKCE89vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=3Nl4LZQYKCE89vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695243831; a=rsa-sha256; cv=none; b=sq5dG1Tn5GP66V4u4V4Z/3Cb7VI7GpS2tAWU0HvI30H+oW70AAVGFNYe9urRiw2KjHbGvl b1/jsuvztm1Lsywmy1VWNa3hb5UktEdvxVa6NlSG/kkC3+5Pp4cvUKoWBL10VeSVS4s4q7 Xxs83TZJhbQSaq22aXee1NQZLKccnmc= Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-1c577fea3dcso1840555ad.2 for ; Wed, 20 Sep 2023 14:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695243830; x=1695848630; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=gdC7dzcpT4z1SipYH1mEnzw5U3VWgpJ3u50bdmy9Ha78IpK4G/oeSTLKCajM4HWmmk AV7YZwxVaeo+V8MyIqPYUDigp1Hvwyr7DwnhNeENFhbySdxBolDa/10do04nAqlS4Xqx X4aS45YRxS7aP0WqaTUooqiyr1PrJgjS6vNLchJO/dYMM3R44IxNlhph3ADK95M9PN6u 5GG8BA7tafywYtqobrPJUPRu2stbL1fx51T1GD+NIPW19XJriR4XrtFLIMyvE1RoIKbN 60aV8veOUpoz3SLgYU/9/xnw17kC70tdJoxTgg80SlzUp7yWgt/QooGrson+4EB5wSHO VsPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695243830; x=1695848630; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=UXLlqRMURzpogK/Lb2cmwX9iGhWAGJFtgIdYI02USVgrg4/Uo4biZLeQ7FX2wf1/ZN dnqza6BJe8F/aMLdntMvgySIcsozPHatsyMdoLr7sIGB1N9EwCVDdXXARS8c0oMpoWp0 DESwg2Tbyfi6zftBMsbrHw/k5IWno+F8+diqTLDIqiE5Sa2EluBd5Z4KELsIz2kkbI4J bruVtOiylRVAnxv5c5FBuPx7DtmmRRZmAgvn55bNvk3plxKTt1Ng892c6/aDqGW166/x /OQ1nuccV+oUFojGZEw4BQP6Qhw3nSIAjtR+8JZXpRLuyN9Z2e/ZdfeVV4tzkHhk4raA qnSg== X-Gm-Message-State: AOJu0YzAmDV39/CVHExLoO5TdO970rmg4fAJguX2ncs9F2bRBlf2WtAX QwG+qDLJOx4AA+TAyvNCkRdkYb0L07k= X-Google-Smtp-Source: AGHT+IH5QBEwnaGAG6ouJVZQG2FiwG4z7ywKiDhgLSOOF+0VMXfLus6G3HR8pg7XpQjZrIgu3wnPZ1Tf/l8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:c407:b0:1c3:411c:9b7c with SMTP id k7-20020a170902c40700b001c3411c9b7cmr51568plk.13.1695243830643; Wed, 20 Sep 2023 14:03:50 -0700 (PDT) Date: Wed, 20 Sep 2023 14:03:49 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-12-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes From: Sean Christopherson To: Binbin Wu Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Stat-Signature: zga1gyqayojjema36pj36ru5cyuettzf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D947718000C X-HE-Tag: 1695243831-621322 X-HE-Meta: U2FsdGVkX19dULO/C/dHnK98N47ieWzVCSIIVPbMxQW/kLwh0arq6ExhjILVgEmQCCM4QygdbvoevBCUOsrLbrSNp8Ot9UCY6a+CMhOXuJ7uXefYBC0RjuNjCz/6LLpqtiZ9w1wz4nL4ID9FHnMRJc+9o3QJu3K+d6mbNHYdDK3NZ9cmBS4z4z8qWUp8cbZYFlxh6wEsoKp/oqHrn1cE7NBQNhXc01uV74lIx5BJLOljIwFX+XvplkqBH7dK8vTZkySe7UMLZKFWOXXlpCa1/upTs6uc7geLKfQ+lref4z8K3hadEbO7uXcNMmFLMqbJ3hJuLaOUedrW+ncZAEGYBXsF6X/aSPR589Vlq4mvt34qO0juZIl1TY4fcSIjCb60c4fgB3BeGar9mxF6l6kYRNoJYzm5kBOZ29aOQEWNQ1ommvvtJZUm32DeBFLJ2q4kV09SZBPrmmHRHcGVPyMfek4iGzmovOL0QTTXQvc6RZOG0I6reoHIJhzFrA9DGHZ4243TlcY0FYRhxqwUr839MXh2IekXylIFJbKutNkLFW+gkSN1vkynWgeoyDrix8liBs069/1M2lDkS13o9WXryjc8l4uGLXUmq+UGqy97CU3hulE7AzzQKsIDnhGo0Vs96H7OlbNQ6qPVxDLSrNIYWGQyz6ve32c6H3hNw5qf94K7XVv9kiZB+FvZiD+Y2zkU3puyCqzFKuUIV+lCJ1/E+HvKxf4bjFxbLOmW8eDGU3LYxr1zYWcOuYHvXQb4RacE0fjIyxYGBL7r8PxchN1jkxwZOnAe/T2kUT8FqAK6emz9RHGFzNqPoiftoPeThPbRg+KWuSc+dWdbcrpN/XyJQ2r30Wmvpmo7gn7LF4LJuh0IYlKxtIEcd7bZxQWDrVHqw9QNAHkbf8R3Y3jTONb74nJfIBFFxzBfjXpwD94x6CAjvMH3EwMYUlvGlu2D1lZ8TA9m7ZIAWCuYvu83ZFe 9KRleXR8 HOWaIE5wjn6LO1T2IpH7g8Cdj8tqKyOcu8nQn6geU9MqbGdJ2z2FDZDY2Eobe1e07fEYit4ij78IlRpCPZdcLaLK1lOMYBhBjJwFIlrh/t42uxYVTfRgkqYo/jJvaZdzNFisjjuygiDRVw2QBIVRp4YCsgtWqS0VxHkuwGTmnn4V4rJeXBz2qOEJ1f1v7F2N+hacg5qTsDEydHSXomX2QHiJjY4ErD/M/ME0aO4trR3YhCDBcj2tV9KTIMzz3z9z85jmHHsj02qH+sG3bqiZr0iZyFO7/Z54uHXtomdO7bcT4GxYiY9A/+/C1KpTv5LsFgRMAS16uIj+qW6bV1tpyHqCdosB6iLlZL9vwuGwr8i1SiFfyg7pyVAEkGpf2+DhaBFY9cmK/zF2T7A5xMH5l2UQnbFd9af5ezjPUxyLhbeM6jvlMoQdaMA7NLzS9jrWupVCUi+Gr8l1f+FMxmdW2jVIViuPTZKv+Unl5lGAafVUB8Dmulh5WmsugjPj3SWZNrEHA1x4zmxOq2VAX43HkK25rjNpyKSLaPqzk0FmqlmTdpoM+XaBiw3wKjAPuJiVMvr1oLWxTSlob0fqPD4mSw/veDtyR6VdcgaZe08zpYr0XI1QM1i8P4tpzHKrPin6YXVxiIqBo/YTJG9ipcdyNtQ8iZvrZSouBX0qYeNbqSiV0+FI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 18, 2023, Binbin Wu wrote: > > > On 9/14/2023 9:55 AM, Sean Christopherson wrote: > > From: Chao Peng > [...] > > +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES > > +/* > > + * Returns true if _all_ gfns in the range [@start, @end) have attributes > > + * matching @attrs. > > + */ > > +bool kvm_range_has_memory_attributes(struct kvm *kvm, gfn_t start, gfn_t end, > > + unsigned long attrs) > > +{ > > + XA_STATE(xas, &kvm->mem_attr_array, start); > > + unsigned long index; > > + bool has_attrs; > > + void *entry; > > + > > + rcu_read_lock(); > > + > > + if (!attrs) { > > + has_attrs = !xas_find(&xas, end); > IIUIC, xas_find() is inclusive for "end", so here should be "end - 1" ? Yes, that does appear to be the case. Inclusive vs. exclusive on gfn ranges has is the bane of my existence.