From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 702C6E9370E for ; Thu, 5 Oct 2023 13:38:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00A696B02B3; Thu, 5 Oct 2023 09:38:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFC8E6B02B8; Thu, 5 Oct 2023 09:38:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC51D6B02BC; Thu, 5 Oct 2023 09:38:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CDC0B6B02B3 for ; Thu, 5 Oct 2023 09:38:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8CFFA8011C for ; Thu, 5 Oct 2023 13:38:46 +0000 (UTC) X-FDA: 81311513052.02.979E687 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf20.hostedemail.com (Postfix) with ESMTP id 998B71C0032 for ; Thu, 5 Oct 2023 13:38:44 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=breno.debian@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696513124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Typac5B7OWpGgMVQT5CpmSBuv29OUVSxeeOBcTx4oyI=; b=MIwAITChu2wUove077ZFXZ66wemZdGfabgtwFjerGr4jUTFtPS3xxirH41zUVrp/uAM/XB kLkwxoRNkk4h8a1bZw73UPixfZ0GVIG9WMOVL1sEjNGxNdAMjVXuopOpb518iMPTXojUtT 1dxdEPb+/iEeJMqVsC1i4wzk/Pa5MPE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696513124; a=rsa-sha256; cv=none; b=foTDGOaGDV57zRbO90W45PwO1aXZtwOqDGiQIqFI11dVMBzpfu5Lt5aACQqxLiu3aNaRKA q064DCfDa5g0krLCyltpXRiw7tA+Wy3ZszFYHDdfKHP8Z7mSmTCPS1/4bIxnu1XR33kSeR YoTpixbjQ27Fknkwx0JO6NwgHUSB710= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=breno.debian@gmail.com; dmarc=none Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-9b64b98656bso180272366b.0 for ; Thu, 05 Oct 2023 06:38:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696513123; x=1697117923; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Typac5B7OWpGgMVQT5CpmSBuv29OUVSxeeOBcTx4oyI=; b=Y+ifE1CrF9MyYxKUhZNBnEMtojEWTMdSwOPihPeaM7ZA3vA23y4Iez29OWljEQfo+K r8yDqlRDCU9ERQXKOncwYuUnC5nu/6kewbTUQcf4a1oAMTZYs4OZeI7gt+QW59bOwxJ3 crjqht3TpqPgxlpm7n7B/N8orTjrJLt+SJ8wlnzi50uXLINRiR9OXoYdSVEuCI6F7+tm vhLW40bw5BgBGAHi8ScHfG5tzP0uxr/Cj238sZxljQlBbrBpHYdXgkAaGg5OMhZtgTmm NChSobCCO/aFUB3LGqgkJN7V5LzrcepOYXtZi+wKHkzTf6KoBvIvIU4rzaQijGgMoBwA /WSw== X-Gm-Message-State: AOJu0Yz3EDS8uMwRNNJYtymmG6Vhkw3r8oHVHsi3t9kwnDQ0nqmUcKqi 3n+lAw/8zBs0kLy2AoOhvGQ= X-Google-Smtp-Source: AGHT+IFDc8GOq/vFfcLWVdGllmnI1Bgm7f2sRPgc5/yJuIMcEh102ROZ7TT4kAIBKHdm8jzKkU79tw== X-Received: by 2002:a17:906:3012:b0:9a2:225a:8d01 with SMTP id 18-20020a170906301200b009a2225a8d01mr4581177ejz.7.1696513122856; Thu, 05 Oct 2023 06:38:42 -0700 (PDT) Received: from gmail.com (fwdproxy-cln-120.fbsv.net. [2a03:2880:31ff:78::face:b00c]) by smtp.gmail.com with ESMTPSA id kb4-20020a1709070f8400b009adc81bb544sm1210966ejc.106.2023.10.05.06.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 06:38:42 -0700 (PDT) Date: Thu, 5 Oct 2023 06:38:40 -0700 From: Breno Leitao To: Rik van Riel Cc: mike.kravetz@oracle.com, muchun.song@linux.dev, akpm@linux-foundation.org, Shuah Khan , linux-mm@kvack.org, open list , "open list:KERNEL SELFTEST FRAMEWORK" Subject: Re: [PATCH 2/2] selftests/mm: Add a new test for madv and hugetlb Message-ID: References: <20231004171127.106056-1-leitao@debian.org> <20231004171127.106056-2-leitao@debian.org> <026a75f627bc7ffa45ead3fd6ecb9da7b5bc2692.camel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <026a75f627bc7ffa45ead3fd6ecb9da7b5bc2692.camel@surriel.com> X-Rspamd-Queue-Id: 998B71C0032 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: gip3ecs8y59yfr1h315rywrkg1dcjt9x X-HE-Tag: 1696513124-342742 X-HE-Meta: U2FsdGVkX1+/6KZ+wCq1fwRyL/wC/v4EXa9JeejNrT1buIQpPbu1P13sN94Hdxh0j+UcSx+JciUkBQSsFubrW0YMlEq4wHFrZajeNTyYXSnMwdrCypBGi195jCUOM6ccHjjdTKuVQGSljX+jqhTIrsK+4v0f3eDkddoVvDKzwXiAOLysXjbdg4QBue2NQvZJvyPL2j9abCXDOBbM0JAzJHcxQEBfnFFdCTIxpCXne0KxZENg5E7ogUDLz6GpcWBJH+LrfSkb3QkYBj9jpDI2M8AO1f3LIa18nyc8u2xAeyz6gPikJVz/NarNJQN5/lCafc4HL4h311ZAOcMAkI2WYi9hgqLF1otgjK3vlV9Y6LA7UgvvM8ybeOzJfPaCU7QwHopDuQaxbubfjqhj+gcIxukhKW3MX6X//YMNKjP/+S/4S5zEp9y6tQHaMRmww4zHBPmjkw8AOOCKNsebYh7Ee0QQI+TqANohvjED/LJVWltqA0nFn2dHtYcEax9CGWu8L+5Pf2mD0MgAiEDM5TCU6W/BKDclwH8fyJqJY6k1vOBaL4gSjOhPvnzuBTl9fbygZtMxbwD5fIq0v3fBrjb8/aYlX2tdEOwSbQKYTdg6AQSpoCDG04b3yAHuB9k/rxpK5j1nBpFXalUJzN6wWJ6rs7NUHjNzqQpDOj4EAgMCVDjmjSoNX3xEkWmmKRXUKoJSol5kvnC+SHnfIa0yS0mfek41Yz2v0H5SSHSOEOyfUkZ7Vtf8HwnddFprdCRDxUeOi3g5jVHhIVge+ZjQGSMFMJUhN6Sp1I3orQIFdIsxVkS8MnMfQ+10q3QJizlJWhvCtiFLJjFUbIVZ4BLrUHc0JLdSei1Q32Lo2t9jBYTgQCpNaxdnjm2kGYTWWhc48tmte8zYOFdILOMyny/CP/AzXf7TfhHx7rLLyOf2NzPefc1mT5VP3Q16f+Fo4dwYcrWMtGh3eZSP2qD43cMGUaB zeM9I4nl 7UFAtWi4GStKviPRDU/vP70uyaTeMGfObwa6q/moPBhLB0JH8DDNGW+Pp2+iPc57wrp/wjGmVCuFOaTNi55QckIutoLu9cor5GwFB+P+53IKpeeqZRjlfuqAh+ZRbhevJ5gZVYbOT1yQC/kfHrsyOi7I/zkMebjx1GASDEdsiGxZxh9ZyHqFxk6AKqmDZe6k0iZ5C7CWAtsBOXi78f0Ts9n3Kz5dHc9GkHCUV6ocDNNFrOmeJB0z2J4HzepUszhJWEtsUMlU7s+xt8N0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 04, 2023 at 08:22:08PM -0400, Rik van Riel wrote: > On Wed, 2023-10-04 at 10:11 -0700, Breno Leitao wrote: > > > > +char *huge_ptr; > > + > > +/* Touch the memory while it is being madvised() */ > > +void *touch(void *unused) > > +{ > > +       char *ptr = (char *)huge_ptr; > > + > > +       if (!ptr) { > > +               fprintf(stderr, "Failed to allocate memory\n"); > > +               perror(""); > > +       } > > I'm not sure this error message makes a lot of sense > away from where the huge page gets allocated. Right. I think I don't need this whole "if" clause at all. Let me remove it. > > > > +       while (max--) { > > +               huge_ptr = mmap(NULL, MMAP_SIZE, PROT_READ | > > PROT_WRITE, > > +                               MAP_PRIVATE | MAP_ANONYMOUS | > > MAP_HUGETLB, -1, 0); > > + > > +               if ((unsigned long)huge_ptr == -1) { > > +                       perror("Failed to allocate\n"); > > +                       continue; > > +               } > > Should the test case just exit with an error here, when > the allocation fails? Yes, probably skip the test if we are not able to allocate the memory. I just found I can use something as `ksft_exit_skip()` for this purpose. Thanks for the great feedbacks!