From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4755CE7A95 for ; Mon, 25 Sep 2023 13:40:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 412A68D002A; Mon, 25 Sep 2023 09:40:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C2AB8D0001; Mon, 25 Sep 2023 09:40:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28AA98D002A; Mon, 25 Sep 2023 09:40:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1A6D58D0001 for ; Mon, 25 Sep 2023 09:40:40 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A1104A0CB7 for ; Mon, 25 Sep 2023 13:40:39 +0000 (UTC) X-FDA: 81275229798.07.5952729 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf29.hostedemail.com (Postfix) with ESMTP id A3508120025 for ; Mon, 25 Sep 2023 13:40:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ceqJQ4+q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695649237; a=rsa-sha256; cv=none; b=cZ6AcipAcnD/ZdTQP1Vb2Jb0AGTEuUEMfy5HN17B753P3yyUQmNZsSvpH0kBhNOj0Gvhuc z8FyydfJ35rZVSEi/yMwqgQCCQjxCJcpqqpElaI3W+hfb8Hh0ZHXWmlwR4/eAclmXKdGZ1 K/4KVtsiaj5suyeI1i4ajIizB84gObQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ceqJQ4+q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695649237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SXMtMQGx0MCt04r5Sd/3UUcKCPsweBk7mPT2jQ/UDOQ=; b=eFqxXLQ9yqENvWzuGaiL2KcrXg3Xk3GiW7QuE06z4GCdSGidaOp3wAMIOSJTGs8ALwHtDF BbTelCMejFMxYVs5UoF7eXhDAytaVn01efL+EF2em9cpqXlI0txuSR52zf6Q6KJK7UwV6k BZEm1AoVFzvIRKd2RC7THSiRUGO+u14= Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5046bf37ec1so584277e87.1 for ; Mon, 25 Sep 2023 06:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695649236; x=1696254036; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=SXMtMQGx0MCt04r5Sd/3UUcKCPsweBk7mPT2jQ/UDOQ=; b=ceqJQ4+qeiUBdV8paCbKXcTeu/1G9oGhboXfXYXjiY9Nr2mDM/xIuYQ7gGGgqZamiP U4258mjuuxQCBf1ElUb2GX4Ys6Zb/RpB2zc4nPhqveB/xrtY+oixftLy9v9Tii0ROBwu nefBRl7Ome3X/eIn7d8Ff+o1qfwmc4L6ukeO7doiCnSlvvVsAQ4NdjO/CmHcBmpDpmDv 0Hhvziv/fQ9lLeyo2qnzt9ZiOVWr8kSaHDeS3EYbTONWi4LtBxw23sfs4UmJ/F0wZaNh MTzQAPwjNfe+paJAii6nKtmIHXQ7hZhMua/CstB9pXwD/VZRG38ZtZlwR27hMOg/SHd2 V1fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695649236; x=1696254036; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SXMtMQGx0MCt04r5Sd/3UUcKCPsweBk7mPT2jQ/UDOQ=; b=em+YbuK1+q8ci76vyDhPToW5BZCRSkg214YQw2g6Hx5g6AZEmnTalsa+03gF7LkBAM bs+cvkreD8jD14Oa2kp5hxGTbEVyPP7sCxtVt+SN1OBDO+DfpKAzu6MJvXPcLw8qKPUH 24ru8XUCDd4prfR5Qua1iyR3B5DYRI5HqJcbv6JxTtBH4QKDRUgRGY626Pua8qMFJAb+ 1hvajipzRWwsKp6JseoijTpsQKtL0Qi/INDqgCTwVsKnGnkkUXA6K5YjGQdtW9yriKpG /ARcOgzwgUq/v1g3/bIHh5/ORS3kQItn2rpnphOZ+6F1UCj1tYtTMc07+euduhuT6Hk5 pvYA== X-Gm-Message-State: AOJu0YyuehDaXk3dKtsKTUQDfNfmHkacXAAJFAxGDiMOGIPFxP/PZCw6 pbvCrfqH10ckit58ud7EP8I= X-Google-Smtp-Source: AGHT+IFZGbkKaGFj3/yK0zzVfUaoYfMUYUoloRwV9JiVsdv4BLxs61sGyfJIbzuQRMCr+rbWChnEqA== X-Received: by 2002:ac2:5988:0:b0:503:436:6d08 with SMTP id w8-20020ac25988000000b0050304366d08mr4988188lfn.16.1695649235486; Mon, 25 Sep 2023 06:40:35 -0700 (PDT) Received: from pc636 (host-90-233-214-51.mobileonline.telia.com. [90.233.214.51]) by smtp.gmail.com with ESMTPSA id w7-20020a05651204c700b004fe4e89dc41sm1847770lfq.214.2023.09.25.06.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 06:40:35 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 25 Sep 2023 15:40:32 +0200 To: Jaeseon Sim Cc: "bhe@redhat.com" , "urezki@gmail.com" , "akpm@linux-foundation.org" , "hch@infradead.org" , "lstoakes@gmail.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Jaewon Kim Subject: Re: [PATCH] mm/vmalloc: Remove WARN_ON_ONCE related to adjust_va_to_fit_type Message-ID: References: <20230922062704epcms1p1722f24d4489a0435b339ce21db754ded@epcms1p1> <20230925105154epcms1p782c335c2355f39a9b583489c56e972f6@epcms1p7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230925105154epcms1p782c335c2355f39a9b583489c56e972f6@epcms1p7> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A3508120025 X-Stat-Signature: 6pwpoy4k9bqqb7fnsdatypfcoqbm4bqn X-HE-Tag: 1695649237-385864 X-HE-Meta: U2FsdGVkX1/D7ODqusrnWPjlf4tj3feJ2NM6S0uW+6TnLOxUCkhQiLIslRlWKeWvQaqqUnnC5ZZGpcIAwrYl8mNeHlVVNJYEjiUajVm7HuZ99S/jmmOU2Wg11Uk1pcwxO68+rTLHP4JLVV9JFqK3j2wPxN9mvLK0g+ML+XZDfJsRfRh5YtCQ2VNTDoh+7fanJ7FqkbRX953FpoOOyefIxjycPNcUnjJn+Fy9LBZzL9ts+8KSDVu4eoowKIVIcKGHj5k4sR7zUcGKmVw9fln7R5nIQGFTDw/2bGevZ0Pywg5yW7Yw2Eonl759cec13prY9jRkIgwjrm0tx8KblWNoaHanAD96PzexQV1nAgrqoCSphhmo+6uADP1NkcgiubvK7oPwym1017sj+pdtT57aB+8UOvPeoo3ZEUaylqFYFL6Gu/7VvsAvYa5Nl+Zk21TY05eBxt27sPWZYdNBb1rOlu2wh3qzJgr/rR42CpUEAVtkNAt8FH/r1MtxjbE2OCp0Yahl79JABee7L7jm8SNcjqn1tBCDvk63sngO9T5uroo2QRWgvgjXzCP5OL7bH4+f7OMM6WleR/R0uLME1hc5dkU3Hc44EouG3EDZmoYLMvL7JPEGhghl4XaoKL/iV93eKjmKgxw1QFb5lEh6pLf7kdbrlR/K/y4vi4W6t4fdClxxNeobT6+8KNU/QkFyUtDsepk7jAkO2+aEaOTvmPElTqcq3JKsF4jEkIIpiibjabiZsh828gt1AEgUjdqkVjYSYpIvdmndht9AgOjYGGx3GRcr+Rc0mahihQ4oDuc+MwhvY3DqE9VEeSQZ3LrCJyagU8iYjr8gKS3KLTjRfU8JbEz7c2Wg/Ul5vl9zm8HKeHqe+S3VlnKpeSxP9rJaQ+2P5Dtv6fInmKDaRUdpoCpY4eTnCxWrKMr0sD2kvNCttmgGXrljIOft9UpFUwjjcuYmKOJwT5oNAVuKlSb/SFh zB4xCV9f zapb1wzxAP4sDjhePRXzWxhdZspLLEMlNo1HZtdxGvTm11V+S3ZMUzjuOYBJvVqOkpPEJX25nHVfZ1eExOIZ3z/QtaCPZV6Hk/VuLj72HRK7bnFVZRnplGQvFkvj8Ll8uqvO7Dnd1RydxtbmN14z7dzih0yy0h6W3cCHyAdq1jEqpYyNdLAvxTLYr343AsAFnhlY3QL/bb/rPPbZOaNsdGMKFsimr9dHI9TqRt5A3SE/whK//8UdWmy2SNFbn2kx4Otu26dQlSqOHT1REhd5epiCdI77nJDmlovpcwj0Q7wwqhPHY/LjMVPGALnc3zT/rxSuUCzJ2h9EKe9dC6/qV8EcCFKqTPdYlbLyblEfcp9/qMgP6tLslJ0jZRHsseaC2ytzSoWYGX06PwJYjitw8FdcYD8rGp4JprjX9h9pzJiL6BojBgljvPZHrLvySRvwWlPeWfKGipQIldSzM0lQyjzObgdi+YiO6BF946gE7mpiYMObraqHmWMCJYlDyufT8Sa9pnKtlehyBPfRhIzrWuv/dCL1V7j0J7qWz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 25, 2023 at 07:51:54PM +0900, Jaeseon Sim wrote: > > On 09/22/23 at 05:34pm, Baoquan He wrote: > > > Hi Jaeseon, > Hello Baoquan, > > > > > > On 09/22/23 at 03:27pm, Jaeseon Sim wrote: > > > > There's panic issue as follows when do alloc_vmap_area: > > > > > > > > Kernel panic - not syncing: kernel: panic_on_warn set ... > > > > > > > > page allocation failure: order:0, mode:0x800(GFP_NOWAIT) > > > > Call Trace: > > > > warn_alloc+0xf4/0x190 > > > > __alloc_pages_slowpath+0xe0c/0xffc > > > > __alloc_pages+0x250/0x2d0 > > > > new_slab+0x17c/0x4e0 > > > > ___slab_alloc+0x4e4/0x8a8 > > > > __slab_alloc+0x34/0x6c > > > > kmem_cache_alloc+0x20c/0x2f0 > > > > adjust_va_to_fit_type > > > > __alloc_vmap_area > > > > alloc_vmap_area+0x298/0x7fc > > > > __get_vm_area_node+0x10c/0x1b4 > > > > __vmalloc_node_range+0x19c/0x7c0 > > To Uladzislau, > Sorry. The path is as below. > > Call trace: > alloc_vmap_area+0x298/0x7fc > __get_vm_area_node+0x10c/0x1b4 > __vmalloc_node_range+0x19c/0x7c0 > dup_task_struct+0x1b8/0x3b0 > copy_process+0x170/0xc40 > > > > > > > > > Commit 1b23ff80b399 ("mm/vmalloc: invoke classify_va_fit_type() in > > > > adjust_va_to_fit_type()") moved classify_va_fit_type() into > > > > adjust_va_to_fit_type() and used WARN_ON_ONCE() to handle return > > > > value of adjust_va_to_fit_type(), just as classify_va_fit_type() > > > > was handled. > > > > > > I don't get what you are fixing. In commit 1b23ff80b399, we have > > ~~ s/In/Before/, typo > > > "if (WARN_ON_ONCE(type == NOTHING_FIT))", it's the same as the current > > > code. You set panic_on_warn, it will panic in old code before commit > > > 1b23ff80b399. Isn't it an expected behaviour? > There is a call path which didn't panic in old code, but does on the current. > > static __always_inline int adjust_va_to_fit_type() > > } else if (type == NE_FIT_TYPE) { > lva = kmem_cache_alloc(vmap_area_cachep, GFP_NOWAIT); > if (!lva) > return -1; > > We do not have above code anymore: commit 82dd23e84be3ead53b6d584d836f51852d1096e6 Author: Uladzislau Rezki (Sony) Date: Thu Jul 11 20:58:57 2019 -0700 mm/vmalloc.c: preload a CPU with one object for split purpose Which kernel are you testing? Thanks! -- Uladzislau Rezki