From: Ingo Molnar <mingo@kernel.org>
To: Qi Zheng <zhengqi.arch@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Rapoport <rppt@kernel.org>,
David Hildenbrand <david@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, Andy Lutomirski <luto@kernel.org>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] x86/mm: Drop 4MB restriction on minimal NUMA node memory size
Date: Wed, 18 Oct 2023 14:44:52 +0200 [thread overview]
Message-ID: <ZS/TRNf02Un8IOTK@gmail.com> (raw)
In-Reply-To: <605cc166-e731-e7d1-25d7-b6797a802e6f@bytedance.com>
* Qi Zheng <zhengqi.arch@bytedance.com> wrote:
> > While I agree with dropping the limitation, and I agree that
> > 9391a3f9c7f1 should have provided more of a justification, I believe a
> > core MM fix is in order as well, for it to not crash. [ If it's fixed
> > upstream already, please reference the relevant commit ID. ]
>
> Agree. I posted a fixed patchset[1] before, maybe we can reconsider it.
> :)
>
> [1]. https://lore.kernel.org/lkml/20230215152412.13368-1-zhengqi.arch@bytedance.com/
>
> For memoryless node, this patchset skip it and fallback to other nodes
> when build its zonelists.
Mind resubmitting that to the MM folks, with the NULL dereference crash
mentioned prominently? Feel free to Cc: me.
Fixing hypothetical robustness problems is good, fixing specific crashes is
better. :-)
Thanks,
Ingo
next prev parent reply other threads:[~2023-10-18 12:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 6:22 [PATCH] x86/mm: drop 4MB restriction on minimal NUMA node size Mike Rapoport
2023-10-17 7:28 ` David Hildenbrand
2023-10-17 7:35 ` David Hildenbrand
2023-10-17 7:52 ` Mike Rapoport
2023-10-18 10:42 ` [PATCH v2] x86/mm: Drop 4MB restriction on minimal NUMA node memory size Ingo Molnar
2023-10-18 12:26 ` Qi Zheng
2023-10-18 12:44 ` Ingo Molnar [this message]
2023-10-18 13:20 ` Qi Zheng
2023-10-20 8:46 ` Ingo Molnar
2023-10-20 8:59 ` Ingo Molnar
2023-10-19 9:35 ` Mike Rapoport
2023-10-18 11:55 ` [PATCH] x86/mm: drop 4MB restriction on minimal NUMA node size Mario Casquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS/TRNf02Un8IOTK@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).