From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F35CDB482 for ; Wed, 18 Oct 2023 12:45:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2ECBB6B0141; Wed, 18 Oct 2023 08:45:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 268716B0144; Wed, 18 Oct 2023 08:45:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EFB96B0142; Wed, 18 Oct 2023 08:45:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F11766B013F for ; Wed, 18 Oct 2023 08:44:59 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BCF87C01E0 for ; Wed, 18 Oct 2023 12:44:59 +0000 (UTC) X-FDA: 81358551918.16.11F8798 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf18.hostedemail.com (Postfix) with ESMTP id D9EE91C000A for ; Wed, 18 Oct 2023 12:44:57 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UiIKzEuA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf18.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697633097; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tEU1LGbzWJlYQImQ/FQQEXA9hWg9U9vQlJ46IkPulMM=; b=KOA+WR8+0J8w65MrDV7NG59gj+t2nMBQ9u0swGZRTor12rGradeKhBKBwNEopnCipysMrm e5fk6YcaBYKYTucVR/w2PwsSR9sc/3stysGK13Kazg1zj3YAq4S8iz7rUfxK3/V9iGRFXL YC9SS3nBztWjGYIvMoaTmKzgj7AH5PM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UiIKzEuA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf18.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697633097; a=rsa-sha256; cv=none; b=uWd3G3Ek2KjomAU5Gd32miF+Jl8/3Dt2YPcm4GKQqKJUABIOuKGb66ahTqE2Of3nreslss JrN/zH1rQhJy1D+2yFwzSYI8tYbvrXkJHpN2J+5GFw4UpP4iKsqWdQbzp82SNmsEWHop3A IeBlNDzd7DSoWF63JDQqTroLqwLlWGI= Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-9ada2e6e75fso1170408666b.2 for ; Wed, 18 Oct 2023 05:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697633096; x=1698237896; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=tEU1LGbzWJlYQImQ/FQQEXA9hWg9U9vQlJ46IkPulMM=; b=UiIKzEuALOhu5SfTWknJkc7BijR73zgzZ5yihoIVz/VaCJLnS4t/pKfoNVQnFOROL6 +4APkPqMMzSwUJKTtrsd6OaLu8NGlfnyP34MafewEAuULxffUCHquvKsCcuH1SEGWO4H YYLvqvoZxKofhuaOdXykYTTKTGa7nWNJLh/JOTF4ELVHFRvdJJpl38+j4RB1mSXTbIjv 4YXOtkhDq9uF3bZrQzHhh8Vs+9DOcDFM8JKxBYs4BuYT266bHqGL944wH1xvD0gxL8/x nR7IjxRbOigDpFoehQcXYgtSEnvOXDMdSPoFumTfrWpa2M0F42BiGUhmxXg/YQSeg3EL wekg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697633096; x=1698237896; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tEU1LGbzWJlYQImQ/FQQEXA9hWg9U9vQlJ46IkPulMM=; b=py2FuuFkV/pLvGID9OeTR2dqmDc/gTDltEx2wFNKi0RdbPX/dGb7h+qVVR8FBZon02 DwKEFmo2rVTT0v6UA+dQDlwb0znk6mW65SYZLqsjeQj9lsOnRXYdujqBJg7hEKgl3SkT YDVVHkCYksI8FABEXyqJqc3yOVsCiWzioMa1scVM76tbIZxlpXHo/4dyOcna6hDJLftg 2wG9cC38bhJAq6HoAfGtCyOILxEJ9Dq5HipYv35N/8iywUfxRp0IxnUjHU+nlEP3XRIc FmPmkddSEPHSF4gCxqLf5Nbu4Y1Ff0gIDWoBMJ1m3eDuNcBrJyxzXpCPXn93h2G0W5uf oq4g== X-Gm-Message-State: AOJu0YzRt4V8FAG3Q2nbAWrq0eTANCO+h3X9zoXmqTjQciPV2NYCcHw0 l7ZkmuQs60LaJjsnQp4JzOg= X-Google-Smtp-Source: AGHT+IEAez9HT1UAqDAySoV5yAJbIFqzJMjfsVFtgpV1VYBAlh4y4QnjWE7xYuczgUxAGxcYlWcyFA== X-Received: by 2002:a17:907:36cd:b0:9be:fc31:8cd2 with SMTP id bj13-20020a17090736cd00b009befc318cd2mr4663212ejc.24.1697633095875; Wed, 18 Oct 2023 05:44:55 -0700 (PDT) Received: from gmail.com (1F2EF7B2.nat.pool.telekom.hu. [31.46.247.178]) by smtp.gmail.com with ESMTPSA id f4-20020a170906560400b009ad81554c1bsm1597719ejq.55.2023.10.18.05.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 05:44:55 -0700 (PDT) Date: Wed, 18 Oct 2023 14:44:52 +0200 From: Ingo Molnar To: Qi Zheng , Andrew Morton Cc: Mike Rapoport , David Hildenbrand , Michal Hocko , Andrew Morton , x86@kernel.org, Andy Lutomirski , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] x86/mm: Drop 4MB restriction on minimal NUMA node memory size Message-ID: References: <20231017062215.171670-1-rppt@kernel.org> <605cc166-e731-e7d1-25d7-b6797a802e6f@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <605cc166-e731-e7d1-25d7-b6797a802e6f@bytedance.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D9EE91C000A X-Stat-Signature: ud9cgnqnn998tmhrjcieqsxseb5975qx X-HE-Tag: 1697633097-815060 X-HE-Meta: U2FsdGVkX1906NgG9b+Ger8qfNRUewOo4S+/YcG/4nfwMMCK1OgbqUeUHWmLTdQwSfRr8x/1awgnmfhvJmijrQtbLfrh0xxCiz/BdvwzA/oeRcJWpFSR5NutFfPgVpmGzfz9/QIy8uT0ap6l597dggHuDpdc7cqMSKDuR5bdQlEWMlqPafs7eLhpQ0/5IUX+NR7aTr6VjZVUbbslpJVWLMo8UBMItuzpwtDRJI7ProKGzqk+odJtxfmC/loTuow1YHJA7CeD3vBSmK7Dpy3hzxfcXhFgPUMJwTKp3g2PwUuKnXW/wIKooc3mdN1xqQHCZK7ORzLOZ0FfPPx2tMhr43b2G21oVVQhk91CQfrZNnFmyZUtMUU/lH7SwtIkO/0EmylkISm1z/9QKcHCmlUhDYfLK4Jv0x32tv1gAKDCM4VKRN3BsfhjJUE5hFj5R4esgQZbiH5C3Ce/zKV5zlQx+SosBfqz7gvApvxcSFQg9PZZxghwOlRZochaevJ0ipfFdinSw5e2158/P76S0wTScRqZDjyS8kVgMcfUwWWtO//0bssf+wxI6klJd2sOPnUnEGFLYX5BMWXKsL7+FUGHawSAh42Zqx2xIowPHXZwLjzBYE1ZA5eODtpKsgqR2S8I18T+LvpM0jIetOkOrnQpRWhRDunfiDOTZMHtrGOekr8joyeJ4hrhMvAu9tILL6OAScQE1nKT6/oRJ/p4+48SgIW+MCgHg+mS9aLg+2X6nuOz5q+CVetQOnYH68mktL4vztZq1Y5AdCZ1F3G/bLWCYXNTJrbmwZAzBS5hvSNxLdjRQDUgNNDJAIqUito22YtWDlVbh42RnlSuGxHSRcPfAoLRlYMGAP+fgLM2lbcpXfISiM9fD7brzTkbo9N6r7qWlJZAB7zMjlw3O73A4KRbwX1MYToYmjPMdQaXTiyI1EEhLGQcxNp9I0b8sRty8/ydykMpa3DvpD1pzb32df8 ZB8FxFIt qCQYLZS31lCtJWq1+ffcokJ7uq+xDV6Pfnm3hJc0BI+nY/gZLvid1BRYBZWxkrJnfPdeXLDRFjof/9WZwayu8VQtzjwAzxliTYoYWm78w+S0gnj8OCgqGP8jVIc0EzWZzC1FTF9dck0sQxbLwE33GcPcGN79Z/jFhzruGdVMX1suYH9YysbGwEeYq5dU8Y43FKRCTJ1Fu31Q9weyTEjErQ84Clag9HCTdhryq/w08ccKDDcba6H6IhwbIQC0OkoKsXA3K96DOw3fcJdSMiC2s7/aQeJzxhCruJQL/I3IvVih4GWZFDeLSAT0ZbVf2WfFgHIhkKdDtnHKM4U4O6hAWwHuyA6Qb4KocgPiSRFAbUFKrcOgc0DebsezrHJDY34XGQDlJGS04yx5s33+At9VclBWgQlJqixJNwxcbL5f4hfY+uSItf0rDZspoQVs1It36tX2QG+3CrJ8EyvVIXsDCVFO5/ldMQhXruoX8SC8JZpKbdXbq3xHWdMaqIWvi+37MtWB+bo1+k6UbZw9ixyTdu+qwiIYAISJ2bjBOTAjCAfL4gZD4Vggci59Ti7O7EefQUwnGC66nF3ywdAGuNKZxlU4lsUDjAFLx/FmFQ9DSemkvq3zjO9eWUI8mtx5DvnIdneU4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Qi Zheng wrote: > > While I agree with dropping the limitation, and I agree that > > 9391a3f9c7f1 should have provided more of a justification, I believe a > > core MM fix is in order as well, for it to not crash. [ If it's fixed > > upstream already, please reference the relevant commit ID. ] > > Agree. I posted a fixed patchset[1] before, maybe we can reconsider it. > :) > > [1]. https://lore.kernel.org/lkml/20230215152412.13368-1-zhengqi.arch@bytedance.com/ > > For memoryless node, this patchset skip it and fallback to other nodes > when build its zonelists. Mind resubmitting that to the MM folks, with the NULL dereference crash mentioned prominently? Feel free to Cc: me. Fixing hypothetical robustness problems is good, fixing specific crashes is better. :-) Thanks, Ingo