From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3482CDB47E for ; Wed, 18 Oct 2023 08:44:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33A298D0148; Wed, 18 Oct 2023 04:44:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EB088D0016; Wed, 18 Oct 2023 04:44:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B26F8D0148; Wed, 18 Oct 2023 04:44:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0C3548D0016 for ; Wed, 18 Oct 2023 04:44:58 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D242DC0196 for ; Wed, 18 Oct 2023 08:44:57 +0000 (UTC) X-FDA: 81357947034.14.30128AB Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf21.hostedemail.com (Postfix) with ESMTP id E89AC1C001C for ; Wed, 18 Oct 2023 08:44:55 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Evz+CnWn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf21.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697618696; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wSgTjdOEv9o43R13g98wkLpNBZhKvWTIsoJaIcBH5Qg=; b=hGxHfEuZT1FS+ylasB7F4E7FrxNwhsTkLnwm9PkD0GoJWi5zBKjEPeuFxzUdqfaAHSMDpv ZwPumiJtLWuPJFIRdFH6fPwTeasVGd3dcWZva/rnHF8RJIevuJyLEbneh+J4fybDxQTfwo qTUiW4EqVdU3AKvvL3Nml0l0nzuDD0o= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Evz+CnWn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf21.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697618696; a=rsa-sha256; cv=none; b=1rYJ9iZYQPAc3Nu2iHAmy7+vylXSnQ6I5R0+m/5hxzeBVI5b8HaTEqDLxGUIJJgrF+MEwQ dszku5TuFY5L7PH64eDJCHGVIGEe4IPTKm+AmNaxY7QP2WV3JldJcHbS84HQGLvpM8yqDK ejsBvpWPdeZPzSl70E898Kxz8+xFIXA= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-9c5b313b3ffso293353166b.0 for ; Wed, 18 Oct 2023 01:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697618694; x=1698223494; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=wSgTjdOEv9o43R13g98wkLpNBZhKvWTIsoJaIcBH5Qg=; b=Evz+CnWnhjH0T1Uxnd5Ju4EyE0OO9Ip0KzBBIC3dol81DQIcLpVePwn3rmv4IuKBDK 8PDxyM7Du+2RHAZ3SAu0ZHcRxU9EFCW0XLSJi6j09mvI19cg4FgSNW8b5Pl8tMZCbRTP tsIxOuEberqMJDmBYyD0i86aLHjcy959dPWRFbjd4MX7SsvILWYc5ljkSzxN1PY9kOZn jc1Kz47kyRaWQJl5z9+4MpM4iQNyK2qwwyW5BNDYl9NXkGRDgWgYx2Bm/Fvm+k/WJPSp mO45cMynplR9+mYpDv3QqJtnv4/BoJfjlnpCe38P0dMJI5E4y6PCXyfuQZKjk8hRrSRp U7Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697618694; x=1698223494; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wSgTjdOEv9o43R13g98wkLpNBZhKvWTIsoJaIcBH5Qg=; b=ez1Lty53MJh1SOCg5GLIQCjHark30oKXUbFPf8MIu1X7+qCMonrzwDR15+o6Qf85rN ShsCP/AAbZGRCik6BBvpU9+5flVr5pDRAcTvjhUxXin0yW/93DMCdge48bA87ftbPpZF uBOan12E+yjWNq9fgP0m2dDzeCEfTERJfBX4F9ny42LQZiJs5hTrBmxqcivwAiaEtRqe Hv48jW6XmWjDepfLUjASoGJQLd311oquXZZ6sZuz0trR4EH5RKi+PJuTb/fpQnvnL9TQ YucfcCADgAD7jdMJuHGYMCWDcVa15X8yaIY45JGTuGDoU8ncZL9vLTswU7z0mO7gkOGb /DkA== X-Gm-Message-State: AOJu0Yw2J+1QwfQ8p4zeBWEg4RHKTz03JfR28ZhhNuj5uPpn0aaaWLM5 ZnqUhKXC+MXmXHordnuA6gg= X-Google-Smtp-Source: AGHT+IHJtepEuoueIQMXTSwDOKujhTHfpU5bGtfZ1JuGIz+mNfQtsgcwCoVq7SqybQGWRk3sN1hh+g== X-Received: by 2002:a17:907:7d9e:b0:9be:8ead:54c7 with SMTP id oz30-20020a1709077d9e00b009be8ead54c7mr3542268ejc.12.1697618694114; Wed, 18 Oct 2023 01:44:54 -0700 (PDT) Received: from gmail.com (1F2EF7B2.nat.pool.telekom.hu. [31.46.247.178]) by smtp.gmail.com with ESMTPSA id a7-20020a170906468700b009b957d5237asm1199002ejr.80.2023.10.18.01.44.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 01:44:53 -0700 (PDT) Date: Wed, 18 Oct 2023 10:44:51 +0200 From: Ingo Molnar To: Rick Edgecombe Cc: x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, luto@kernel.org, peterz@infradead.org, kirill.shutemov@linux.intel.com, elena.reshetova@intel.com, isaku.yamahata@intel.com, seanjc@google.com, Michael Kelley , thomas.lendacky@amd.com, decui@microsoft.com, sathyanarayanan.kuppuswamy@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 02/10] x86/mm/cpa: Reject incorrect encryption change requests Message-ID: References: <20231017202505.340906-1-rick.p.edgecombe@intel.com> <20231017202505.340906-3-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231017202505.340906-3-rick.p.edgecombe@intel.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E89AC1C001C X-Stat-Signature: r53f94r1917mu1smzwzpjxo4swign3eb X-Rspam-User: X-HE-Tag: 1697618695-101401 X-HE-Meta: U2FsdGVkX1/XcP64uCfgX6cRQS+vN+xrSHMSv8M3lYWCQNZr97Pa+vcnM/uFM4XIc4VL/wSJz8zJRJpsrWwH41XXzRODvyjuHMjb66WM4mqJeK/pcnobNUp4U2OkyLO7FGkqb0VvZRR3JFzKFDyyO8eETFQFPuqnN/uINEYZlecoA8ycz2yfVCkTKTiSlg6BMi1PXyS0dbUxxotQN9wJnXijnYG8QzNgfS8m2TTQTd5EwzZOz4EeA5XRlgv/cKJ6us/lDhxOe1UE/6WO6MCtcK8vPzaDxq2wh2Xnb1s5MCjcQ3OV+FvA9FYoO+p47QlDkIqAl+zmXH+i5tZG1WQOYvPoxVskpyqwOUUddhdUjtxTb3ntO2kBuNximECRIjGxZgKX+9rT3jyXjaWz2LziNxdMhCHE7LYXV1tqB/pduKKrgtOT8DZvnP+jqP+wGMRT/ErriWA9Ag4hJ9TNRBX5g3gDdp/52D5J2yc17VvAt6I3BxLqFUi4MViPg/SWqG7RkCrIszHlL+up7FLmiuLlj59kqXJuKN0nuPGTkrdApLNCA+YwWeS+5eNJSA3jSZc4nLrsWw8nTqJ5SilF92i0ugh0SSYeI75dHps8sBVFSIP/IaWhAePdPLamUEWA2hRV7KFoGq813HcYc/LlfKGkYBykozAQFNeyA+ElnFEVb+3pnxRVOa4J7VL21tLgk0vxEUIo3vCW7VPkxnMHS4jeQaVxpSS7CMbnZwRYWXT9pI0KMewMH6Glbw8T4CnPOf3hi88fmZWSyvxCkC0AIGO+ILWuy1qmjDULf+IDzKM34N81q/Fm528sSFvFRTAp3hvvTvPrv+A8WKji32gqFTqriEd2KxU7Tja+IipKv/UtkmqVM7xwOIL20bUV3kmz9KFDwgzaZVk09CFEPdA2WIPMxmrsmebs8Xo9jslmknN3iOtWdvmdlZgSCgYYZl7t1txxrmoltrNOjwnvFxrYhCG 0cpVay2X rMIHxwIOr0YZG5BfIQUOC+Km0zbBbWRyxGjA2nABXnjRjFM8cJONTFsKpPTL6mTS8Jlii8jBSC+0L0xcQeihBikQHQYth4mT5sA5sPP1B18Dm6rYhBKn4NbIHuCUbJ1ZXlykLBBENxrS/cfL9sBFLW8lflbG3ojOmsQFqgrokMznNHaalxTQHOXY4tyTfjjF0cJuKEmNs9Ad+4vu5h4m2zCXVj8PJ9Fqgwu/DGSz0dEN0BDbK+M9Kp6TjJfVlKXagyfFJYqz/kEPJOJ7j8MOeN/M7K42XJWUz3U4+wJSwYXUe54Xrt3kcYHirM1my0gxoaTxG03uzIgcWDCKYDbxUEfwbf6hIWIjaN+aQxQTjttrJB98C/1dt/MLZ1yxyfUxXgXi0SZpz2vH39aoooi4QVQCw/Y9qDmZsto6XTXv6ipCMEKv8RX9LSfbpH0ALDZlmBcceSpIIy5e4NPH6m04abTFmuQtpFzGbBxdaOXnrGQyJQcfh/ftwop0h8EMO/0+7olEPVbadTz475YNd/1NbJ199p90sye5Ttngz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Rick Edgecombe wrote: > Kernel memory is "encrypted" by default. Some callers may "decrypt" it > in order to share it with things outside the kernel like a device or an > untrusted VMM. > > There is nothing to stop set_memory_encrypted() from being passed memory > that is already "encrypted" (aka. "private" on TDX). In fact, some > callers do this because ... $REASONS. Unfortunately, part of the TDX > decrypted=>encrypted transition is truly one way*. It can't handle > being asked to encrypt an already encrypted page > > Allow __set_memory_enc_pgtable() to detect already-encrypted memory > before it hits the TDX code. > > * The one way part is "page acceptance" > > [commit log written by Dave Hansen] > Signed-off-by: Rick Edgecombe > --- > arch/x86/mm/pat/set_memory.c | 41 +++++++++++++++++++++++++++++++++++- > 1 file changed, 40 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c > index bda9f129835e..1238b0db3e33 100644 > --- a/arch/x86/mm/pat/set_memory.c > +++ b/arch/x86/mm/pat/set_memory.c > @@ -2122,6 +2122,21 @@ int set_memory_global(unsigned long addr, int numpages) > __pgprot(_PAGE_GLOBAL), 0); > } > > +static bool kernel_vaddr_encryped(unsigned long addr, bool enc) > +{ > + unsigned int level; > + pte_t *pte; > + > + pte = lookup_address(addr, &level); > + if (!pte) > + return false; > + > + if (enc) > + return pte_val(*pte) == cc_mkenc(pte_val(*pte)); > + > + return pte_val(*pte) == cc_mkdec(pte_val(*pte)); > +} > + > /* > * __set_memory_enc_pgtable() is used for the hypervisors that get > * informed about "encryption" status via page tables. > @@ -2130,7 +2145,7 @@ static int __set_memory_enc_pgtable(unsigned long addr, int numpages, bool enc) > { > pgprot_t empty = __pgprot(0); > struct cpa_data cpa; > - int ret; > + int ret, numpages_in_state = 0; > > /* Should not be working on unaligned addresses */ > if (WARN_ONCE(addr & ~PAGE_MASK, "misaligned address: %#lx\n", addr)) > @@ -2143,6 +2158,30 @@ static int __set_memory_enc_pgtable(unsigned long addr, int numpages, bool enc) > cpa.mask_clr = enc ? pgprot_decrypted(empty) : pgprot_encrypted(empty); > cpa.pgd = init_mm.pgd; > > + /* > + * If any page is already in the right state, bail with an error > + * because the code doesn't handled it. This is likely because Grammar mistake here. > + * something has gone wrong and isn't worth optimizing for. > + * > + * If all the memory pages are already in the desired state return > + * success. Missing comma. > + * > + * kernel_vaddr_encryped() does not synchronize against huge page > + * splits so take pgd_lock. A caller doing strange things could Missing comma. Thanks, Ingo