From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B1F8CDB465 for ; Mon, 16 Oct 2023 14:11:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 099DB8D00A2; Mon, 16 Oct 2023 10:11:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 022668D0001; Mon, 16 Oct 2023 10:11:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E050A8D00A2; Mon, 16 Oct 2023 10:11:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CDF208D0001 for ; Mon, 16 Oct 2023 10:11:11 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8C6B1A07C6 for ; Mon, 16 Oct 2023 14:11:11 +0000 (UTC) X-FDA: 81351511542.20.C54C8CD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 2463C140004 for ; Mon, 16 Oct 2023 14:11:07 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AdtBRvrY; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697465469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=czV84VhOyQlJV3boH+4QfGzVmblLtaU2dw7F3ceDF1A=; b=kvBsOaunO3n9DooPdE/g5mnT3pBH5vbCFZhdCouA1j+z7kbHjptgBUSo7ohy5DTPxrLQa2 WflQU16Thqwz1M1otQkEOJwoVIh5Uqwi9IdI1RSOSa31Ask2Wqhiub6op+cNCv7EgLUTQa iC2xcsARMbolR2jVFYv5RcvWVcc5ONo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AdtBRvrY; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697465469; a=rsa-sha256; cv=none; b=yx0Uli6H+9vVv4pbS3u0pIx9KpuCdo/CKA5manfxb2KYLowelM8PIroa6sGPzkv4nGOmka Hzl26pmtTxT/Ce3FEE4teAvhBuHFRzTODi4dFHeKyow2Zri4HS0sMqj21isRIkJwF8Qgku qzL8zna+WvMHuXFCydsMUGVrNR3qh1c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=czV84VhOyQlJV3boH+4QfGzVmblLtaU2dw7F3ceDF1A=; b=AdtBRvrY0I7rDxLM3v6Xhb14vK pgYuVcXg9Fc97jR6r0nofizvmWPF7ePoe3c518Uiix2HWu8YOKh9+jkLQaO/SLHahQf9hf1ZKSo4Z QuYvPyeMoXlz130uNdkiG9okgrwfKPybajkRTryFhfDHVlpw3dKqhXBxpDtY3dTajR640O/16fDG3 aLJonvWi/fNtdnYvbFHdHtt4UYGEZJtOJqsy8ySp5XydZXV4xycLu6wCZbsDaNolEcr1flKH9wbSB XuPeRhrD7TVuwT8XQo+8UEurGWyZSjnyj1siPNHt3Zd0d6YBjt1bPsDkY3leLRpkJ1zwGeAOmqiaZ mJdmezOQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qsOIT-006Str-8h; Mon, 16 Oct 2023 14:10:17 +0000 Date: Mon, 16 Oct 2023 15:10:17 +0100 From: Matthew Wilcox To: Peng Zhang Cc: Liam.Howlett@oracle.com, corbet@lwn.net, akpm@linux-foundation.org, brauner@kernel.org, surenb@google.com, michael.christie@oracle.com, mjguzik@gmail.com, mathieu.desnoyers@efficios.com, npiggin@gmail.com, peterz@infradead.org, oliver.sang@intel.com, mst@redhat.com, maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5 03/10] maple_tree: Introduce interfaces __mt_dup() and mtree_dup() Message-ID: References: <20231016032226.59199-1-zhangpeng.00@bytedance.com> <20231016032226.59199-4-zhangpeng.00@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231016032226.59199-4-zhangpeng.00@bytedance.com> X-Rspamd-Queue-Id: 2463C140004 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: iunzackubibgi9edgyeusehzd5tsgxf5 X-HE-Tag: 1697465467-840359 X-HE-Meta: U2FsdGVkX1+6/XtQNc08T/SK8v27nUKIssyoefrg8gS3iDHsHqKhe3vQCWDgb8ThzVMraDsh3WrQYB1Ezfb6VNUrp70G3XiSjR+5rtm1JHNNblod58bRKX9cWCHjoJzHuky1GDBD6hhkIQOVEyK6Ng5IAFDS9U/Vp8qUSfPs3K7DKNfS9+UU/0AfAxmC/kp8gKQ92Hr0z8y3d3JFul4KMcAEY6tzLC68f6K4hsyIZ0NkdcX/Cu0AWABoRrHJmqyZfSbXHYB0sjN6n9F7i0Zf77h5MmMjFZ46Jz4QuuigAXk2LLMB133d0V35DTKq0VbZQouqfuLDjgRdIATFNlJT9X/1Tu3144NkbI/egnv6WrTyu3TvmUoQdF6j1nK5GPJfBAxUXNa/4SrC1jkf+7PBxQPVnm5RSwaDSJajtSh1TDp0ISYhRCRt2ZpH8/ZKw3Tssykw2EMBLwOpP4YCZk13SxL7L7+Y50ZEEvqqttsaz9J19WWJzXmT10o/gMfcsSzOIu1cDhMXTybLytHJOw/n8v0rOxVctbCpdqc1UGECAknIa7j55aTaI1BpR5SVsFyUenF+w178gTjeYhihwYF+37SA9dAlr03exegE74fc5umUiLV2HqOwhu2k45rNKm5Mm9uaSrG0HHwn2CZoatDS50PvdhN/slrGHTWPg2LyFZNUs1nd8nv4Flk7kAjiSGcRBPsdZox+Qg16hSePuq3tt7CuPbXmqH0RMkaYhRpD+Z0x3SrC0PymG/VFybVZfuq3BJdogxxSJh1V/FoXtYfDLVihmf8TDU65ig1ZQiuzVSArIKbghQps+yJoJgOavJI9KkZ8Y19oQn4c+aQmd+WuSION7L3FFjLIw6yepixYDASuXmuVo6ZewaZ05Fz0Y5MFBtTYqnuR2VhmSy69YC1Xhe7yHyRaTlJQ7lIataC4PCdlwlgEwU6o3FRj2rzKmfu+qDJ+WQ3kS8ezoUhZjWV 0F460MZd 1elM0Ee6IMKs0oy1BsWhCBSFvTq43vIQa9Pet/uejJp+lmj9iqIDwy4DsKiB4wpuu4Ww6FjcyWVuwnYu/MXZruvv1a15NScINrgFgNcgjeLuZaQAq7BBmVOmMSobIVnpJbw1QL9Qor4dVG1xT+PZTX+MPqIFRPQVJBs3vWQISYmVb+Gz+kXwNqA46Or9C16e+o6rZJ/31TbU/FXO46+NehfRFTcYsokHjWrc/KWWX8AsQfAHx+RzRzom+yqRqz1eImRi3mCVgTMoy38uJQ8QW0AU7a8Or0ZiItMFVSpLAKDKzwOzgdpcqaJLHl6WKdweciWT1UsW3uf7/fOU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 16, 2023 at 11:22:19AM +0800, Peng Zhang wrote: > +++ b/lib/maple_tree.c > @@ -4,6 +4,10 @@ > * Copyright (c) 2018-2022 Oracle Corporation > * Authors: Liam R. Howlett > * Matthew Wilcox > + * > + * Algorithm for duplicating Maple Tree > + * Copyright (c) 2023 ByteDance > + * Author: Peng Zhang You can't copyright an algorithm. You can copyright the _implementation_ of an algorithm. You have a significant chunk of code in this file, so adding your copyright is reasonable (although not legally required, AIUI). Just leave out this line: + * Algorithm for duplicating Maple Tree > +/** > + * __mt_dup(): Duplicate an entire maple tree > + * @mt: The source maple tree > + * @new: The new maple tree > + * @gfp: The GFP_FLAGS to use for allocations > + * > + * This function duplicates a maple tree in Depth-First Search (DFS) pre-order > + * traversal. It uses memcopy() to copy nodes in the source tree and allocate memcpy()? > +int __mt_dup(struct maple_tree *mt, struct maple_tree *new, gfp_t gfp) > +{ > + int ret = 0; > + MA_STATE(mas, mt, 0, 0); > + MA_STATE(new_mas, new, 0, 0); > + > + mas_dup_build(&mas, &new_mas, gfp); > + > + if (unlikely(mas_is_err(&mas))) { > + ret = xa_err(mas.node); > + if (ret == -ENOMEM) > + mas_dup_free(&new_mas); > + } > + > + return ret; > +} > +EXPORT_SYMBOL(__mt_dup); Why does it need to be exported?