From: Matthew Wilcox <willy@infradead.org>
To: Kairui Song <kasong@tencent.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
"Huang, Ying" <ying.huang@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/swap: avoid a xa load for swapout path
Date: Tue, 17 Oct 2023 04:00:15 +0100 [thread overview]
Message-ID: <ZS34v5PGWhCdmBjI@casper.infradead.org> (raw)
In-Reply-To: <20231017011728.37508-1-ryncsn@gmail.com>
On Tue, Oct 17, 2023 at 09:17:28AM +0800, Kairui Song wrote:
> From: Kairui Song <kasong@tencent.com>
>
> A variable is never used for swapout path (shadowp is NULL) and compiler
> is unable to optimize out the unneeded load since it's a function call.
>
> Signed-off-by: Kairui Song <kasong@tencent.com>
Reviewed-by: Matthew Wilcox (Oracle)
Possibly worth adding a reference to
3852f6768ede ("mm/swapcache: support to handle the shadow entries")
Not sure it's worth a Fixes:, but that's where it was introduced.
prev parent reply other threads:[~2023-10-17 3:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 1:17 [PATCH] mm/swap: avoid a xa load for swapout path Kairui Song
2023-10-17 3:00 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS34v5PGWhCdmBjI@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).