From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AFA5CD68E2 for ; Tue, 10 Oct 2023 01:31:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C77C880037; Mon, 9 Oct 2023 21:31:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C275E80027; Mon, 9 Oct 2023 21:31:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B163580037; Mon, 9 Oct 2023 21:31:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A289980027 for ; Mon, 9 Oct 2023 21:31:52 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7AF63140491 for ; Tue, 10 Oct 2023 01:31:52 +0000 (UTC) X-FDA: 81327825264.26.3C180D2 Received: from out-195.mta1.migadu.com (out-195.mta1.migadu.com [95.215.58.195]) by imf09.hostedemail.com (Postfix) with ESMTP id 8E88E14002E for ; Tue, 10 Oct 2023 01:31:50 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eRylKYE4; spf=pass (imf09.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.195 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696901510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ho1/AhNyD0qYiEmVEK/IfiNfgDoSn0wjA0JY40hhrfo=; b=slDD/WWqhJ9F38TjTIMvucjhA+JZ4itUV7T7/4CgiPbpV/tvhNMQ1CxaqIvBmitN+DCTwK ZCSB8EZeSXGnG+k3CkjqPcJ1OS1b0vr/xsV5uYyaZYgo40L9VTVYSTrh1J2gVkmLpapztr Q9tUX/mvnNfHdUrKjtfvZyW4bCkLIR0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696901510; a=rsa-sha256; cv=none; b=Xqd5uodwe+0p0V4B1/Teq44RfiLq07/JI5qU8X+GCI+VP3zEMYpwUsDhwDKsGSQewNoDwE 7DhWg4qt+Wno+/vdgxLEPpLxk6T+dM90/ZxBNVJqTdquUDD7g90yutdmhHcXkgPhXPAaOI aItV9Bg5bIzjg4sToVSjv0gbq79NSAw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eRylKYE4; spf=pass (imf09.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.195 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 9 Oct 2023 18:31:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1696901508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ho1/AhNyD0qYiEmVEK/IfiNfgDoSn0wjA0JY40hhrfo=; b=eRylKYE4l/CKWymVpIyaPDUoBL9vKiqAT0GEXztgMI21lINvE61Io6wKq3XH8UO0uvw7Kb zbCMF2VYFQEJzkDE36IwgbqO9pdqe3JFypmJ8s46vInBChDcv2+24kT6ka2+P/W9iXjMNB /MhETnefBKNjqKZnOhZAD6hR6oLVAjI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Andrew Morton Cc: Zhaoyang Huang , "zhaoyang.huang" , Roman Gushchin , Minchan Kim , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [PATCHv5] mm: optimization on page allocation when CMA enabled Message-ID: References: <1683782550-25799-1-git-send-email-zhaoyang.huang@unisoc.com> <20231006141750.5423083520f74bc0746fd249@linux-foundation.org> <20231009171415.cfc26b45c2f9f4489afe16c2@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231009171415.cfc26b45c2f9f4489afe16c2@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: hntkztxf3rii67uph4ensejgy6sm15zp X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8E88E14002E X-Rspam-User: X-HE-Tag: 1696901510-264787 X-HE-Meta: U2FsdGVkX1/FyMo2oP486XD/+hshI9ccykk9bU0Ss6xUnO/37qHwAA1/s2fAc6Hqw7z2jmMSHvKHbk2VXpKO8oswWIJo9NAqs19S7ET4oAQylXaROtHwnQvKVHrBfm5MNUUKdUffBooOhnhWp5R3QNhZA//TAf7dveu6gph5bmzRpLX8AtYHv85JPNzxhuvo2+WRkLDyIgc3uWXA4Pt+3VMxo6iDDgr6NfC+mzwbBka+2mFsGHtZsF45io7hKPIoXBzKdE6CbLFjJkaYYI2G9KdhOZmC5PLKrIKPoPAB3xdrwNfsgfBs7tRvoAw1LC4ZNYDmH38r7yt6vk3SBz6fy/edF87KSoDGwrsxcYK6x5T7t/tVgfVxRuashLjB5X8124ZuXqGN3s1Owfe9rotPn+ZeTANSA9Lqx9MTZTlVVYgtYwgKtD5cK0HZMgmilE8/jFeCfhDq7BT+8acB/p872HOQt87M/SHQGR1nta7hwSwIum6LTjohjJBrLBPUu8k4RNpHLMXk8BuzuszKUUVlac3nE0PegxWPmSeRkbJVNUEuJXWVAqSPBs3hdv6NLbD9JcI7Q3j+2vfiH8co2nUGDW9HhAtRTj4qSqMWRRqP4NK+0iGU6tGzfZWyvFukyFimPhPfiRNF4cfYZuQq1O+ao5blMPkjbThPQPdGpEUxKyFxWDHKgSk8uG8O/VuuLiD30VY3bY6W3elcb74Hf55Ihh2Y/MTRhF6J67NyMYTJF5cIBgyHQtgAGWsB/kexn4tvHNIfE5HjUzIjRVmwk8cN+qZPiT9438JFZTwUGtTRxEstYqNS+OyXmIqGnlTks+zCK0irJxoqSvvtxjyyhPd2T07n6Nj+DSwWVNK1QIaOF2kHT7jDSqtf9IB7zA6qHnBrtjJ3yAhTF3rajUMZyfZ7OOQ/xIltCdKrF+aQunqPHx1Kelu88iB2ZHosckalz/QCj3h5WwBY7lBnQLXToAh lTf++VGL k80illJ+KNadfZHMcoRizwzJmJ37S/b6buqejgstHuQ47r5QaH1a98Kk0cJIKVrmrtJXLnsczRLy/tSSImLEGacxp6Gtxp+3flRkh/qOdmmS9ZxM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 09, 2023 at 05:14:15PM -0700, Andrew Morton wrote: > On Sun, 8 Oct 2023 15:54:40 +0800 Zhaoyang Huang wrote: > > > > Roman previously asked > > > > > > : Also I'm a bit concerned about potential performance implications. > > > : Would be great to provide some benchmarks or some data. Probably it's > > > : ok because of we have pcp caches on top, but I'm not 100% sure. > > > > > > Are you able to perform such testing and tell us the result? > > I have applied this patch in a v5.4 based ANDROID system and got no > > regression problem. Actually, this commit is aimed to have > > alloc_pages(GFP_USER) use CMA instead of stealing U&R(could lead to > > GFP_KERNEL fail) only when zone's free pages and free cma are around > > WATERMARK_LOW/MIN which would NOT affect most scenarios. > > OK, thanks. > > Could the appropriate people please take a look at this? It has been > in mm-unstable since May. I have 2 concerns: 1) it's still hard to understand the commit message and comments, I can only reverse-engineer it based on the code changes; 2) performance concerns I expressed earlier are not addressed. Idk what's a good benchmark for the page allocator, probably something i/o or networking heavy. On the positive side I believe that the patch is solving a real problem.