From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15268CD68E3 for ; Tue, 10 Oct 2023 03:27:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BE0C8003F; Mon, 9 Oct 2023 23:27:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96E0080027; Mon, 9 Oct 2023 23:27:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 883E28003F; Mon, 9 Oct 2023 23:27:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 77A8B80027 for ; Mon, 9 Oct 2023 23:27:58 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4DA91A04E3 for ; Tue, 10 Oct 2023 03:27:58 +0000 (UTC) X-FDA: 81328117836.17.63BCB8D Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf08.hostedemail.com (Postfix) with ESMTP id 6C5E516000C for ; Tue, 10 Oct 2023 03:27:56 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=transsion-corp-partner-google-com.20230601.gappssmtp.com header.s=20230601 header.b=oLqu9koL; spf=pass (imf08.hostedemail.com: domain of lincheng.yang@transsion.corp-partner.google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=lincheng.yang@transsion.corp-partner.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696908476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bhbfhOiDXMThusPUaqJIFZw5gF6ALBs624t1yiARxuI=; b=XLdHZ+Qk94zzhdprwy9Op+quQLve/hqozf44i7UfUlTF7CrH/8tbYQjzYc+S+DZwTVzRYc wI3q7CP+0G8A2jc5bMKvJdAes15YuMUvRuSvcRMgz5iwyRP/Y71Llz2psHotkyofoZ76JZ lBUVdv2MihZrmemCNGLqg2Vx0XU0qZA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=transsion-corp-partner-google-com.20230601.gappssmtp.com header.s=20230601 header.b=oLqu9koL; spf=pass (imf08.hostedemail.com: domain of lincheng.yang@transsion.corp-partner.google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=lincheng.yang@transsion.corp-partner.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696908476; a=rsa-sha256; cv=none; b=YO8NToEXVulrniQXcuqQFiOVCgw2NxeKIckjNPCOUknNubJE1/2nQ72r4ZQAGYQpSGwStE tDrNhphJUWq8Q6tPXCgwq2SF6GtF50oYwm4NAtSMgsd+CsXJDVF8aQhms+Ax7K03bKrc4d Rus/qRqPbfcBiXeDF3lqhqF9c4ySTxg= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1c8a1541233so13581735ad.1 for ; Mon, 09 Oct 2023 20:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=transsion-corp-partner-google-com.20230601.gappssmtp.com; s=20230601; t=1696908475; x=1697513275; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bhbfhOiDXMThusPUaqJIFZw5gF6ALBs624t1yiARxuI=; b=oLqu9koL5dJ0Wv7H0cg6/P4ISIV0t7g7r+RYODjQAiNSGzS9rfYFjKezy+j7chLIfr HO8UKhsgKBvsV9e0ScLRr2x/fqWbhgRgQbq/Bq151wM3Yp631rhQBoa536XQQvKvKKE6 QymaVnCdFt7c5B1a/M+iv5LyWZ+/FuiABnQre2BnG0SSsA/k6lkjHtvz2JO9bA89Z8Cs WGrHis3XhYaijbG8puj3wR3rq5fjEh9NlKpMwa+446QFk4JB2WLaQF2leT9zzRU+f5NN UwPAJEmVT5ITAF6OnTgweeqwKh22Pco4/+9L5FDwLTxSXTO5sBXnBTFDhNZl43Amy+Uo EnYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696908475; x=1697513275; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bhbfhOiDXMThusPUaqJIFZw5gF6ALBs624t1yiARxuI=; b=NdWZxq2pM59avQ93cJIy53RXwTvMeCF70Xd5B9BAWJxmY9nB9NkiG8vhoe+/gGyVX+ YCml8yYSpotWXmDw43VnPZfszkojGd9Ceq0TAfBzAFQ3UNKveOB9wH/kDiSkjSTSoWpI wSQP2HSBLtmoKSLTNJfS2ZNzYn4VsVH+yYcJhoTNRUY0DI/W80tbATb58rtXTCRCdGCr ZJcFefeRfTNXCY0QW2bd0/biUK7MgjO3hKgNUz39CpBzVw6IRcIZNl8o1JVQOkUYvupr y89WPL5+iewldYCKJ4pNaYVfscTasKUWFv4gnxguJWUfu2eU5oied8lglF7INOTApG6t TtlQ== X-Gm-Message-State: AOJu0YydgoLQLCLuV54L8kzkAtguqkaCFU1SvIHu+Ee1458ZBadhVWOc ddqFVAby0Fnzh5ZZPybmRHXSAg== X-Google-Smtp-Source: AGHT+IFd8YeEDe6d/8Tnj7xI+kI9zS2Soyi/j4sYAX77sIX22IGPuRL4SC918/Kv9bQnvhrt0rY1ow== X-Received: by 2002:a17:902:744b:b0:1c9:b19f:7edb with SMTP id e11-20020a170902744b00b001c9b19f7edbmr700199plt.52.1696908475192; Mon, 09 Oct 2023 20:27:55 -0700 (PDT) Received: from linchengyang-VB ([103.40.76.4]) by smtp.gmail.com with ESMTPSA id y13-20020a170902ed4d00b001c898328289sm6718526plb.158.2023.10.09.20.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 20:27:54 -0700 (PDT) Date: Tue, 10 Oct 2023 11:27:46 +0800 From: Lincheng Yang To: Matthew Wilcox Cc: akpm@linux-foundation.org, rostedt@goodmis.org, mhiramat@kernel.org, hughd@google.com, peterx@redhat.com, mike.kravetz@oracle.com, jgg@ziepe.ca, surenb@google.com, steven.price@arm.com, pasha.tatashin@soleen.com, kirill.shutemov@linux.intel.com, yuanchu@google.com, david@redhat.com, mathieu.desnoyers@efficios.com, dhowells@redhat.com, shakeelb@google.com, pcc@google.com, tytso@mit.edu, 42.hyeyoo@gmail.com, vbabka@suse.cz, catalin.marinas@arm.com, lrh2000@pku.edu.cn, ying.huang@intel.com, mhocko@suse.com, vishal.moola@gmail.com, yosryahmed@google.com, findns94@gmail.com, neilb@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, wanbin.wang@transsion.com, chunlei.zhuang@transsion.com, jinsheng.zhao@transsion.com, jiajun.ling@transsion.com, dongyun.liu@transsion.com, Lincheng Yang Subject: Re: [RFC PATCH 4/5] mm: add page implyreclaim flag Message-ID: References: <20231008095924.1165106-1-lincheng.yang@transsion.com> <20231008095924.1165106-5-lincheng.yang@transsion.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6C5E516000C X-Rspam-User: X-Stat-Signature: zrycs3mz6set6jqw76gzosrgbdufgo9y X-Rspamd-Server: rspam01 X-HE-Tag: 1696908476-85039 X-HE-Meta: U2FsdGVkX1+rK7H/iox16QY8iuMKMaoL8OWf9K/xzVdPvJBEpW2QrI2tGMDySaF0l9lQTcVeK2ryRhrJZvQGP+2n2pmwzxghA9QdIZ/twVH9/eatE+WncRhrcnz7cmRUrq+AP36Vzb43/jFx9o9ir3+FJ6CTIb+oK1mNBAP20R1VRIIMx2Z9dZkr0HMj54LLfAn4/No+bKHalchtPjJSTz7HyuVFM6eYmoQvVL22oVMAJiS2UBcLULMCjj8ibkbHomR7dtcSWWp1nPn5HzB3O9l6RWU2DwnmqwLbLoAHLVcer8gVfhHUejU2h2lNpj8mM+2rnsLa8hsQ7zvqnNLuipqoOiLY7no1dI4c9OEvvAnzQV7TvTCFrkbrtJ1BxaH73IXPSevIMnw3BWhsJzwhWFe7T4ZUXeuxVwuCYSLlgOLAfZG3VF9ldMTd/5d9mcPyTCQiT8ouuFTUiY3Y50noXpm4MaGdmYKHws18/7ZNhU7aA8AH6rJC2ak3ncHWCH890r9JMMhMeQCJEdKbsZoln27I0ihbcQGMCwydXOVutL7G30nKu5erAIjdwTZf/U2Qv7zV8/wjsaMHjs/rx2DVmGdOlO5XU2GfiGfqxruGm6JOqjI3npRhpI7hrB1THqEtjuvFWDwFmCEiG2IljRHsTUmkTb9ykK9CDIcbhrGTRxJOloSLtu/T4CisTdVs4fU1moqlXBZbSI513GQz2mswyn2ORDbxuV9yG4GP5l0Cfe8f1oPpSpLmuSQi8drWzsxfg4OscYYTs/l0Fqss4zgLRY+GekqV7jAln4gE2W+8uhv26rU4pKzpwz3V5D2v4L3bz2AyP7qk3Yqz+oXYR/e8DXYP+N6zg1l8qIkiLL01A6KoinqtqUXhDInhgbYIFLTTGIFzYsTsLvmX7gUFn3P2hs5j4S/TtbOnM4aEZXHORFTeeNlv/Gr+G8SvDBlyqX/U900Sh2mmpLF/GSpSG94 KwavaQsN FQ9JCaw9LHZ0k4KMgWgyTn6uqytHDygzJjuksXHpk5nNSoKivqwe772ENtO0ITzVLBgJNl/3d7LWoDevsJZ8LsK3B/OIKmE0zFV6g8VDBDd+I98okAIq+7LBy8LTEopbAC1fMgdXptiyyb8DdnZct1QPsczAkDikvbuU+uRGMhEUNeZKAt0EA44pFz3pEZUB8UN8nTSg/7MWHjx6mPQzKqJE+iSZlJ56CYzj6iC3JYvyVEY0hPiGfVMPXwsX6twh3i02utZMjAv5ttzOJ+D7fZYaInulQ44+Qh5+B14zV4VvHfYQ3Jnr3hZhmfYEog3gNDtl3wdoGEuVRHcFv7WzhU6cXtFYSM8zgfoN46nyXSuPUVRqzxuyKTTkXPT6LmKMmtdft3XUgVd2f2ALueIkwejDeXT1Ki7x1NkPZEpHlIFY0+uS77V8sdZjNhOQAJnYGymXMiJ8k7FXT3arRV3FhJ0sX3PfK+hprEnSdDrHLre9dOU3FlKi8NyLrtIpuZoekI/cjDZ+Gx1uokgATBdTSh1PNUfzCvcC+N8x+YheuGNN+QXC0pFdIHq9+b5/rcBbVEycwujycV4o8lmg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 08, 2023 at 12:07:49PM +0100, Matthew Wilcox wrote: > On Sun, Oct 08, 2023 at 05:59:23PM +0800, Lincheng Yang wrote: > > Add implyrecalim flag means that the page is reclaim from the user advise. > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > > index a2c83c0100aa..4a1278851d4b 100644 > > --- a/include/linux/page-flags.h > > +++ b/include/linux/page-flags.h > > @@ -138,6 +138,7 @@ enum pageflags { > > #endif > > PG_hot, > > PG_cold, > > + PG_implyreclaim, > > __NR_PAGEFLAGS, > > Can you do all of this without adding three page flags? We're really > tight on page flags. At a minimum, this is going to have to go behind > an ifdef that depends on 64BIT, but it'd be better if we can derive > hot/cold/implyreclaim from existing page flags. Look at the antics Sounds good, we will try to do it with the exist page flags, if the exist page flags does not achieve our goal, we will use an ifdef that depends on 64BIT. > we go through for PG_young and PG_idle; if we had two page flags free, > we'd spend them on removing the special cases there. >