From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9815FC4332F for ; Sun, 29 Oct 2023 23:15:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A12C26B016C; Sun, 29 Oct 2023 19:15:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C3126B0185; Sun, 29 Oct 2023 19:15:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B1C76B0186; Sun, 29 Oct 2023 19:15:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7E2506B016C for ; Sun, 29 Oct 2023 19:15:00 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 538891404DC for ; Sun, 29 Oct 2023 23:15:00 +0000 (UTC) X-FDA: 81400056360.11.7519005 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 976CFC0004 for ; Sun, 29 Oct 2023 23:14:57 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=s3Bd+dzA; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698621298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VT3Ad4lScHgALY3lYyr+KQk9MBuJnneunm0wQQrliGI=; b=jzRdxAd4WQ/iOfZ1L5n8K4OveV43+u2ijUWRT4cY9TYVCIu0e51jce0uKP8FTCtiLYsAM/ qvHwlz5WBgnKr4N0X9bCYqJbpbm7B4P6BIWhOtuSZ0cRPFUY+hMXz8UKwue/8+9W2+fEcJ MXpKHHm4ZqLI/2e5e1KEMdDdzBBpr1s= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=s3Bd+dzA; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698621298; a=rsa-sha256; cv=none; b=KbkJRJJnn9p/1SbxbyGoGUpUQHlnHmmRNyYgt2bpfepdqukecJO0nfCTPKjfqyBZr9aFD2 jKvU0jW7v3NDTAyvDM+Mio/luxzakVyn6bEswyFglRoJhMqZdwtFG5yuJYxOdjXZOiUIe3 0ITc1JNnvT6iVogR/xegTZtD8SJkA2g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VT3Ad4lScHgALY3lYyr+KQk9MBuJnneunm0wQQrliGI=; b=s3Bd+dzA8IVaL7EAr7sc9o7QFs RqxVYSQ+/gE1vs83o8o05Nml83SpfDzOtgZwmw3laXu4TZAQOHivFfFgiowRBqjspvKLEudIEYb9i bnznG0G9e0ZqqWXA5OKNdT31xCgyrgPn/vVwWmiWpKoynl0nRIHymyOuTgjTTEgSwdVlR4133p8j9 GV0Gtf2XLrx/3RAzU1e6NNQEhOYi+0cO999GMT0P8v1HoSCFe1b1ddiflYIb5fGoS62Kulwjlm5ex cRIS3gQfrNH2j8IzX/5qauNRHa/g+//WQ+zdwkekYx6e6hkwGqOallL7PfrmxdS8aBZ7dirFGyR41 D5zM70qQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qxEzW-000dtM-3j; Sun, 29 Oct 2023 23:14:46 +0000 Date: Sun, 29 Oct 2023 23:14:46 +0000 From: Matthew Wilcox To: Daniel Gomez Cc: "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [RFC PATCH 06/11] shmem: trace shmem_add_to_page_cache folio order Message-ID: References: <20230919135536.2165715-1-da.gomez@samsung.com> <20231028211518.3424020-1-da.gomez@samsung.com> <20231028211518.3424020-7-da.gomez@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231028211518.3424020-7-da.gomez@samsung.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 976CFC0004 X-Stat-Signature: 8rjd81x5h9mmrf85hfc6nxjb5dsbqbcw X-Rspam-User: X-HE-Tag: 1698621297-62438 X-HE-Meta: U2FsdGVkX1/uvnSHrrYkSuRaWB9pmm3EyykHzfAf11E3PXp3cpxT/w6PjGZW8EOMNYwdQW7elWWIkcwvS9qORfHR3gPY35ESSVLSSNMg7YbtwdDdsGKoK79B3llJVFl79BUG5kKdlwdEojW1Bdh2PHpyGFJnboLka1Hzd05X7lPKQmnNa51cVeq6iLeZf63FxqsIlCHgAtfRjzXpDUcFavUUdouE+X4QC+JQ7jbROUiJJO/NbYrecEOMZvyeoVN46tNqXVqUNWTXi0KtUpVqvgMUEs4ARUjwaDtJKZCfAJejWRH+ugfTRW2N4ZaCAjTyFic0UWUAjNaQf31giXhQxqVo2fWq5YV6eUP8GJHc6siiOWA1D3iuGOll+S/bOOnDeSoQOGIEjkGUdRQTvXmRJJEYEv7Sk9pzPAzZnV2YNah2bFyMIe3D3pyoecMjU3yylUtTV38ddEMLcNi1gUErFgk6ZXsZZ68lc+rBdVacr6PMhkLFX2KHytxOO/Uh5J8Z8xM30vSyR1X2nQ6Xw5j4DQxU13HBhFpkAMc2B+EYBaBMZR5zbeYX36Fyf/C7dHMnZw+Ri5PU1a6gNeSUWEpF50U5ooNGEhl1OV0Tl8EuXL0+sEAXYc5RkVgfiIX9/vn7UIB3dRGT6dN6L+PGktRfLLkYiZeaL0WTeT0cWI2m1+zCKxhmU9SmM3Kpk6oGwdqyus0PzClNXbSRv8ndqTmtdhp1KTY++CTTy20OTLCotK/VitUnPiGw2t4aTOM5uITZ9cZQwCPf2RRGan9mJibpGgnrqM2I13j6Ah0vL3CbNtLg/ARRE2BFYs9B7Q+Hlw0JwPUa5Apn7Jwb1dBCPsw4NCjrHFoaHWIrCdAW5Pb1cIAzVosglSZT13W+wwqhVJFlCgk4k1az/PUx6g2d6gba/MTbfTql4DJoPsbiD/GgXV8xf7pq6sjt6KRv6e/tmQoPXBpxnvmKKvYYZQuwyvp 8pR89tjB E9tpEqfo6LkU8MoFWevkxn54/1uc27G4Ri3RxnKXntSnxbVYiV+dttnhML16LKNJ9fhhvzlAue+PpIyqFzqJ02jon5T2DayB/GVCguc57T1LoX+v47LTReyeMEDWufZfoAD7ffSZ3AQSI7S0bxXiqYIOtb9l6+u1GpyMimhCq0yv4dmyUJMxBWiCQxjGEhFbZOXHuwnYGeWFxLnPGFeSeTtgnMEskMf7XH1Us X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 28, 2023 at 09:15:44PM +0000, Daniel Gomez wrote: > To be able to trace and account for order of the folio. > > Based on include/trace/filemap.h. Why is this better than using trace_mm_filemap_add_to_page_cache()? It's basically the same thing.