From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36372C4332F for ; Sun, 29 Oct 2023 23:17:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3BFD6B016C; Sun, 29 Oct 2023 19:17:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C5346B0185; Sun, 29 Oct 2023 19:17:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 865616B0186; Sun, 29 Oct 2023 19:17:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 727456B016C for ; Sun, 29 Oct 2023 19:17:38 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 37793120518 for ; Sun, 29 Oct 2023 23:17:38 +0000 (UTC) X-FDA: 81400062996.21.91C53FF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 990BF40007 for ; Sun, 29 Oct 2023 23:17:36 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Emsjtjrn; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698621456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e7NRE5J4yBZqR0H04zSj76mSU3bYxFrKgKvbigz2r28=; b=U7i7zO+uamqfO1w5ovhP36OpJbRC0VmyZkAI+0J9gCWaV663VWPsGHdpDbtKCbkHaJvuRq WBHaxvYQmMZOYRTenP+cz95olmpHby2tVd4Yy+rbkdinZSkx1Z6hwU5uK2pTJRL9OiwPuu elwOmjSkS/tqxNEDHlsa5Ijd5Xv1MMA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698621456; a=rsa-sha256; cv=none; b=qLevcuZ9miN3OPrRnRZofH5oRcNAqOz2HF6RpVi+hKlViGS+S26dEsRCYSzSioKVvbygdL aTS38CkEE8gR1QVuEPaPQTxYit5YtTQ6Vib6Q1ECTi/29uzYWI9IBCdm+/OuHOk/Hbqsbp WDznWR7H057br5O4XFQoKvjzEVL5mF0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Emsjtjrn; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=e7NRE5J4yBZqR0H04zSj76mSU3bYxFrKgKvbigz2r28=; b=EmsjtjrntCdnf9uidPLCUElZDB rrLD1wAHhepXZQrvGeOqBYYrY7Tm2+OM6jT7pom/tNGj7AoH891NPoJT8KuPKRh+AQtMYBMCMefDo wm8nGdoeNoLPEYQnXSZMLM15uLPaSqp3IWyB6tnhucTKnq8OkQBIBfEc0M9GdszRLCv6VRvaz7BG+ T1lynS2U8rv14NYjMUt+c7y/24ViXrjkv7SMQGjLsXCBjOxwpQwqezBIlD0j4NLC/6M5emqrwV333 VVXTpXKU77MAEC886DdrahAN0jCoTeiAqivl/OOSPi04RStNzzcwbeuzwXO+omjsHDhBkFnpQpnCg 5VkJ8ejg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qxF28-000e0z-RF; Sun, 29 Oct 2023 23:17:28 +0000 Date: Sun, 29 Oct 2023 23:17:28 +0000 From: Matthew Wilcox To: Daniel Gomez Cc: "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [RFC PATCH 07/11] shmem: remove huge arg from shmem_alloc_and_add_folio() Message-ID: References: <20230919135536.2165715-1-da.gomez@samsung.com> <20231028211518.3424020-1-da.gomez@samsung.com> <20231028211518.3424020-8-da.gomez@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231028211518.3424020-8-da.gomez@samsung.com> X-Rspamd-Queue-Id: 990BF40007 X-Rspam-User: X-Stat-Signature: saspf9tudyx3z33upt3p457fnwuzpcyf X-Rspamd-Server: rspam03 X-HE-Tag: 1698621456-617175 X-HE-Meta: U2FsdGVkX1+a3vyBAyD3cmZBHV4aJBW0aix2P1Yf3ce2QmtH3eaTOsJP3e2xa4dHLIkQkoBut5nmK0v4IpWM4uko1v6QD+f92OoOfsFs6ntWd4M6ALvoak7wiNGBEO/xtN54kXYDtbbzjJhe/yqK2ftgRGFJjBMQoOY2rf+TiukyODABvXIwS4xt3p5CRA/rxgnphC1FGAlAT8gJcir3P4N8xN1t6ZOwtlNWePdWbtSurhoTWTLAEofDiuQf4t+9UhaJuxIgwMybl5NtgyCLXLfoZfQdc6HtivwO8Jq0j6LEfh6uVFTtSDBsUZW3qmPq7iXHLeMreCrPortXmqvypuRwL/i7wLSMNsK/LWN7tadIh9DKBtjaMp4lyOk4UTv58p1ehGpV0MjZjcks8aqUD62zpc0xTCHlMzkbirypOGyCepbpXV4o+DKkiZnvaDlNwoNELqxkfT7jMlSA2Y9T8OqV6CFOl5+sTzbKD/k+YWanL3VszRuU4iASsvUbNK8hVQ484dRB5FsZyN+YoMpAzVtRPgsSa/jdyHJuzPgMA2FLdGWgQ3qaVH+ldQfYN6v2XbBT8xssjEAIB52uzRJMCF3/pzTI4zaNwEXX9MbWDDrKrdKdmTjkiBGKI4PK1AskRWSwlT1MbT40XwFqAH/al98SchOQ2XWFTBh8nLHjx4tFfmY05vYc3Fcj7U9QpIROdenSVDt1imGnrXOGmsqQP9cHBM4gz2xb9AIiNdFjWlS/iZEm1/fdlqCxuzEZe9sWl09Gb+fk/xtZO3TN+5vJCMYb+YVOh/jcsMDLgh8Y6Enr2AwEoravlHiw+ekJBsqlDv1WCSGVvc1iaMlm+ceqimxxmu4xjOyyEyI5Tqx8cN5bKP0tWIRV1MqxgG80HrHwmSlLC7nmeAJbDOaWH7IkZ/xpwVLjF62zRJah7Ihvu+ZDxf+Xp2v0CvAgHtBLDVf1QMLrANxoa0uJzSPD5qq 2cbsDIRD uIlQ7HXJeDNcR6I2N0ClDOvVPUm2p2s5x/gtJQXvhKsBJt3CMaW1W2/eCiWvT7QBBUDpzqUr77CddRYSQ9S3KPoYwdNZChCTNqW6uL5AwycspaX/FhvFO6OBPqULlxtJFfGPLWpGpU/h3ZncepmhtdQ3nKUHgCuD5qLFmq4n44Vjk9xmy2veDXzpUWuZCHnik5zt9eupK/gYgFa3lN1ZOSF6nrh/NytKM/X2j X-Bogosity: Ham, tests=bogofilter, spamicity=0.010618, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 28, 2023 at 09:15:45PM +0000, Daniel Gomez wrote: > The huge flag is already part of of the memory allocation flag (gfp_t). > Make use of the VM_HUGEPAGE bit set by vma_thp_gfp_mask() to know if > the allocation must be a huge page. ... what? > + if (gfp & VM_HUGEPAGE) { Does sparse not complain about this? VM_HUGEPAGE is never part of the GFP flags and there's supposed to be annotations that make the various checkers warn.