From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09116CDB47E for ; Fri, 20 Oct 2023 08:31:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18CBF8D01C3; Fri, 20 Oct 2023 04:31:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1161D8D0003; Fri, 20 Oct 2023 04:31:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1E778D01C3; Fri, 20 Oct 2023 04:31:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DC3EA8D0003 for ; Fri, 20 Oct 2023 04:31:14 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B2391406F2 for ; Fri, 20 Oct 2023 08:31:14 +0000 (UTC) X-FDA: 81365170068.11.5EC7AF1 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf02.hostedemail.com (Postfix) with ESMTP id C73A08000D for ; Fri, 20 Oct 2023 08:31:12 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R10r+KQQ; spf=pass (imf02.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697790672; a=rsa-sha256; cv=none; b=JtoimfTkRDc7tkxOiZ2+p2DmJGL8p0GHv6HM0hE8k6S4ROVX0FlXjhqmQ/EkLOOjexjLLD ci+PqzUcTuev5ErT4FpHQq52MCl8dvkmN9IcskI7aayg0ylXjRFGP2ypEmyt1JmdcWYVx4 XoCX6VUApm7I6V3KcN/eo8Tt8S5lfeM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R10r+KQQ; spf=pass (imf02.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697790672; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=63XdKJFlE3XHdWbx77/cPD/Bou+LzOjSKYnLfRl/Zic=; b=KImazu1r0z7gHt7Ku8Xzkj0QQ2qkcj+oumsWfEBJtf7r/AUiYZTj+GR8dV+fbmaCylrhMb f/S0Gut0XMAGaa+uPvkf7mMaF64yciXqQePgW5J0xpzmqOGOJ6EUOOU9VymbbrS5va7QXW esI24230ewf+3E3LdZOxK2xQ6QZa1Nk= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-9bdf5829000so86122166b.0 for ; Fri, 20 Oct 2023 01:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697790671; x=1698395471; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=63XdKJFlE3XHdWbx77/cPD/Bou+LzOjSKYnLfRl/Zic=; b=R10r+KQQDzB5S4m8jhBMDohljz3zpPXr1xSeljOZpNJfYrAGLtty0CPqF9l39qDB3G HAK7IojRbTM1Vwllx/VDKT5SSemHFr5Mt+duH8Koi1sCWkV++D7ErS7PK+4jPXTy3/q2 wcWCIHDzm3b4KhhUA3NSnOHHBevFFV7wqgS2fdILjXu3EMscPtmrq2DhYmNajCAV2Wge Nysb7Ifu4jc1SKUAm/snpU/rzA0TfgVHjsKjKJX5NSBWQOEDIYMQcYlhts7QhdRrjbzo SJdAx1gVyCQxAWVcdn91tKdztZc9OyXJtiBakeNuUxA9uF5jX59hkcrYlbkGGlR6YpOD aKtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697790671; x=1698395471; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=63XdKJFlE3XHdWbx77/cPD/Bou+LzOjSKYnLfRl/Zic=; b=w1pJPGJzyUP+FWJZBW+fJkAGCpxHHD8ApOyuKZEepZ0/BnqE2/xdfWmIUBU4l6Q9TQ 3f68Z4ob/NaZunFDNaRBaH0NOvsZmleS+NcA0K1rFdlFzd4qCsvZISHpSwNqmi4Z/Ndn 5y8rCM0D4RhFMLc+gL9qZZOvNKhOdCuzweBqxFtHJIUI7yqLxGyQEcgDRgr0v+Pnd7AG cS7flepFpdfE9RxwuaGpBX1uZacVHswfPEhqmmiwuD3xXLbJ4Ml/qyilijlIpa3a89X8 6C0w3beZFYipDBWc2D9fZeYmoyZhAcwrUHizKI5r3xzQeQRBQJjKL9wjRALs3NvjNeZ5 jMIQ== X-Gm-Message-State: AOJu0Yzh7B9cm6doW6BGm2GYKxSqb0Q+8VU0tK0ydgu/3JFELxbRKkLS 3U87Bk610xAeHOYc6Pd5Dzo= X-Google-Smtp-Source: AGHT+IFOoBm3a2bQ11qHvOxPwlByvO21gJun8M21VkOUysgZc4U8IwN/X2ZMG/fH+O83Zum+sV4Y0A== X-Received: by 2002:a17:907:9815:b0:9bf:792:d696 with SMTP id ji21-20020a170907981500b009bf0792d696mr697889ejc.46.1697790671041; Fri, 20 Oct 2023 01:31:11 -0700 (PDT) Received: from gmail.com (1F2EF7B2.nat.pool.telekom.hu. [31.46.247.178]) by smtp.gmail.com with ESMTPSA id u17-20020a17090657d100b0099bc8bd9066sm1029882ejr.150.2023.10.20.01.31.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 01:31:10 -0700 (PDT) Date: Fri, 20 Oct 2023 10:31:08 +0200 From: Ingo Molnar To: Qi Zheng Cc: akpm@linux-foundation.org, rppt@kernel.org, david@redhat.com, vbabka@suse.cz, mhocko@suse.com, willy@infradead.org, mgorman@techsingularity.net, aneesh.kumar@linux.ibm.com, ying.huang@intel.com, hannes@cmpxchg.org, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/2] mm: page_alloc: skip memoryless nodes entirely Message-ID: References: <157013e978468241de4a4c05d5337a44638ecb0e.1697711415.git.zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <157013e978468241de4a4c05d5337a44638ecb0e.1697711415.git.zhengqi.arch@bytedance.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C73A08000D X-Stat-Signature: yg5wn3ydzzztmjhs1746oxj85k1hbkwt X-Rspam-User: X-HE-Tag: 1697790672-515907 X-HE-Meta: U2FsdGVkX18fJqXRvQzo3veALRLYsFGDdYy0ClV2vfhqp/2zGfVaxtYuIJpLZhwGOWuMpoc/ylZK0b1st/XG1kvo7PSlQLZdvuqBcLnAUvAMlTyHF2m1K0niiW8gVGNQI94Qm8Z4j9EfVbwLZ/LZj5gQzhs+/ikWKIxlZ/qU2bWCnYKVHg4q3yjDkkSoh3/u/AQkeK4vdskUPD1t5rGLfcMPLnZ2hplkQv9YxfwfeKoStdA/yhSnqO0bGqhrekM+MMCgEGOvymSPhhfrFMOMDXJaenqhd67s1In+0lE1VKinKbmVwvh6a43p9ufZ37vZ3uJrs4j1U0NK6O7Ke4O3O0TS4PsgCFtLgsW43BxUDVXlLTdouWWI4t0qhTbHRKgugkhrwMOmC/3NaauSW9jCNAa/WvFDhwb/TckplXiB7xbhTSOzq2R3Zl5wrLNo5+mLKq2nsX93EOaF5R12Yv4v73ooce96nrm+FxYcx1xgxZXK8ZoKfIQ7qdoXQtmcWSeVG1bGbOX4Y6qJLOYTNu0AJrzzXx7/o4X0CoQj7BkTbzzbIcE7vyo8Bq2drfmhF9Wb7I/WHxcPp8achSG5RTwqbpleYAs+2aNb+UljedRGnvXGr/XrriTvj4FLWJs0028yzKFhLhvwpxsMZqJc6YDaArnTfVCfPC8poUI3HrBvF5UmD5r79TOdLz46l7p+26Zsy6Vmh2iDfZ8rRQnZqjAM4fELrDqVF2+coqvhhu8e0P6RKWrY+q/5mOHBxPogq+1HZ9yXBlm1koyTgbFkAbNibRH/7MMWzFN8Rb/bkymGBJKrGJcZ4Dzqa1PY0RqZmMOBWsRaT0tGg2EPihN9ATW6y6eXBUiwJ7w0dFS0dcHFGASqh60k3Pv9IlL1+ziKhMvsn5QTcNX3Sfn5oHfsoUcyv+6wUOFGBYUGo10Fdu6fxp63l1J2vKmZ2/1Hsc/RzL4rDS67vGQwThPi8BFHWgq edmchZUd hpP73/9JW2yf8ahBK7lDL0lcyvowCi9RajS0tmhRW6YAUK6iFW5k0Fq2ZKE3d/QSZg/buUSds4Za6+vrSuzqeRs8KgP3E4ozv6j1VlOP1bxeZlizhTY3AafQ99X1SrC0T4Wbm2nj8nceLlM63LoGU1rLXwdd1yReY/QDxnKQSlfCbUO14Hw23ORtKbTuplhdqZuiwgvbyaiPju2ZFHAF68WdWHuycsen/w6lNWEqoOTbZmcEa5MR7YTEvoGsJGo1wwEvoikCeMYuy1oeu71xkRibVh/YfUfvW+1LYC4CIteowSI9pzDK7dTd4Qfjzv+5AbCC9sFp+y13Ulit24SCngdrJIqN1JErKuBzjT/j2fp2rIP1fBGwFrDyIPavEgbpPIg6DKNNRFCEZa8dlGI9zLGQwdl1j8oPwSPtZ4RVS1/gNkwjMZq0c0//PZkOrNjYsr0ucmwjHlnscYuONXC0QfpTNV2wt/Egle7Mp/v6mrvea9zJGYRJshc3wv+8MguAE6SldCUJ5DmExATcKOkryF6OxzFIDiCZjQ6lTICgv85YQoKEy/38jmT73wA9vkoPoAMV2fJ8J7Z1kV8DKuVKayw95HWq0LRB5Au3rDAYEcCsRJbDIPkTNYMf5OmRk2s4aUOjRowXF2oz/MXsMdlAURRdCnfJy4hxVAJhipOx42k/Gd/Ce1tC6/JJEUWNdVMcotLPJdHZvNv8S0X8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Qi Zheng wrote: > In find_next_best_node(), We skipped the memoryless nodes s/We /we s/the memoryless nodes /memoryless nodes > when building the zonelists of other normal nodes (N_NORMAL), > but did not skip the memoryless node itself when building > the zonelist. This will cause it to be traversed at runtime. > > For example, say we have node0 and node1, node0 is memoryless > node, then the fallback order of node0 and node1 as follows: > > [ 0.153005] Fallback order for Node 0: 0 1 > [ 0.153564] Fallback order for Node 1: 1 > > After this patch, we skip memoryless node0 entirely, then > the fallback order of node0 and node1 as follows: s/fallback /fall back > > [ 0.155236] Fallback order for Node 0: 1 > [ 0.155806] Fallback order for Node 1: 1 > > So it becomes completely invisible, which will reduce runtime > overhead. > > And in this way, we will not try to allocate pages from memoryless > node0, then the panic mentioned in [1] will also be fixed. Even though > this problem has been solved by dropping the NODE_MIN_SIZE constrain > in x86 [2], it would be better to fix it in core MM as well. s/in core MM /in the core MM > [1]. https://lore.kernel.org/all/20230212110305.93670-1-zhengqi.arch@bytedance.com/ > [2]. https://lore.kernel.org/all/20231017062215.171670-1-rppt@kernel.org/ > > Signed-off-by: Qi Zheng > Acked-by: David Hildenbrand > + /* > + * Use the local node if we haven't already. But for memoryless local > + * node, we should skip it and fallback to other nodes. s/fallback /fall back s/already. But /already, but Acked-by: Ingo Molnar Thanks, Ingo