From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B00CDB474 for ; Fri, 20 Oct 2023 08:59:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BC0E8D01C5; Fri, 20 Oct 2023 04:59:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76D368D0003; Fri, 20 Oct 2023 04:59:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6332D8D01C5; Fri, 20 Oct 2023 04:59:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 514C38D0003 for ; Fri, 20 Oct 2023 04:59:40 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1FDC540688 for ; Fri, 20 Oct 2023 08:59:40 +0000 (UTC) X-FDA: 81365241720.15.C102204 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf05.hostedemail.com (Postfix) with ESMTP id 3217B100003 for ; Fri, 20 Oct 2023 08:59:37 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ceJYpmUW; spf=pass (imf05.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697792378; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wzeT2I7KXF5wrth1EFsyiB8PmNqQND3ZfwJGRCIPSH8=; b=Wc7ZKCA/D13h5eT7VBSIfsO27E64x7pj/zvQ4KvoeP3L1u/sD3z88DCc/yhiV9yaWy1oPr UrWFdqOdKWFW9T8P87gxPcpD0pygEhxV2M9Xwbl05vbnSDT0EsG7QH5YdWAo901iaKZkQ5 pT6BuRPo0lZ6Ilw5lgCakAMjRedeCJM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697792378; a=rsa-sha256; cv=none; b=uzmvcNJXML1/J7nFDrdw6UqYvJGdOZNLozZERdIB4ThcmYhB9tiluyvtDItkMFHR1QW9AY JhY3gPkBkwxvNZlk1UK/FNbQMCQXVRVTaDFSGsmBMdgFb5leU7jpzdBWocnlqwk88xk+J/ iAmDo2ZgoWVorfY6ZAIvJovdKa+b0gg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ceJYpmUW; spf=pass (imf05.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-9c5b313b3ffso87281066b.0 for ; Fri, 20 Oct 2023 01:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697792377; x=1698397177; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=wzeT2I7KXF5wrth1EFsyiB8PmNqQND3ZfwJGRCIPSH8=; b=ceJYpmUWQ4nL58iwM19oHHk0VrLZp5qpk2B0JP9u635MbBDyYv6j7iTRIuB8vWy8mY Khpa9BfJsG3gZm398of3CfnO1guKSkAmcSXGLVBFcL9+ive1TMv/Zcdo4VduA/uvQV7H IyMIZsNcwqVS0n3wdsgvrSZjNYgQqvgpgeUQCmbrw482lNLt2h007KZWCPk4b4PEkK9Q hP0KR7bfrGgiJEyHlQD2s3AjSAgPrL6LktIvtohT9Qq3zVjsdc5Td67NVjn4jpjbJsBE 53I6Q/HHM0LNZbVc+6id/n92/fXddeP8KyX4cBbf1mAT5Zwn5MFbII4KklAm6Dee19c/ 6tDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697792377; x=1698397177; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wzeT2I7KXF5wrth1EFsyiB8PmNqQND3ZfwJGRCIPSH8=; b=NCT0U5A/ED/cKj4qxuaZvKZnHga+cZ8j9fSMsavvSNn8ftI5hEyIJig0Jp3Tt8QZyN HYQwiRuhrXoUi3Ps+gNXaNS83eWjgI1cZ5PdZ2bi+tTI5syBwYXKS98x16z5iBPFnt4u 0HwZi42BCZkyPpidhiTqowVWEjLupKMuzRkQeVCmTtf9nqpSgR1iEVHZS9eSiAbpUH2i 5IPH8J+34xDIxXhcCl606RQhdzkhNPVoP1h5ndouKRgNylGUH1Qn3924eLZP9bCZ6e1j qjQeUY9iQsS6XlcoDmf2ROQtYIaRqjwe7PaySGoA5aOu8UwaguIQ7ZcSJuq9SlMkxCfI sd/w== X-Gm-Message-State: AOJu0YwZD14L3LB01yY1uy7EQRW71LK/ylk4YNaQk4bt3bDohhcA21LN qDijCBhavINTH5spw0BNs4k= X-Google-Smtp-Source: AGHT+IHbUAIgDmB/mPMI+dTSsWNw8h1KO9nlStFsLpeBR6x2qKVlXwlVnXT3Cc+aJlB2MPA+co6xmg== X-Received: by 2002:a17:907:9342:b0:9be:40ba:5f1 with SMTP id bv2-20020a170907934200b009be40ba05f1mr862046ejc.60.1697792376690; Fri, 20 Oct 2023 01:59:36 -0700 (PDT) Received: from gmail.com (1F2EF7B2.nat.pool.telekom.hu. [31.46.247.178]) by smtp.gmail.com with ESMTPSA id f17-20020a1709062c5100b009c5c5c2c5a4sm1043079ejh.219.2023.10.20.01.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 01:59:35 -0700 (PDT) Date: Fri, 20 Oct 2023 10:59:33 +0200 From: Ingo Molnar To: Qi Zheng Cc: Andrew Morton , Mike Rapoport , David Hildenbrand , Michal Hocko , x86@kernel.org, Andy Lutomirski , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] x86/mm: Drop 4MB restriction on minimal NUMA node memory size Message-ID: References: <20231017062215.171670-1-rppt@kernel.org> <605cc166-e731-e7d1-25d7-b6797a802e6f@bytedance.com> <35bd1d51-35ac-3ee6-e068-f50dff7774bf@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3217B100003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 61z51n5t1k7wyewznhe7p154ss4ag9so X-HE-Tag: 1697792377-28217 X-HE-Meta: U2FsdGVkX1/Lxt/B8kp8tqD9dxdZTGMB0HsUAN+vv9ynVUaopEytGtjLn16AdpPxazEo9S+pDvOakqfd8N6ojxNA/pZqXZgt/KH9BEjlO33nKaPJJZj5QuTmBlRI7I0FW8cDnQE5LqpyVRvmvHXRPYCScJxy8vm8aIA+Gg+eri7nArTi7sA0p/5xIf/cIgWQ/Ae+WIgYRE+Gd8J9fuw+Z88rHNPh5Q/6xknSa9nB6yJtCHCmcqn9Y0Ym3N5bkLdqqHQ5xS2t+VeaDy91reJ5P/pguRSjOCCQUDOmAwigEf12czFM+DcIXfjlO3pW3vl0Q9aErqxTM0XdD58dNQftgHX4pPByiVjCsAyE216p1f/iOJL8ordYOeVr625ck1nQEHWvwwAHgWkIDeoQoFjg5nWeBaR5WeA+q5ncSH8g/zZqXxat37TdaCcSAmFwTeQWqFvNlMctO85jkegFsiJn3+IgWSK/Fup7qgOVH72Lu8OCMhKiCeyotxxHNt2dxFdr7F2Min+tg6N2l4vxeTHHzFqheqGtOTzLtsZ6to01svJWf9KCVFptMXL3Sci5YSRe+iiK4gc1439Tfv9XUh8ODX9QBXA6ggVs6o/PxXcNuHYNhxBpg8kELbGEjyQbefCHppyw3RGWxmbBkaNucs6wzoFr9RMMSehF41zAfbfOmBILBpPA9g/JMlg3pLExFCfhcL+7N+X6Kz4hUMbfP02s0eTy+mJSVRgBxap9L884ziccXeiHsRz7sZV3dgOFmMhjAZg0Rd1dnMMgm916EkFwxkH7n+kw9CwbBFQdmMSJjt1gm02ix07p4OqISHrKDLauop7qlZMPi3TGyXmAe+A84ybFCS7KbdKYQvQ4KD6iRsAw4tU8Br3txepfZJLlXEMxlTbbxQJxJ99GkwyqNF8qJIFQP0383an0sPtu5h8cmQ0PKxOTN0TBem2FS69Q5J85nvJBdsq1JQrsilZVipc JowZKikJ zHpJvRunXbnzly6X3seuZ2WL5HmxZE+QmaoKrn3n9hKHBvRVGb5Xjeu34+QDA8ytWk4/9c0xj/N6epaTHbMm78fPOPcLZEu2nb0ix12PIXXzP0+gNTqb6tTyOl4YBrfBoVTcO9ShNQ9ThBis6BmvihlMZg7LIgEf8/m8UldAmQY5PfZbSxOiIeP1tZdCnBW0ivbkCJi80KJ7q6omD21MKwwFjFEedv665CdSUd1ULmL17LEncvpjHMQkgAwm8Zq+tv/3BUf/DWjsDkGn/byRdSpHNkOoCF1mKfBtkJBdjtYISFeUCr2c6+wwoXZ3sSKk6D5wpZQPL2g/T4zeRs6xY2qdTCyBZc8zT3k5IV/IVISMthHw5j/28hz/sB6DDOQmQLrmAxnyBW+tBU7MVglxOpeoo9DOyM+SWvSkjG/rpah7vewPNsMicv9G/Zb5aAJphlZCFAL54jr8Uq2nfybWdporBXu3YMO8PeI6t/zY5M6ewCxTDoPpJ4wBq4i7gFsICitxFlxkRAOIyyR3XX5rj9JRFP5liPmN/h23F4Vt5dOMW6MYto1DYgqHvzn0npxERvlusXr/5Oz6o7zI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Ingo Molnar wrote: > > > Mind resubmitting that to the MM folks, with the NULL dereference > > > crash mentioned prominently? Feel free to Cc: me. > > > > OK, I will resend it if no one else objects. :) > > Thanks, much appreciated - and I see Andrew already applied your two > fixes to -mm. > > With that background I was able to apply the x86 fix as well - which can > be backported without the MM changes. The current commit in tip:x86/mm > is: > > a1e2b8b36820 ("x86/mm: Drop the 4 MB restriction on minimal NUMA node memory size") > > Which should hit v6.7 in about ~1.5 weeks, unless there's unexpected > problems. Note that I haven't added a Cc: stable tag, a 17 years old bug is not really a regression - but I have no objections against this fix getting into -stable once it gains a bit more testing and hits upstream. Thanks, Ingo