From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59FBFC0032E for ; Mon, 23 Oct 2023 01:34:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4FF86B0099; Sun, 22 Oct 2023 21:34:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFFA16B009A; Sun, 22 Oct 2023 21:34:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A0186B009B; Sun, 22 Oct 2023 21:34:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 896116B0099 for ; Sun, 22 Oct 2023 21:34:45 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 55E2E408A4 for ; Mon, 23 Oct 2023 01:34:45 +0000 (UTC) X-FDA: 81375006930.24.42B10BA Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf13.hostedemail.com (Postfix) with ESMTP id CC5AE20010 for ; Mon, 23 Oct 2023 01:34:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="MG/EI3NI"; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf13.hostedemail.com: domain of feng.tang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=feng.tang@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698024882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IUq9end3n/+EmJy9sS5lyEjEsa0JIbxbTMorlNJ+HXY=; b=mCibU5xxzpRUJBfzZhOMoyqvscQmX5cY0EwsN9/Ws2u5lIsdOVL3rwFdBFlEwwWnhc+PnP rcAwCBogk/HLXO2rAFDE5PuLL/2c5CCo7FnNgGIx7ToJzvrpXjewOfZx+fH/IVj3ay/EZR KpyE9pu306O6XTUypYBPWafLogmo61E= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="MG/EI3NI"; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf13.hostedemail.com: domain of feng.tang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=feng.tang@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1698024882; a=rsa-sha256; cv=fail; b=tS2B7Hy3gIeRA8C8FcP+ptVSjV99sr79TxHUGCGFi3RMeUXN+F/zj2BQlwq2Ueb47Ld+Km ycm8YBW9jZeMwCTJkgHGD7k0W7UZvRs0B838aTvn+YMKlRTOu0Ftr2PAkxBtPZexSqhN0e mM2Wc8IMjDcdA+uqSAsverYb+rEBVb4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698024881; x=1729560881; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=wosFIAbG88UlMRFAmd1nOyQWoKJ7if7tiLwxbLNkGVg=; b=MG/EI3NIjYnWw/fKBn/0pOl2dlQOhVlgyv/EDYrq58fWll5YfVO//6/X EXjbeO5Lg8fbUlRyZuUw+JW5oHYeLHMApBkZwx6GF76hc+5gRdJ6Zg4I8 AJLU5vNKgOGo8gdrd4HA9fr6GdAQfJSXiDYd+dTfb1LoBVx7eQ1gogW+p NHqKyeCkfvk69Fx1VLDV3uW8CT7DdbqxK3AVmxTLF8j7uNJT+k9AEX/7k rguJwsyKkiSNncbrZQ4rjIgpD52prscBe0jL7p7u1XFjlBzoAD6XEDsXG TaHcczrGcYnFcVJpDFHz95Vwi4rtzihufGqWngmUgAU1e6QYrhU7is8yY w==; X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="472959514" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="472959514" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2023 18:34:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="5909423" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Oct 2023 18:34:35 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Sun, 22 Oct 2023 18:34:38 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Sun, 22 Oct 2023 18:34:38 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Sun, 22 Oct 2023 18:34:38 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Sun, 22 Oct 2023 18:34:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a9dSyP1I1VSDTlk2ZdS/gESjFYXf88p71ocqc1VLpWHmljAwQCZbsP45u0ETWGuWoTC8SuAVBw1LaHsnqIY0d8ZXBWX/028OCK9oExuSLOXEBfThb3IEt/x6g0W87PUA05xuDgU7OiGq1qkHx160d6vPfysWNXyfdZPTOxSd2klh3CCe07ayr6YDIxVJCwwmRsqyiu9f6cU+Z+Hxi+up7748gGMwnDq/kPz0hAAOzWIRNWqCRqFWv/9ViLaJV5D7nV3A1iPubL9CZtrIj6H5ETppX55A3MY40s+naFl4A0W5+14UfDyYDZtKhTsh2q6FkVESj7ECNJAwcsAyZQCB8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IUq9end3n/+EmJy9sS5lyEjEsa0JIbxbTMorlNJ+HXY=; b=nsnWi/AlKPy9ak3G+moDnsxGna9SHR1HlzWwkW6Nyb4UsxzrqIRJ2lg7sSdk21PNbd/ggKwOCwJflv6DTmYfWn2ZqIx5LqIZxOfJ4lx0sKKE+mjYDIaYbGkK48AKUyiFbQS8nEEvasGgOmvNfkmSpo5Na+fQXmfJhtVC8Eb0e97cNlQNKgxNPAee8qstKXzpBebivR+Ul+6v8IncuXUdsgqh5lh6Em92z/O164nFEFr6j5X3fHv6HOJHsGmNaCqUAapBH7q6A36boQzQT1fa/14sYsH0HfaNcJuRLTMrArNsW5ThEVHTKIz0eZj3LNu22hx1/7slY9q4oQqDcyDIrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) by PH7PR11MB6746.namprd11.prod.outlook.com (2603:10b6:510:1b4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.34; Mon, 23 Oct 2023 01:34:31 +0000 Received: from MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::24ce:9f48:bce:5ade]) by MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::24ce:9f48:bce:5ade%6]) with mapi id 15.20.6907.032; Mon, 23 Oct 2023 01:34:30 +0000 Date: Mon, 23 Oct 2023 09:25:12 +0800 From: Feng Tang To: Yosry Ahmed CC: Shakeel Butt , "Sang, Oliver" , "oe-lkp@lists.linux.dev" , lkp , "cgroups@vger.kernel.org" , "linux-mm@kvack.org" , "Huang, Ying" , "Yin, Fengwei" , Andrew Morton , Johannes Weiner , "Michal Hocko" , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , Michal =?utf-8?Q?Koutn=C3=BD?= , Waiman Long , "kernel-team@cloudflare.com" , Wei Xu , Greg Thelen , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 3/5] mm: memcg: make stats flushing threshold per-memcg Message-ID: References: <20231010032117.1577496-4-yosryahmed@google.com> <202310202303.c68e7639-oliver.sang@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: SI2PR02CA0050.apcprd02.prod.outlook.com (2603:1096:4:196::11) To MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR11MB6304:EE_|PH7PR11MB6746:EE_ X-MS-Office365-Filtering-Correlation-Id: c69c9c30-d005-45a5-9a28-08dbd36833a1 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JJoja/VyXCnDCorWqIROeDudhuajvdpKTJw6icSZ2mdkZDe0QuxDxdMDWcMb93YfjdRa4q0egkRjuSNgW91U7tSFD0mYfHXEWgNZFLb7xNvkFvVSa38D6fnrzzpdlHVfu90wVJgXHBX3y1m2jcaV7HXJZaIT8mvgIoFH8wPHgKooeHP565F6nCWi2mjdzzha4Jn9dzcYleManf89Eo9mbNiVjY+LvRjSEE7eIEW51De4z7HfIwxhsD7LD8RLYwi6O8fJ8pEMSZkKZ7adgs1fsy3gos8n04i672QeZoX+w3bqlgbFaKt0vxoRVbfNctsh3/CpCS5MzYJrXU78TbE94XuC9bcxLKItYajbaY0pI96bVf+nauVXjsKhWaXikpA0nN7POi3t8B3EC6KxhnKUYnWxhot1Elykh48AnE9YfZ6236c7ISYO9KNu2oePb7blYKLyI8oCIDNvv2xfns9fp4Y8QahJ79KUkW6Vl8BIx7TbDpDOTyPRtmOnokU5naYwKH1MLOOdHbzsHJvdWEDCZrcPxFyflF2UOUDbSQcH+p4Qihk7QV5sgry8wcdxVu/1VW5d3pPZ3opxyNlH2QVm5A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6304.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(39860400002)(346002)(396003)(376002)(366004)(136003)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(6512007)(7416002)(26005)(54906003)(478600001)(6506007)(9686003)(53546011)(6666004)(4326008)(5660300002)(66556008)(6916009)(66476007)(41300700001)(66946007)(38100700002)(83380400001)(2906002)(8676002)(316002)(82960400001)(6486002)(8936002)(966005)(86362001)(33716001)(44832011);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0FLdjhqL2pIRG9RdzZEVnpYZ1cxY3A3T0xPUVBEcDlrS0xtU296Zmc1UDFU?= =?utf-8?B?SnZpN096T1NJazluVFFRTk82d3dueWtadUMwN29kTDFOblJXT00zVndYaUQr?= =?utf-8?B?SW9aZDBCeU90V2lUWFhnWm1GWExZazFsNEV4WEVpTkEvelNrQUdSSUJTNWdK?= =?utf-8?B?VTNqREgzNm1wY1N1Y0JwSnJUR0hsRE9QZVo3K1ZBN1k1REV3aW9qTnBsTktY?= =?utf-8?B?Q3R3VXVnQURhSHFJMDY2MW1qTy9tNnRFSzJjRkl0VXg5czZLc1NveUVOOUZi?= =?utf-8?B?RW5WQW9QdTNJYlIzbC9zMW1pN0FqR3A1VFZPU3NIcERqdlhiaXB3a3IybGtx?= =?utf-8?B?QUxpTmF5MUpCY3lWTHYvZm9lME1nc1FsL1E0ZnlDVHo5ZGVhZHRFZG93djlJ?= =?utf-8?B?SUdFNmRVWlhhSmw2Q2l1MHpSTTROU2NtMk82U0FaYldTMVJxYzFQZXNZbHNB?= =?utf-8?B?MzFLUTFEd0NIeTlBem1iVGFRcTlZeHhkVW5jbFlOUVlpcnRMUXlSSXZqdFZ6?= =?utf-8?B?ck5iUWEwYmxXcmhwNWdzbHAxRXZlTmk5cTNsd0NNSnE4UFc3OW9lMnFwQVdY?= =?utf-8?B?Tkt2V1MyUFRjRmM2VTlqUG5DRSs3VEM1NEhYUUtRdTZRQ2wza09HbzhkYzZS?= =?utf-8?B?djNnbHliVi9JQkFiemx4dU1MOTNWbE44MkkxczhqcU84a0Z5SHhjZE9QVE9m?= =?utf-8?B?UmV4T3gvdVpVVkFTR1k2WlIxdTJPbWJYaUJPbS8yMDRRZnRPaXludmVOU2g3?= =?utf-8?B?MFZWaHZ5YkJ1NWVjM0ZyZndCcmVReCs2OGhIVTUvTmVlN2s5bXgwQUFBSXR3?= =?utf-8?B?dVZOSTdhQ2xUZW8wOE4yN2laNktDeDVjOGVSRTRDdnBVYWMyUWtCYXlucGRO?= =?utf-8?B?OGFvT0g4QjZlbE1lUktTMEhQUUNnRE1DZ0R1QU5UQWRQNHdaTW4wMTNMOU01?= =?utf-8?B?Zk5KbTU5NHNwOUJ0Y3JBOHVCZTlTUzZqdkI1dXV3YWkwQlAzN2UrU1pLckMy?= =?utf-8?B?V2ZoUC9vSkhvZnlBTG1BRkJoeG8yY2ZTVFdXU2pQZFFDMjlRYWVzMFkvWWxC?= =?utf-8?B?YVg5Q2VsL0RxR1Z1ZjN2U0xRc1ZzUGpYZ0ZTOU83Rlk2RFJqRDNGVERYcVls?= =?utf-8?B?eitBMnVNNjZOVXk4SWl3aGw0dktWalVkcGw1ZXQrUnJvWW1sbWJaK3Z2YUNp?= =?utf-8?B?bFhiSjF3WTRqZDA1aXlzYUtSaXhQZWNLa0ZrQnNMMXFhWmtkQm9MdDczaVhs?= =?utf-8?B?OElnY2VEbmJVc0JPdjdFVXRVVk1HTXo5VkpVOFo1QkZVSGpZQjNBbzZLOVR6?= =?utf-8?B?TjB4cG82WVBwcWNhK0ZRU2duRHZkd0JjMnYzbEU4ODJxWkVTT3F2RFl4UnZX?= =?utf-8?B?UHppVkhjNDd6TFZHNk0xQ1RTSFZVM1NTSHQ4V1NRelJyY0tGbGJIVHBTYWlF?= =?utf-8?B?UlE1ZVl2SmdmTjNlQ0NjQVFwOFNSQTErUW5aUnN5REcrWDI3VzJvcUxXcnY1?= =?utf-8?B?eTFrNGdGbVlOb3ordUZZdzJIc1dORjdqV0N6eHJybmoxR3RkdXJXREErL0JZ?= =?utf-8?B?UjhBcml0TVlueWxTaGs2ejlSQjIwVXBrNS85SEh4UXpoNkg2NjJaaHlObkpV?= =?utf-8?B?OG5BdlVXTTJiQXpMeDlMT245VTkvampldUZYQ2RZcVZnUHFPQndyN3hSUEp6?= =?utf-8?B?anpNeGsvdlB5MnZZQWxCcDJYRnROQ2x4S0lQUUFOQmh4M095cFNxbzJ6WGc3?= =?utf-8?B?bkdhcUdxMzlkTHAxR1l3ZkNIRGtwU2JrenRVZnVaTEQ3WGdWRllwRnJyYlpG?= =?utf-8?B?cVNJVC8xU3ozZXRnMjVjcnVrSlVFZXlRWnJaL1pyYno5NS94aVUxNzlVZDdD?= =?utf-8?B?Y3ZJRXllMDBwbHc0WnZ1OEF5RWVQZzYvMm5JSllNeG5Fek9Kdkh2dE9ncytY?= =?utf-8?B?dzIzbEVaMndvRm5vUXdud1A2cFljWmY4NUVHQkpHR1Q3VUl2aG10aFNwVUY4?= =?utf-8?B?ZklxOWRkT1NZUjZFbHB3YnhGQi9QV205UHB2RzZZR3NvdUNrM0dESGFoOFBw?= =?utf-8?B?cWVzTjEydkcwUDRFeWVkUXRuRGpqcEt0b09HNVplRi9pVEVMOGcydDI2R0gv?= =?utf-8?Q?nQtfcTT50By9YwLygW9dag+bd?= X-MS-Exchange-CrossTenant-Network-Message-Id: c69c9c30-d005-45a5-9a28-08dbd36833a1 X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 01:34:30.0919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tjfLaqO8ldqQcPm4CTEPRH+iHRZ52LLpAt5+h/IMfyWhCDB6jt8dJUaFLoM1Ig/4P77COtR+NTpE0RSLDruP7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6746 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CC5AE20010 X-Stat-Signature: 1yqwt8wbcaraacgdaiwmyescd6igk6a6 X-Rspam-User: X-HE-Tag: 1698024881-237100 X-HE-Meta: U2FsdGVkX18F5/OcgqOXTm7lD9aactn/VszXZI5Srm7MyZaxgRigXUSmL42x1BDRo/TSXgvyH7Lw6KIYYtbdnHslc+2KPfZJDZl/lgN3QZFQHEP4bN+FeelDxFFTMNPwyc2riA4u4nzgJFnr4/dGJJZMOUKI7Cr8v1sIi5RCDn/AAjihFe5N9NQsWN+a6Z3J+rTrPPCTfsUdK2ZeMw2D7fwtk0wIFrwrDifwkRgI1dSXEP8l8cmVy7/qXbOZ7nUBaNcYIgzS/z2zrZaGnA4OHPVlt8ES3D9HyhT83evVgqw+kHGLUNjg0eK1vjfHLI4B+ZvZ77PdnGw7JY6LtNb9pCLP4uJMr2sNi5bBEwzmna+o7I/9Dv8R/pwNWppd00KcWF06SIrvGg4onBvZ2u0pSM7U59HZ2f/cmNlvZMVQBNqy9qhair33x2DmXobrr5sdp6rqDPBNEhH6Dzuh1PA5FcKle6PG9G/ZNTt9sRRA+6fdz1GB08VPsaNTqWrJy/JqT4nyxjgCAOQ5Xxy+Yd/qRG/u2YnR5zIUX83LA8t1D9rGUpUG+iRGKQ+UrGWMOy2VElve3kxZ1ZIWBXZ0Lw7CN93DwSlVwHsvIxWLRaBGjuwWsc8Kt51OVi2Hk28dnj9G4WVV6Ey9AdhbnRdSTkZ8rhY+fLUBxZipzy6k03Helv3iT2WLu4zZyRfoeS8kszoYSxPnX16NT/ATl4ihRGoJRi+6wK6oR+uQsM/fkkSKYT/n2j6AYzOi4NzW8tIAq78DiGSA8pBe9wRDo06+sIkyxT2AxGlyxhDCEdDtmBmkKLymg4aTUzpc80LSjLA4Yr1VkUBg4ifyw7yW3oJWkB6g1CP03AxYKnwly1+KWg/u6qwH3b6q/YgJeHDfE72QwC3825AM3k5L9Tbwvm1GeF4D3mjkduUNE9vHGVs5Ig8th1SQ//VUNJpQbl+h6Qpgn7NWz6QCKBTB4p3SvcmWTU/ FIfSRtYM OpmKK3oPsyPWhWw8iT9Njp6WJ5S8jOue2Z2bzt4IHx5BGKLGFJxFS/DCrbrnpFg2rLOc9jV6BKrHR27MEYmdLvqsb7jHNiDNrNd2drsPLPUQoFp40IfLXT6Hup84JOXElXRE0GwyjBsH9BO8bdOqFcb5jKyG1auJP6xVNspfwLMIbRVpu4WVwAIkW7Y7WSJ1xTFmvMgLgEzC9LfTl1mde0OyOXw/Ql+7jib1yh9iCEHTrQy6dRwidRVVp1bzmzf2k4YqpCCLqecZafaBuxp0xUrHoSSb6+PbkFYyMHJD4p7LPJGqtKZxXhlFLvvLbxgCkPdNci6TVb23OzmJcwPnpvc9a7GbteMmcfLWa4eX1hgMlyYyde3qgoAeUUad1weRw8tg3D4IMm/Sg1CTRGpaUaD+gHmI+1izLm23mG7OcF7X9Y+YnFIwLLGLfTx6CXTlBHSkW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 21, 2023 at 01:42:58AM +0800, Yosry Ahmed wrote: > On Fri, Oct 20, 2023 at 10:23 AM Shakeel Butt wrote: > > > > On Fri, Oct 20, 2023 at 9:18 AM kernel test robot wrote: > > > > > > > > > > > > Hello, > > > > > > kernel test robot noticed a -25.8% regression of will-it-scale.per_thread_ops on: > > > > > > > > > commit: 51d74c18a9c61e7ee33bc90b522dd7f6e5b80bb5 ("[PATCH v2 3/5] mm: memcg: make stats flushing threshold per-memcg") > > > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-memcg-change-flush_next_time-to-flush_last_time/20231010-112257 > > > base: https://git.kernel.org/cgit/linux/kernel/git/akpm/mm.git mm-everything > > > patch link: https://lore.kernel.org/all/20231010032117.1577496-4-yosryahmed@google.com/ > > > patch subject: [PATCH v2 3/5] mm: memcg: make stats flushing threshold per-memcg > > > > > > testcase: will-it-scale > > > test machine: 104 threads 2 sockets (Skylake) with 192G memory > > > parameters: > > > > > > nr_task: 100% > > > mode: thread > > > test: fallocate1 > > > cpufreq_governor: performance > > > > > > > > > In addition to that, the commit also has significant impact on the following tests: > > > > > > +------------------+---------------------------------------------------------------+ > > > | testcase: change | will-it-scale: will-it-scale.per_thread_ops -30.0% regression | > > > | test machine | 104 threads 2 sockets (Skylake) with 192G memory | > > > | test parameters | cpufreq_governor=performance | > > > | | mode=thread | > > > | | nr_task=50% | > > > | | test=fallocate1 | > > > +------------------+---------------------------------------------------------------+ > > > > > > > Yosry, I don't think 25% to 30% regression can be ignored. Unless > > there is a quick fix, IMO this series should be skipped for the > > upcoming kernel open window. > > I am currently looking into it. It's reasonable to skip the next merge > window if a quick fix isn't found soon. > > I am surprised by the size of the regression given the following: > 1.12 ą 5% +1.4 2.50 ą 2% > perf-profile.self.cycles-pp.__mod_memcg_lruvec_state > > IIUC we are only spending 1% more time in __mod_memcg_lruvec_state(). Yes, this is kind of confusing. And we have seen similar cases before, espcially for micro benchmark like will-it-scale, stressng, netperf etc, the change to those functions in hot path was greatly amplified in the final benchmark score. In a netperf case, https://lore.kernel.org/lkml/20220619150456.GB34471@xsang-OptiPlex-9020/ the affected functions have around 10% change in perf's cpu-cycles, and trigger 69% regression. IIRC, micro benchmarks are very sensitive to those statistics update, like memcg's and vmstat. Thanks, Feng