From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9BDFCDB474 for ; Mon, 23 Oct 2023 12:33:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 638816B00C7; Mon, 23 Oct 2023 08:33:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E85A6B00C8; Mon, 23 Oct 2023 08:33:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D73F6B00C9; Mon, 23 Oct 2023 08:33:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3D6666B00C7 for ; Mon, 23 Oct 2023 08:33:02 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0D86814048F for ; Mon, 23 Oct 2023 12:33:02 +0000 (UTC) X-FDA: 81376665804.20.16378E5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 5DA96180025 for ; Mon, 23 Oct 2023 12:33:00 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qMrKioZ+; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698064380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gJFY8X0LVejcCRBFVYdhIF1qXCBsVefytU23IKc3AY4=; b=DhuZ5vW8JAMhtUx+HrlsDHek6bHu8RZIHHcF6zbrGidY18yyGjS7/7/wtCS/J3358wH7Zd 5jf9+hUbvWRFbhsekgf5GS4dUABzfT039IEtnKcEkQLxNqoUXfrGJbqkqMFCuDG11Gnt8l WNZPaxtwXQuO4fExnUnDIyV7XjAqK1g= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qMrKioZ+; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698064380; a=rsa-sha256; cv=none; b=mIzljW5/ULDfQOtm0Wyh/W6kneJUjQgfQwv4pd7uZq+tjKoEnI0fQlCKYq67bdDwvMkk/K Rase5GS6WmJVUIe/2yO1sbnrFEYIs3IXwkywokYVi58bNfZjqoymxYD+1QNbNW6LJxQE/Z JZxXNedttS/F9zgVyMBrIoizQvZrTgI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gJFY8X0LVejcCRBFVYdhIF1qXCBsVefytU23IKc3AY4=; b=qMrKioZ+x8FlO4QCP58tEBEdnK MuV1OP0aqxem9GNl9HkQSsV3LuPI7opMOYbUJXuqdjvhWN9UIG8YrO3/HEZ1S/4A3t0914/4y7g6b 1X9LoLwDXHXdggeSFK81VDAVnD8uaImDf1tH06nPdS+EDDHBiMso0rlWPzynJaiVWKoUcNG1RrAuE PsPl5wKUcX5z2a2RcczktTc83UfMWUN0imZkJCPy9NuZgVSsQLtp1US6VXlOj0Y2iqNJYd0O3uRrm 66byqAykzfgIddcH7u/MriOFZvGlgbaOTPFC5v8nYv5wzH7qVUuqfvOQBjNmVm2kZBImEfF9I0tbY HhbLqPOw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1quu6d-00DmuI-Vb; Mon, 23 Oct 2023 12:32:27 +0000 Date: Mon, 23 Oct 2023 13:32:27 +0100 From: Matthew Wilcox To: chengming.zhou@linux.dev Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, pcc@google.com, tytso@mit.edu, maz@kernel.org, ruansy.fnst@fujitsu.com, vishal.moola@gmail.com, lrh2000@pku.edu.cn, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chengming Zhou Subject: Re: [RFC PATCH v2 1/6] slub: Keep track of whether slub is on the per-node partial list Message-ID: References: <20231021144317.3400916-1-chengming.zhou@linux.dev> <20231021144317.3400916-2-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231021144317.3400916-2-chengming.zhou@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5DA96180025 X-Stat-Signature: hxt19diratt3oem81zczp4unwi4qbd4j X-HE-Tag: 1698064380-654590 X-HE-Meta: U2FsdGVkX1+nFn9k2umRdH5JhJnnPysxwjM3a5R1H6fvjnglKybpqdQvnFYv13UIkCt5fdN8JhdBzJZ5PPF24V9n/QBmeB3tOoxY5YbPLMdIsV6ijgwJ1CSXi10EB9Z3zabfH5+e73PEz7taPB9yr7TK4Sc8vuB4GZnHHQ4xa+R7H+p1E8SlRspE4C/WDwF/ZPvQrQ1M4EMd0lgWwSYwPAjJSgFhxokiHRLj2OJ7ELxtlNGNgUj126BdBPgK1ymtmXPf1JloQBK4PYdWZj1cmCkv4+fIo2NRk1UqjhvazFHNCmT26FGs3qz94ifU+VyjgXtub6thp7L97nMGGTFLnJ0a7NwxaExG2egwRO2UChpc6BTi9yVpIasR9B5Yf8hbx7th1B4LIuc2/Y4FYAZO0fQRpRVfyLXmEkd7d9KHTLGDxmr5qtEb9Qu24KRrlpuuDdyNtrgjMQwGXZYL2MVzYFAc2C0HlqODIY7qnSR+LWMZI6cYY2OLbUc281IWvxutXq8JqQF4ubpmMV59HEAOVH1X63WY6On4hi4+eMEauIHfZFF65YLgqhGXj4X9eiXwD3bu+Y1mQR1FCOmgMX0s620vG0zNiBIgwKUTtPT6snrxX4Qqfj3cIFzqT8+pmGp4OzFSbCutgaNcCz62oZcPs3UTl58sCKvvTjrzcOrGRE/iawGZYZsEkAWJQ6gJY+Lycjw/xLQ2IxesVeooxaZQ4bc8RdnHyyIFVDSA6rd9Og7fuTKAWaSKk8LwzoLFOg+gXYjBAuhVHD2GQA0aYUoqd3B4Bl8tuk7M/Fzw033IXFba9OVovXKPjD0gcLFR4rU6yhIPpuFGjd6vZ6LWZs+3eMlGk6QMQjuiD/cDWbb+27/y3yTYTCJpAN0GnssC0tmsxZcd1r4TMRG/NLLLWAIjbeYOW24ULqoKXSYHYQ6LCOLfDX7QoDpqFmYSNCQa2xbgswESebqZMR9J4NK/5Hx HsnAzkK+ SI3S5MTIbBc8EpuEC3Up12TDJ6VqONVHqIn6NqRwk/U6qzYk6ADUaFhLdJuSFrdePkeRFFs/9aXymXOTeqPfVr+Krki2aY9Ko/fZg78A+X7zubw8J/OleXOlOklbW6l3Muhd6laF1ioiYKdVD5BhANoVtBn3bsXzH0EckX0rpG/H4Ep11TVDsX/KVA3eOvHTky+WpEiWWKJhHMd9QCgxqSJgL6O4yPVq1xZI7GzMckS0guzc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 21, 2023 at 02:43:12PM +0000, chengming.zhou@linux.dev wrote: > +++ b/include/linux/page-flags.h > @@ -478,6 +478,8 @@ PAGEFLAG(Active, active, PF_HEAD) __CLEARPAGEFLAG(Active, active, PF_HEAD) > TESTCLEARFLAG(Active, active, PF_HEAD) > PAGEFLAG(Workingset, workingset, PF_HEAD) > TESTCLEARFLAG(Workingset, workingset, PF_HEAD) > + __SETPAGEFLAG(Workingset, workingset, PF_HEAD) > + __CLEARPAGEFLAG(Workingset, workingset, PF_HEAD) This makes me nervous. The __ versions can only be used when there are guaranteed to be no other accesses to the flags. It's never going to be the case that we want code to call __folio_set_workingset(). _Assuming_ that it's safe to use the non-atomic flag setting, I'd rather see this done as ... static inline void slab_set_node_partial(struct slab *slab) { __folio_set_workingset(slab_folio(slab)); __set_bit(PG_workingset, folio_flags(slab_folio(slab), 0)); }