From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16CA7C001E0 for ; Mon, 23 Oct 2023 16:22:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8637D6B00EF; Mon, 23 Oct 2023 12:22:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ECB16B00F4; Mon, 23 Oct 2023 12:22:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B4476B00F5; Mon, 23 Oct 2023 12:22:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5863D6B00EF for ; Mon, 23 Oct 2023 12:22:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 199DD160B29 for ; Mon, 23 Oct 2023 16:22:49 +0000 (UTC) X-FDA: 81377244858.28.B7D0E29 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 720C714000C for ; Mon, 23 Oct 2023 16:22:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=L5HCq7NN; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698078167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OAWjUgVOZUJBsRmzt0lQvrsTEHJrJSHEJguU/ywRNhk=; b=U0A0iV2zTwF1tvb34aXakC98iaayOxo7VMU8Zl6yeaDcF+tBHRYIc3kq6Ipok/XrnyCaJK pPuO0tstS2EvWPFEedqHocYX9CyK1B36DaoQksfIs72T1IcvjYFzRZBzrdDpbTIMngzZ7m mNcoS3O3iZ0b5RPrXEloYsRDbTihdMs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=L5HCq7NN; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698078167; a=rsa-sha256; cv=none; b=IQVbSlI5fBZ5dzBeH3szW9l8e5H4TCKXefBuuC20dOkaV3tkMTyoifjeW6CjVCb3Z4UDFj lHqwlijdzoFCl8wsgUMNC/sG/cOZL772I03Yt+pRYjZaM6861ZT2dN50omQrLOhpQ2NoJ7 Iw2iX3epIYZQxTyAwVlsU4BnLjSBQ0I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OAWjUgVOZUJBsRmzt0lQvrsTEHJrJSHEJguU/ywRNhk=; b=L5HCq7NNjOMdEusQ7GlzvOE8Xi H/lVrBbYxsVVBZuSXVt5DKHMAW/sj7ojqfB+OHF+TWsf/hQPbJMIdBwDkyk+LhG5KwOmoWGpeCjZ5 ogRSsXnZUJkcAKy7tc4s2dKmB+/qHYBvadm0yTs7RCJKeN6wYNj/9zAetlDGscx+/R0T6s8Wa4iAu uUGsBrsrvXPEtffH4z11dgZhe5lZtsJlDhK4P0BKrS8oDHqXJOPgQdWRKa4dml6rzdOg84qyji2nq 178rUeKR+uV9Pz6zXQKVOsiepDj+NKF6zEvXceGDqSINaPr3kKl7Rt5WA5KL2Kkqz3xL1tn9Mda3w q7+gaaaA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1quxgr-00Enmq-PL; Mon, 23 Oct 2023 16:22:05 +0000 Date: Mon, 23 Oct 2023 17:22:05 +0100 From: Matthew Wilcox To: chengming.zhou@linux.dev Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, pcc@google.com, tytso@mit.edu, maz@kernel.org, ruansy.fnst@fujitsu.com, vishal.moola@gmail.com, lrh2000@pku.edu.cn, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chengming Zhou Subject: Re: [RFC PATCH v2 1/6] slub: Keep track of whether slub is on the per-node partial list Message-ID: References: <20231021144317.3400916-1-chengming.zhou@linux.dev> <20231021144317.3400916-2-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 720C714000C X-Stat-Signature: 3hhjq7aw359bdywojdhd1yfi9b9m666j X-HE-Tag: 1698078167-275798 X-HE-Meta: U2FsdGVkX1+KLSQGeALFDC7dyMrEi8/+lG2nhwq61wXaaIElz3c94N9hHbjncr0o3Q9set4CWW/trpSP5d7YYOhAIjQ3IYzyaqvk/YkZtwXan9KVOAKnsLDcXKmDpaqvjYOo8ZoW9HuKv6K/pu5jF2JhZ8cBtztJgCZ1AUBC/nN3rbMdr5ZeODY0S6sb9nMJwPJ+SPeQOIblvLVK8AoL6lmEvSaqW7W2f4yl2vUk9XD/RTBn0Jtllp/Vo2JkVTAZ9u3t0So+dOAfwyR2HcF2vVPKQ+Zu3z3OB6i7Fhv/U8yIswq72CZ1p50HixbUNCtIcJif938BR27QWZLk162hTpoghnDBeleIoeRxGkuDDPI6w5dJQ0IvR/sdg7n5dPHnacxydhb74NSLmeIsClk35ThCjuUa3Zk7fB+o3fgmnBixEW43D9ksWeV/10khr0HvSIkbcsvjZ/BUJcJnQSX1mYNpFPRXenjoX1gjUfJdEbNcOUALPShsPHSUVo5OD1ZrQztEOmYMT5UYHrxUzKFefVOP0FDTbFqlrP4c66AtReIMswrd2kKMbTZNbi2Wby1jAagbvnwRqCXEUt6wSY35qmAjIBAhyEAlG3WP1ElE3S74xAQsckFcANDpB4E0C6FSsBYQwWiPTIujFTu/gFrudMQ/43grDRiNY2yOrcGElZ3FmJQUk/by6yfGZgVvQzHwnfrWdIR8EOcSLvyDgEY3hnOLRPV7Ptl0KabySNSr3MHMN5uqKH5Vba77X7U0VyvwFwAdA0slvExSU4GJZl7t4Ubkw4YLbC5Wz9Aebwuyh/Z5BYX5bQs9s+cgdNFdiPfwNrQtXGQTF7S4Lg/cwxmZ8pGJDiqJmA5DtilWVQawtttUkFxZ86X8C68meq8excZaZNyP0WEnySVOCRUxxQyvNa47GcXdy+DzrJQ9ihOkHxnx+WUlaItIfULXIj16WXogdOdDPpb1ljeK56t2Tp6 pVvqtpIz vwZZuGBeyVNUhv98BRyU6K1ZZuymL+Lx4ELFzXNqhulhJ0KX88gW4yscBO4aCc3QeXvfD1idzFzXQY/N7yDhYA9RiSKOpjo3BuCPq9PkpWUivHPADUqNaqUN3+qP+VcyvZT84x7opgOVnOMwVTWNdKIIhioLdSObYPb79antR0FdRiOr6g86D9aHvNNlfwgFXDZGqndCzCwEUTjD1Hfc0NuUhVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 23, 2023 at 01:32:27PM +0100, Matthew Wilcox wrote: > _Assuming_ that it's safe to use the non-atomic flag setting, I'd > rather see this done as ... > > static inline void slab_set_node_partial(struct slab *slab) > { > __folio_set_workingset(slab_folio(slab)); Ugh, I meant to delete this line. I meant to just write the next line. > __set_bit(PG_workingset, folio_flags(slab_folio(slab), 0)); > }