From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91205C4332F for ; Mon, 30 Oct 2023 20:14:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DA586B027D; Mon, 30 Oct 2023 16:14:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18AB76B0281; Mon, 30 Oct 2023 16:14:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 079CD6B0283; Mon, 30 Oct 2023 16:14:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EC1176B027D for ; Mon, 30 Oct 2023 16:14:50 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BD2F5B5485 for ; Mon, 30 Oct 2023 20:14:50 +0000 (UTC) X-FDA: 81403231140.26.8E1134A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 9E091C000D for ; Mon, 30 Oct 2023 20:14:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fTVlVVAu; spf=pass (imf10.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698696888; a=rsa-sha256; cv=none; b=ZA56YdRDpS7EqtwGd50FGb87RMxos4CN+/mt+q+VEem8mJhXta1SIwdhvatrY4SKNbQfQG g2N8iL/KihDK2rkQz/xaWvBLi2BGncE8u+QEsvXtwYW58vNnhveQ1OIpoegH16UTVt/JJL E6Guibd7zw48pCWuboG1Qwd2Y0+rjYE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fTVlVVAu; spf=pass (imf10.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698696888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zWGfMOu7F7kKUs5HJBbLfJGB4P8zWxfoMGodA/8nKgs=; b=V0yFDFcxh970qk0bgTyiBTVCZcmxiQ34x0mWahnDnSeHR4BsIk+nmi7VDIs4AFpR9JIHbM m72i4WSZzfl37Z9HnuXZnpn4RjvQLP893E6a/QFjaLmOa+jXP6HuRnYQYaFFqLQRh/Yzbu 2/ywC6ty59HCOkm0r5QSlUF8BBQbVUU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698696887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zWGfMOu7F7kKUs5HJBbLfJGB4P8zWxfoMGodA/8nKgs=; b=fTVlVVAuNNv4kZD48yxnADgmhoXd7GmLrKACe5Wqj3LubLfJq+zKtX7BkQfmi3BnPVno4S jY5lUeV0WV81o6OggMMD/YDjc8DX/OX/N9PWIheb+xyEYI06vatK4063ZCxUxcjCHLvjv+ DfVargXw5d8chs0dw49v8Fzcim4fLQM= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-wB5AvPNXMvCvwBCsoifoZA-1; Mon, 30 Oct 2023 16:14:46 -0400 X-MC-Unique: wB5AvPNXMvCvwBCsoifoZA-1 Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-79499607027so438008241.0 for ; Mon, 30 Oct 2023 13:14:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698696886; x=1699301686; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zWGfMOu7F7kKUs5HJBbLfJGB4P8zWxfoMGodA/8nKgs=; b=nEHgA1+aJxxc/lDcrG1G+ijLRObQHVTrhNCmakPIn8a54s0dbjJraDPFUC8tzl1tHe tq5+5NHwK41f7yMJ/1x3ASMy6V2O+RAabQlTPPfjYmhuuZ3BIE5UgvWr35TqHIw9IiM4 CEro5MUiVGS2U2Rwmynyp9Qy70mAQNdi+4SaMyMxKUK260aJuqVd0kTCfhQaHYm0/GVd cMroubINUbwYlrXNkyH3l6akLjdcj1TLj9Rt6aCA681ZLWc6YElZKyMeXoACpmU9OtBP A2QdpkswuQzdDHpNbJPdeya6IaFz5HVzxTrLJ3fZZTJG5oUgGhXShIzCJI6mwab1zCDU X7bQ== X-Gm-Message-State: AOJu0YyosD7DCe1nzPCkjLX4Ocn/sW045rM8CqLb8fidL2vdXlbR+Mj6 ZrdTUU9nTwdjGoxX6yZUKuu8aKPDIWLI4PQhh6RkHVRUCUWy4vXNmPbGvFaw7fkLt0WgWHEyN7t TuPhF79ErWZk= X-Received: by 2002:a05:6102:914:b0:454:7a81:b30a with SMTP id x20-20020a056102091400b004547a81b30amr9263798vsh.0.1698696885456; Mon, 30 Oct 2023 13:14:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpG5KIh6bv0/spHSBWngU4H0SaI7+Bd7c85laDovrwWadeNA9ZKAwXd1Hhen8C8UCCLPNlZQ== X-Received: by 2002:a05:6102:914:b0:454:7a81:b30a with SMTP id x20-20020a056102091400b004547a81b30amr9263776vsh.0.1698696885190; Mon, 30 Oct 2023 13:14:45 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id z11-20020a0cfc0b000000b006564afc5908sm3707026qvo.111.2023.10.30.13.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 13:14:44 -0700 (PDT) Date: Mon, 30 Oct 2023 16:14:42 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, david@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v4 3/5] selftests/mm: call uffd_test_ctx_clear at the end of the test Message-ID: References: <20231028003819.652322-1-surenb@google.com> <20231028003819.652322-4-surenb@google.com> MIME-Version: 1.0 In-Reply-To: <20231028003819.652322-4-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9E091C000D X-Stat-Signature: kjm8ahgoak83gg1n6fuwjhan4pt1w8kx X-Rspam-User: X-HE-Tag: 1698696888-822553 X-HE-Meta: U2FsdGVkX18mLV1laxmyJ9Q4zU+OD5ZYc/zvk94MlPrU7et1g8sX5Yyfp9A6p+yV6VOaMkuWOMEl4w36jefc7baq1yCaHlgdbGR2zL2YLa5lQSMV5YRwhTFmmcGDHVYXgAANBwqLPwCg1LxrGf672E0bftQTOS0ahsLVwGSHNBIVeprFXza+uCT2lEOpLSc3hIAbgQzfmXVWLmpMHURW3PTf5X3ZF000Od3eR8IjKSTXL4X/SLPI+1LFPn1GCl1nX1tMQPY+WKekyXZMvYOFD/ojoDJLASHVKmvAnSiM2gVJDqAZsWg14XP+uaB6kA8a8kXBuCeURR7y3biTKAeLS+NDoFfdr8TZeo9DWUUS0Op0OkDlRtj9CfaDllutveNNtTgETuO9zXMlxTExN5LqH41UZnt7oxLNpEzCl+DqtDEOhzn9oWNf7x76YpZZwWMKpocPdHi6+FHa4vRgpz04WOWaOINtD9FLfoD8EBUE149sNTDlXscXK3N0Uzzf4vJBhA7ykWz3gj4LA3pR9KMCsqLPX5vv7DEkFNG0Ghs7y6NLzZchcfjndSMwr1PO5OA8Tw2LjsiM0eYHVFgwKrWR8QBbSPQp6TLpYaVSrzBIqtgv1wekQHoaVdJcHvVLGy5ll/xR5E/CuKN4XJn2GJWkPk3oF98/txQxep+MhORFCeKrYStvaPi+XD/KVifvOmMDQpeusyS5vHreD5MvzRPmgipkgdvBaDn/vlmpR40MqN8uWrog83h12UsLCf3bbxXY68WACc1vdOk3RIM3+YXdSM+B6OSamlPd6AE4XMFH7nOc7At3dsQwhcHcWQYMlvKtSpJg5PYfP2bJDvPeBk89/T4of8Cwc0Sz5T9rphJqlCtTl60Gsyv0cscfLmAcXnPr0twGlhT6NMQUno+E3/epGu3ipCVhFwkqOTogaCn/WkTI2CPRRlYscNiiqzdH0VqCpxJocYDcFtoigLLHlUU srx6okzR 2on5luA08+14keTA313+ANXcQIygEn29EejBCo0gL0dzX4Ya3jBp+4jcKDEo3z+BNoSWyj2VNZbEgLHs19vnzb0PIn5qxklqGV00tAOC74wXk1UJxhwYJrK56vu3Qykgl4GiqMoAZJ7l/pW1QuQwduEDdQgrWAMg5ledhtRb1qp4SARMjPb19BK8DKEijD/Gmyw/kqmf0E64B1e70nGlZKJ5kpA82WaqKHraxyPhaLs72QV+D6iwXAkRzzarAMZQWNB9QyYhP0KjZay9/qhbBeAadVhl9OVo2LRgg75jENjW5Yp+MDGQaNyNH9jeqdWLDB6aO9AQRKVEY1eeljxOlNcjE7FiHXhUETwSOPPeWRkS7u1rBc1JhYYIPB+CHNMTdPK5IJDEEkqffC6VlblnCnYWYwavBAA6/c4zQyjNL22fQNfvZwFbGwaOBg1rqXc+dSjVGWSNkNuaib2gvPLB4e6wutOaQrICwlNxUn0eg1glZ6ZXDC/hAwkoDJtJt7esiT1rBURHFpeUa7yU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000052, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 27, 2023 at 05:38:13PM -0700, Suren Baghdasaryan wrote: > uffd_test_ctx_clear() is being called from uffd_test_ctx_init() to unmap > areas used in the previous test run. This approach is problematic because > while unmapping areas uffd_test_ctx_clear() uses page_size and nr_pages > which might differ from one test run to another. > Fix this by calling uffd_test_ctx_clear() after each test is done. > > Signed-off-by: Suren Baghdasaryan Reviewed-by: Peter Xu -- Peter Xu