From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00CDBC4332F for ; Mon, 30 Oct 2023 22:07:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 870186B028E; Mon, 30 Oct 2023 18:07:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 848216B0290; Mon, 30 Oct 2023 18:07:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 736C06B0292; Mon, 30 Oct 2023 18:07:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 62F696B028E for ; Mon, 30 Oct 2023 18:07:35 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 35491160884 for ; Mon, 30 Oct 2023 22:07:35 +0000 (UTC) X-FDA: 81403515270.20.44971C4 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf15.hostedemail.com (Postfix) with ESMTP id 7B9A0A000F for ; Mon, 30 Oct 2023 22:07:33 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dWd8Hs7D; spf=pass (imf15.hostedemail.com: domain of 3JClAZQYKCKcZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3JClAZQYKCKcZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698703653; a=rsa-sha256; cv=none; b=wbcGdi42wInwEnp4XXiM3T+7yOHLWnxi5UKcbEtyegOlF+pG51lezQ93UcD+25ZM2A+QSl zG8fLvPq0h8BCd+tDEVVxDrJLoGU67HPoNApb+7K8uj4lue4eL511mZD32/ltVnn5BCLtz 7OMSyboQ4m7skKVINlZr+RIqzNVXYj0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dWd8Hs7D; spf=pass (imf15.hostedemail.com: domain of 3JClAZQYKCKcZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3JClAZQYKCKcZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698703653; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=m44+fdWGrujwl9p3oX0jHICffBx88ggoTXTgkkSHsMNd9CUgF1au+5Y5fLEQ1atf8SiHBI 0m54yHFws5Itv5akfEkMWdQSbMTZ9Dgf3awxkauv4YIjlf4FL4XUhhbQG494Suy9ZZXk0f w1PU9EyVg26PGTekOG96wSQkt9GhhiM= Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-1cc29f3afe0so20432085ad.2 for ; Mon, 30 Oct 2023 15:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698703652; x=1699308452; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=dWd8Hs7DWJQ3cmw7/CV9WTIwOU4gYb0hL3Qd5Rn3VYufis8+7CWJy4AOlaM+fdZ5Vl mSuwXz0UBw3f8iRP+3E/9uNHAl7RQiT1WQaCYq/l6FZoubx89yAQBk90XPGtqorKnKDF EiPYQcjKaGujymoipktqGDB2SkIXZuSlJT9OYFRRBg1CunYy1/cFWj5/xFYlXodFm6MU Haq1G2PkNLuoyOxd9I4oRtnKOFHlSWZ4KACAsOj4XMoeP8l1mK7iiTIwgsW5zPuZpSL/ dzG1a+jNPALHO4Wpdo7DsNoSycB5CIR680kLe1IdTb+uemD1rsf0EgBX9quvVMy/uOeI awQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698703652; x=1699308452; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=aOpin0xKhiOtnXyMukjTqmrYkpVgLydvyTkKs0qSpcf8oUCoG2oQV2Y6szMt6dZCAs Uf2apLAxMUMPo0MNFaNm6PsVmgP47xpaWkPuhyUxZYfiCnhAUjTzma4pfTgx25+ZvY34 2Xp3zoqiFVBWBoQxPs+RJxwkoZqu4B8KU0kA13pbkwgGCMfzgzOLzDfCHyvC5bUDJP2M zdVmQZ7KyBkqWNCOmnXJcwnQUg7kRstJfE/oWwCi+o4/XU//YrxcAggrLLyTi+42RYPL n0iVWkMYrKg7le35qMmfyKdKWmOGDmDM9g61BZkyYuLASUUl3qH62PIp6zRHXQ92NSUg NgEw== X-Gm-Message-State: AOJu0Yyx4gBxDqS4g/frM+9PB1rnJnE+UqIA/1aFfX6ijAVETSNfGdiE 4yCA3F9Kw3ROBRd4FIJoen+0u6j6fY8= X-Google-Smtp-Source: AGHT+IHfmttfYISWufdVkZGI1GGv3oPE0CaVU/9uw2yWegmaBLqLOedbYI1/usu4SKmN8TEK3NCdArCTZyE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:ed45:b0:1cc:533e:f52b with SMTP id y5-20020a170902ed4500b001cc533ef52bmr49726plb.4.1698703652255; Mon, 30 Oct 2023 15:07:32 -0700 (PDT) Date: Mon, 30 Oct 2023 15:07:30 -0700 In-Reply-To: <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Message-ID: Subject: Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7B9A0A000F X-Stat-Signature: tn81x5rapddz8en9ecwkuyr7c5sr9dse X-Rspam-User: X-HE-Tag: 1698703653-207846 X-HE-Meta: U2FsdGVkX19y9mNfTdyUHkNIkx0mkyscqI1EVQX4264biXhWdTmm8QG6MXCN1afF9tSioRkdDxcy0RvYbFAh62aByfMrdhZ2Qv6Pz+BP0TZhfCtIWqOwXQXSogvYuVRRj9Ja0bQJH4cxAAsgVgTaQfF/wrkekhsEFlzRnTeXDi+9ZR9cvofTDBYiV1+fG3ZRWmT0oXxRvYO3KJVsK5WaPxC+kOBmC7z8DvIpultB6vCURBVeWaY9NAYeDl0AolXx6TJWrwk3Bl3uSFNM3X1/I+cW659+guGri1txQnPu+PA8YC5UX+B4CnuBnAaA0gB8V0Z89wsbxcMv2xuC819WP1pGwTOi0sYuGexbkVbJYjCpyHMrBPDKavF0iSIV3iJ4yRkKdUOp1D74UQpwVlirxHD/XW/WdJtlEk/Pbup+TU+Y/Kkc3UjNynJObjHgUyVVoLK2TSAmjxhALyQ6EdcWLLDIxDsSZoZeejaOzuuJoAk4FOjwsdbY5u2wMDlfLQOg2SVLYQe6rXmFi0pP29PJ1hxWTXxrWpnDi7acqvQKFR6XrPsFl61ocgpwKPRj/kxCHMrTv89rf9BIqxd/nZWP9pgKNaooVD+Xul4wzPjPF7RUvL0uBTWs97moBwgrzc1fDJca3t6Uk+TV7bogNTXRN+kjsbd8mCUqMSTG/ejY7lmjndQuWWylz/3vlCxHxctDiwPIxlRpsY9wTcHL7pXsN1EufPud+6SOkxWRW8m2RwHuRZ5QOiv+rjWroIzjYuft5R2yvVN/wcjVsdsQavHG+4ezHfLQ+hdQEmX+DUeCmgXdwKVYLhvRxzCfQAlEsCt1WTBSyHPGibOMqrlFCLCHU1RSAtPKqVUxHsQ6HMWstP6xM9bOL1FdxhUPYFb0FM4V+9TGBCu20lyaQCD9daEFjBLDp1HfQ7Zu6MrK0Z9LkQtE9Azk2RD6d76KdLztjUadzC3El6XcDjguRVESGA5 7K7QV0vh Rh5zACPPF1e/+g4uLV+Ri4+swo58kbBAj8LKXoLTxKvrskujizV4153B1ONQ0tA+1dbuejgDM5NFh+a+emtcWwzmJuMCouUn7/Y/MY3TCPg+V562G3BnqDSM8aBJ0N4JjKZpJ990kYckSxnYqc7iP5LUOZstXLghtsU3PHpjAuD04OxSpFMttYr2p5zaNrnE2oRKzWSgSsowl5Uyh7XXmwoeaPUT4MQp4zY+2uoRaKo5oTL7roEUARuHzKzrYhQ7zP/+lM2Q/OqW3g+gJgwE8p3WIHsEkC7VTwjweZMS/xaMzNYO23Gx4ie7SnMDwt8g3qA0lqo3D7FnP0L9SLvzqkhrXmRV2PB05fMNECQSOqPObucUnlr3HXGTsPtntHNvLSJNa1NOompPK1V1nPZUEa2H+oFkqaPtzC/xngXzCilK46CC/PQBRB30kBJFYqN9RIIiXyZJhSdcOT88NfC8ftNpVwqjIYkFMeXmMyF+UzUIaCmpLP1So8m3BqWdvuYVa5FwBxQ+xxfJ2oAOF8epUgWeDMyq/DGKDc8twMZs0Xh/UsHnZsFZc7B/aIKHU2YVnVb4QL153kNxKiDObBLE8wiJUlVasmNRvYH+cAbrsaMMlltb2C1cUjUyMCEn4ZNjKtHjXhfyJlDl56HVnhHGJcMqRClXDcb6t+g8GVrGNsrVW9cDXGEpBzMKwG5Oc6pkZ1DR+dkvzVmXE+qo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 30, 2023, Paolo Bonzini wrote: > On 10/27/23 20:21, Sean Christopherson wrote: > > @@ -635,6 +635,13 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > > * the second or later invocation of the handler). > > */ > > gfn_range.arg = range->arg; > > + > > + /* > > + * HVA-based notifications aren't relevant to private > > + * mappings as they don't have a userspace mapping. > > It's confusing who "they" is. Maybe > > * HVA-based notifications provide a userspace address, > * and as such are only relevant for shared mappings. Works for me.