From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 519D0C4332F for ; Tue, 31 Oct 2023 14:16:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB7346B0318; Tue, 31 Oct 2023 10:16:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3FCF6B0319; Tue, 31 Oct 2023 10:16:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE0276B031A; Tue, 31 Oct 2023 10:16:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AC8076B0318 for ; Tue, 31 Oct 2023 10:16:20 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6A395160626 for ; Tue, 31 Oct 2023 14:16:20 +0000 (UTC) X-FDA: 81405956520.07.A917B01 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf08.hostedemail.com (Postfix) with ESMTP id 8BDB0160030 for ; Tue, 31 Oct 2023 14:16:18 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vFUI8NSr; spf=pass (imf08.hostedemail.com: domain of 3MQxBZQYKCH4ugcpleiqqing.eqonkpwz-oomxcem.qti@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3MQxBZQYKCH4ugcpleiqqing.eqonkpwz-oomxcem.qti@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698761778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+SCWDVcx1K76tZHWI6JguONJ6NnGeKLP7+QbYfrb3Rs=; b=nczWrxMjw+G8HTTGCDRYqWWnCM0iE6/M25r8EdFe1hK/sNyhV1QbKYFT6NlDPmrctBeCXQ /1xfbJcdCy6QImk1z8npG2kkeUmuc/0OgvinE0Q6KD/MphTv4Y5MTxoQdFQI3rV58b/8Gz WCzpMSDuek9yZn6ThCn7jF07ffuMxgg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698761778; a=rsa-sha256; cv=none; b=hjE49EoVl5tMDblWr1FJf/q/HVHDJb3g4H+fTSpM/ePC1vB4azr1tSogB1Rr1pUE493lUn TazbXz8qM8F/FfrAKqXbp7MjS/pqBeyZHdIo+m9xXvK9m/pg1A6LOox4H1QTa4VGXCwj75 5QJGigzoK1gOPJwNT5aIdLERqPsy0+M= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vFUI8NSr; spf=pass (imf08.hostedemail.com: domain of 3MQxBZQYKCH4ugcpleiqqing.eqonkpwz-oomxcem.qti@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3MQxBZQYKCH4ugcpleiqqing.eqonkpwz-oomxcem.qti@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-1cc591d8177so15197465ad.3 for ; Tue, 31 Oct 2023 07:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698761777; x=1699366577; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=+SCWDVcx1K76tZHWI6JguONJ6NnGeKLP7+QbYfrb3Rs=; b=vFUI8NSruUBncdgZRKOqZOVQWX5k5DBaVcCl/nRoG61yfY6NCKikx3myacYnN/eX/F vFyAIyz7VbVbAoT5ka38G1xX6x/z9z/onJ73FoCH5/dSCzErCWqF612OCtnOQhkfe9bY bS7Z9CtW/t2tjblf4j5E9wCaIX/RaTkcPczmD2imDOVCNgnn8jUpfP5p+S7SFtSi1iUb Lg7D85Zct2VgeWf39g7qL5WLpAHuEifS/OEjt1ctZO8FtHagp9gQsygdxRQ9BwlnrBeI qWWfgiOU+sP1B21RfV2jK86DN65DJLT8CyuRciZbUyGRvv8r1vD58NfHJBvvooMfWTMT FfAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698761777; x=1699366577; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+SCWDVcx1K76tZHWI6JguONJ6NnGeKLP7+QbYfrb3Rs=; b=fMhQ37ednjrvMG6lRjw/E8H3JB8l6nTIoHf7m0sPvCxghbFTZrYmqorQ1cSI9f/wY0 nJQYTePHOKPorV+FrhyrIIkj2ej1CtGHLINc+4in8x393QoGKJsIg7pQ7OKekmTTUhJB dKGiMw/lg0TgA122D2FZcOXw7FfuCN3hDL4VCi5ZUBJReMUo08lKN92iH+So5WsJTTtS RnfGE3XREuHRwmi5htRbzES7pw17QIxv3BZ8KzNZfrGuiTZmxYqafPjxlE2y8G1+jTNI PR/isOlyTi3vcHwKAjBeUYwqFZNP01UwIE9LE40hlTyaMJlrIz8rAEqV5Lwzas1GksaS XDvQ== X-Gm-Message-State: AOJu0YynWVuuxDNUVsQkjCqwi3XS0/tq8663bZZTiapEbbW3u33xfUa+ Ww/sOy6P3oRBa70jBAKHpgdMmEVNNIs= X-Google-Smtp-Source: AGHT+IG8tFKfIuO6cbI6ukftnUzYB8muWE8fOHZgWpajrHJaT+RkL+zDaTOo8ZNIlEatfvapWXD9jFRr58g= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:903:2616:b0:1cc:2549:c281 with SMTP id jd22-20020a170903261600b001cc2549c281mr206233plb.13.1698761777291; Tue, 31 Oct 2023 07:16:17 -0700 (PDT) Date: Tue, 31 Oct 2023 07:16:15 -0700 In-Reply-To: <7c0844d8-6f97-4904-a140-abeabeb552c1@intel.com> Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-18-seanjc@google.com> <7c0844d8-6f97-4904-a140-abeabeb552c1@intel.com> Message-ID: Subject: Re: [PATCH v13 17/35] KVM: Add transparent hugepage support for dedicated guest memory From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 8BDB0160030 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: cy1q4t1h3tbwmg1kxfn55pyspckuk66w X-HE-Tag: 1698761778-895230 X-HE-Meta: U2FsdGVkX1/mra+aMFDqj7tLIgMTrOvZsMd+tOSmbvG23BMx5f+Tfm6vxaUZ5eTahHKBGVUDzANvP6Mb2Et59995kXubowcNQECNtZ9ly2yXqKR5xJ2muIva7csdnNMC8lH3b4KIx9543YtDjtmmzMR3a3w9ncOGpfCeOufBeeWrUNzzoIH1SYv2ctCUn4xGaRnShbxebZhtcYpaQhlSPfHjISUsU94uKYcxpjThp2Ew+7vm9/Albo+3oAUxBWP451LBXsFJPD+nES8dRm8/5uVHBCDv8Iu479+Zv9l8Oj5r5MdITYbya+Cv0VWFh+sH/3AqSEU3V11+ztdI1kdajd2rW/GKptgzLHvp1tyw19BeVjwBlNDHTr69Sa+DtfqCiSnC/ShOb2xUMwaoS/pSddPoos1kAZrQVAv4M9BEreW9mF9VZOVaQJfwc1nqBC8t9w7ClyZ7eSLqeI360NAOFtQL3OPdZ0/BhzIBjAzknyYEv6PALNetdFJtIozFVEaBbLFP4Q9qhfrOz/xeYbZm2nmzE2zhqVuxwv3n6LbKp93M8XzPLhFN5KgBEpLOnIgNm2qOOnT4lj3TC36e/7dNMu0ZIGrinYkZxy2Qgo64sFgjLuPpwqw9NMi3mD2SRVdbPE+ig9uNhQ9Z0zn9D0bWTEblzvAItAkwBoeOHUBbB8tATpaJF1xie4yNhb5xmkTLn1Z/Q8UpbO2RrTmHtaKdGuDMUlmQhfW9esuXUtoOElw4IhYPnAy7bxP4YOqB60p+20xxCztBe6cvgtUbW/LYcsgx6YheXc/xbJI5UUBtW+7ZLWBrfBFOXWM1sdbA9Z3kpZKlnNFjBdUqYgEEy3USGP6msuc3UPuBjPS9AScuwYSbO/R9TYTWxCHTliBpgbXZoirHrin+tUBjvzF/zqweGgxLSS7vfBkEvNZtHPJAoPwLb9QOMd62bhCSs2rFD3f+q3jyYaVAPGpjMifDnxh NC5AufgE GT2YLUjtZWCr/XWlcLDSG1oHDu2Y3DRz0oVTJskM36PJRD4TTjoOVoMpsUWUiMyzYGjBrH9kYP7HDsEal3j4RfHZx5pOoJ6AtGQqYvrIKD2kl4783K6jKQoxTOr5IxxDD7k4RCk1gp/ASAqAVSdn0W1bKCc12a38Fm90kNB7qLABl286l+bBJsDT5CbJ1HYB2kqC6F1CcVxSthquCKcz8uQq2LxMxLf7iT+pZ/rOSKqKA7vV/pD4E5OBB+ojnK9deg7YTa0SGx1a29eoZfBnkOszw/EL+cqDx66T9BtsGr52FH9X/QDD4KPeL4mNQHDmsVI3hBZHZXCIUp7KaqTTAwYTAsrT3Lh7LWUPjVRnd6dq2darIyo68ZiDQQMG0qbdcIbpPvhqf+asUxsWk1vMmYN8pQh7+dIWeTkWxGKF5ZbYHjYhK2sH8NcCddyUP0Oj+aR/NVEURbgqoh3E454phjIvvT2/2QNCQNKy+wTy47yJ9iYRK1Se8mKKqV9Xz21LAwcFzOaX/m9yhUIDSGngXrOiceUJ5PnxtiCzq2sT6y5zzM6iOoP3AyfPdJLAb6EQDzTCYmU3AlfVfEhyDWti2T+jv2nHwgzMXQmSadbiQZdx/oD1js8xJRji+C9nb8e+k07KCJCm1YRc6N1l+9/Bkqy8lLajArXSNMz9JdGHqAdPafabeQmyt+RxsmFoZQHRlBg49BxR7CPrBJAQjeBIoHVGw4t/mu26MBrdz8fooPkIMiNE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 31, 2023, Xiaoyao Li wrote: > On 10/28/2023 2:21 AM, Sean Christopherson wrote: > > Extended guest_memfd to allow backing guest memory with transparent > > hugepages. Require userspace to opt-in via a flag even though there's no > > known/anticipated use case for forcing small pages as THP is optional, > > i.e. to avoid ending up in a situation where userspace is unaware that > > KVM can't provide hugepages. > > Personally, it seems not so "transparent" if requiring userspace to opt-in. > > People need to 1) check if the kernel built with TRANSPARENT_HUGEPAGE > support, or check is the sysfs of transparent hugepage exists; 2)get the > maximum support hugepage size 3) ensure the size satisfies the alignment; > before opt-in it. > > Even simpler, userspace can blindly try to create guest memfd with > transparent hugapage flag. If getting error, fallback to create without the > transparent hugepage flag. > > However, it doesn't look transparent to me. The "transparent" part is referring to the underlying kernel mechanism, it's not saying anything about the API. The "transparent" part of THP is that the kernel doesn't guarantee hugepages, i.e. whether or not hugepages are actually used is (mostly) transparent to userspace. Paolo also isn't the biggest fan[*], but there are also downsides to always allowing hugepages, e.g. silent failure due to lack of THP or unaligned size, and there's precedent in the form of MADV_HUGEPAGE. [*] https://lore.kernel.org/all/84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com