From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26232C4332F for ; Thu, 2 Nov 2023 15:44:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B42608D0091; Thu, 2 Nov 2023 11:44:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF27D8D000F; Thu, 2 Nov 2023 11:44:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 996138D0091; Thu, 2 Nov 2023 11:44:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8C0E68D000F for ; Thu, 2 Nov 2023 11:44:56 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 63B8C40173 for ; Thu, 2 Nov 2023 15:44:56 +0000 (UTC) X-FDA: 81413437392.20.644FB45 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf07.hostedemail.com (Postfix) with ESMTP id A0B314000E for ; Thu, 2 Nov 2023 15:44:54 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hX53V+81; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of 39cNDZQYKCLwugcpleiqqing.eqonkpwz-oomxcem.qti@flex--seanjc.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=39cNDZQYKCLwugcpleiqqing.eqonkpwz-oomxcem.qti@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698939894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MWop9ChiDn+5U1d7ZFSKgT7XQaKJkOCdphsca+5hdRc=; b=X0dLgoF31kVT/CEW95Kf4XSbR26tSW8sIbqrSv3DjYTBLxX60pfKP+YfNjsb9Up01U4SyV EEpQkGNmj2Nn7SLfraUZ6chw3o7vJMpPFfPq9WWdKIgowSR7KVsPpIe+hElNqlEEvEUwNz aZlgCw6VF+1+HGPwHh45DAUcb6cevqY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hX53V+81; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of 39cNDZQYKCLwugcpleiqqing.eqonkpwz-oomxcem.qti@flex--seanjc.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=39cNDZQYKCLwugcpleiqqing.eqonkpwz-oomxcem.qti@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698939894; a=rsa-sha256; cv=none; b=e1/K24+ewpTV9M94clUML15G+g+GQfuUoANy88T9mWWFGim/9NTOzMn2v9A5BO/5Xwqjeq I6c3Kss75u66re796m5/27tgcQ17qrkcp5/ExP0CwO29sgXaSMuzIk5hxteNaW9bd3s673 xf0GrKkiCbRHsvpIAX4mdpqy7M/t/Nk= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5b064442464so15880797b3.3 for ; Thu, 02 Nov 2023 08:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698939894; x=1699544694; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MWop9ChiDn+5U1d7ZFSKgT7XQaKJkOCdphsca+5hdRc=; b=hX53V+813d0TXPwTDN5oO/NSHRTIqVCQHBMsalmsTz4WEGBvlfwn61rUH+FzmoaB6I i2aDMDwgW+wwE82/0ZSAxbHzOUzU5jW1fbYBaaHlp8m4XoKcPWQCWp/Mx6ACznQwiq3B Dfi3y6lMns1Mh7wwATvwMz12rp/Ojo4CQWQ/KEitIt6fDVPLRZWB2VWq4VxCmm+8ZqRh WgobaADROPTgSfp9PPk1fiW/BGkaCz4dyU51/IZwGnPNtrr4nseckfOXsOOP1ytd7Z3/ /yujPQTv+1Dk2hcFfWhuLCA+RHG+hHrszh5jXRxMdSWzQsFqFUUcw+hJSdt18z9hsBiD P3Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698939894; x=1699544694; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MWop9ChiDn+5U1d7ZFSKgT7XQaKJkOCdphsca+5hdRc=; b=wbfHILQB+ZzPZOP2P+hfdvFObHv2ioUDSuPVz7tWvKe0M4wdeUsbxWz4j4rZdJUxpE +yvml7LD5Jxioc9xCPZWolmoQOPwAFJmowslHUpYsTRhd7zHK4FlijmHiTAcJ2gY2Q5l F/duaJ4pEss4FGcsHszJMtrKOjxu45F0jsL2XsZJSPT6GMSReFOXm3/hr8rNYy1JtEVf OIBdRwpvp+WfYTl8gV6kDo7Vp/xz6o1FIIWnIZw1cM2c2oFC5oinRprQkrUYUiVZxuun Z1MUwP087k2nF//C/5YxiwN2h7vRMEghm935GVN4QP+S3kPA4qGBFwH9z39DDx41FPcv bt3Q== X-Gm-Message-State: AOJu0YxAo2vsM28sg70o0fXbHsAHaTgP8Tbrwg9J2emDuYb1HWCoboDz PirUHBBo+JeEsCAtRClbEGuH/vbar1c= X-Google-Smtp-Source: AGHT+IEDx2fXN1mZpC4wdLenC0gEZqGHeyYGeZi/NHNboFx849UKp0hRFulm5OGynaHR+kwHxlTzuAC9hXU= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:d785:0:b0:59b:c811:a709 with SMTP id z127-20020a0dd785000000b0059bc811a709mr3270ywd.0.1698939893755; Thu, 02 Nov 2023 08:44:53 -0700 (PDT) Date: Thu, 2 Nov 2023 08:44:52 -0700 In-Reply-To: <496b78bb-ad12-4eed-a62c-8c2fd725ec61@redhat.com> Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-10-seanjc@google.com> <482bfea6f54ea1bb7d1ad75e03541d0ba0e5be6f.camel@intel.com> <64e3764e36ba7a00d94cc7db1dea1ef06b620aaf.camel@intel.com> <32cb71700aedcbd1f65276cf44a601760ffc364b.camel@intel.com> <496b78bb-ad12-4eed-a62c-8c2fd725ec61@redhat.com> Message-ID: Subject: Re: [PATCH v13 09/35] KVM: Add KVM_EXIT_MEMORY_FAULT exit to report faults to userspace From: Sean Christopherson To: Paolo Bonzini Cc: Kai Huang , Xiaoyao Li , "kvm-riscv@lists.infradead.org" , "mic@digikod.net" , "liam.merwick@oracle.com" , "kvm@vger.kernel.org" , Isaku Yamahata , "viro@zeniv.linux.org.uk" , "kirill.shutemov@linux.intel.com" , "david@redhat.com" , "linux-mips@vger.kernel.org" , "amoorthy@google.com" , "linuxppc-dev@lists.ozlabs.org" , "tabba@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "oliver.upton@linux.dev" , "michael.roth@amd.com" , "chao.p.peng@linux.intel.com" , "palmer@dabbelt.com" , "chenhuacai@kernel.org" , "aou@eecs.berkeley.edu" , "mpe@ellerman.id.au" , Vishal Annapurve , "vbabka@suse.cz" , "mail@maciej.szmigiero.name" , "linux-riscv@lists.infradead.org" , "maz@kernel.org" , "willy@infradead.org" , "dmatlack@google.com" , "anup@brainfault.org" , "yu.c.zhang@linux.intel.com" , Yilun Xu , "qperret@google.com" , "brauner@kernel.org" , "isaku.yamahata@gmail.com" , "ackerleytng@google.com" , "jarkko@kernel.org" , "paul.walmsley@sifive.com" , "linux-arm-kernel@lists.infradead.org" , "linux-mm@kvack.org" , Wei W Wang , "akpm@linux-foundation.org" Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: A0B314000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: q3ojwyj9w7upoajcneh7xiucyk4bqcng X-HE-Tag: 1698939894-821633 X-HE-Meta: U2FsdGVkX18+XDDQTE4EbSZ590dechR4KytWWLDnu1sxBODTfLeox6280XRE/rdKg9t/d0ioUMu74/qtD0WOC/rI6DYs0cMCZ90blixCasox+dZu7G5B37KRh69/7odH3nuS336RLgdsA7ObjwZUOhL4byD0+ci6j/le2pDBtJfleTiCLgMHOJAlh/Eljr7KbM/cJrMXs9wF2lV8w/wahIvypgeRL4bYyf2Xl0X4FDyKtJoq/3R/7w3vXZFWCqTaiLnMz10nmkjXVf1O2VNym+2yKNuBJRF+lPH1A18ibyjPrhVIkW4t5u26KdsPMf+5YxdeZzhS3mgy7I6/K1BFHDVQAE7aqX6Fa7jZ9/vG4HQW8E9TEqTK/sftSqupKagjSGjMTEKD4Gmm3dHq0aZkYrFG99KH+hYgeGWEOFJwZsbcIQbf/9JRqgYo1/m53GXzEk8zXcmSWiQJY6JEPG6+E4p8vpBb3TJ0TtCYgcT7/x3Q31RjVKfoidW0IE2xIlxGduYQyY0l3jCUxScmqjEMva2SmJpofeftRXVvdBc7C//CPymPX3awMStiW96cS7LcyGEuMylaXug2hPNcJ6I1VxsGOdcTJ8i5mhmTJssw84wyS5pKMhu8dcAnXHYbXp5thrKVzLeYLcCFJfTVrrt02QEh0NIuFukL95vPEdfqBf+Bko0A1zlw39nHV236Exn39OTCo6tJURvnzDCf5KPXml2fq62Heyqw0SJNm4HyPUVIcgtrrsa+kiK200vWQu343QLV2ugeTZ3n8xhpQcwEBbHr3sGMA+1VJmVTnihinOttsHju04rnb+iWUyObJFzufkZo3dfsFkJXrA6m9B5+MNFeujMZRJ6y4E1R2+mIlDbKEtNiWFvXVmZaUzNoeRTKZdQYdrPWZ8dT5eoBVKxth1JZxT+fznl7AfWRTwALTnHIau3ioEh4LHNNRv/5tASgVYJepQZ6+xI3MgsmMcS ih23b8Js KQ2IV8kQ4/hMKefe2uzhEfGfLbvKY1N6DUz2wcoMmlGa/L/O5me1XYE0dATRRYKS59QZukXy62GN97eclxw0Pn8WPH47rVcqm5LpujRCI5x0OX5k4UUfCSxahaX0oA9H7I9tgp3Z5vMctLC5KEtrzt/iAhEy9TT4+2SXHMosTQf5NRh8aXLJPkqkulsBrw+TRbd+ixPAkHMKUfI0in60xrN3vQMQyFuwIzp/cPYo5cK8CRdgM3CRBEaV+Q7WBIqsKjxwaawH7CMbUtUDcVUFk1Gj36B3SGOfW78fkSlncCYTmxRWBBpqNfOkLgUzrDHU5Rjy+m6t/9A7TcK8snIzgiRd+tdlKnC/Con1+C/3CHqOXU4+ZZUek7Lu3TaqJ8R9iUP+YpViQt5BjbszEiBP7LEr3SfOeEKfFDJR+NLiyDQlr704ytQDfcWWHoWgR0xjo8mBfuIFU7oc3EF5Nr8iSeyEG4ywbZKCLpAd9xELNT80IJAdopOGwQ8fe06XnmXkYAMCyjye9dRGaRB2v96QZOMogFu3HxQitr3h7xnPEtcozMZbAlD0iqpZ+gnpi/kU8a04yC1sMgI9qIpwvYB891189LFkVCoHcKOVry0jJWIjpfdIAfMbdw7qnyxOJI4ZKelOUJhDAsYZexRIY5lZtvSgecq8TU9barQUxv7ELVCeV6RpZzBcCos5OHrTiRyI4vmCUjfhimEdLFrGDLMWnoHoqyFhFw7hm1C6HjvFMNbupUv6lKwAEoYMBSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 02, 2023, Paolo Bonzini wrote: > On 11/2/23 10:35, Huang, Kai wrote: > > IIUC KVM can already handle the case of poisoned > > page by sending signal to user app: > > > > static int kvm_handle_error_pfn(struct kvm_vcpu *vcpu, struct > > kvm_page_fault *fault) { > > ... > > > > if (fault->pfn == KVM_PFN_ERR_HWPOISON) { > > kvm_send_hwpoison_signal(fault->slot, fault->gfn); No, this doesn't work, because that signals the host virtual address unsigned long hva = gfn_to_hva_memslot(slot, gfn); send_sig_mceerr(BUS_MCEERR_AR, (void __user *)hva, PAGE_SHIFT, current); which is the *shared* page. > > return RET_PF_RETRY; > > } > > } > > EHWPOISON is not implemented by this series, so it should be left out of the > documentation. EHWPOISON *is* implemented. kvm_gmem_get_pfn() returns -EWPOISON as appropriate, and kvm_faultin_pfn() returns that directly without going through kvm_handle_error_pfn(). kvm_faultin_pfn_private() | |-> kvm_gmem_get_pfn() | |-> if (folio_test_hwpoison(folio)) { r = -EHWPOISON; goto out_unlock; } | |-> r = kvm_gmem_get_pfn(vcpu->kvm, fault->slot, fault->gfn, &fault->pfn, &max_order); if (r) { kvm_mmu_prepare_memory_fault_exit(vcpu, fault); return r; } | |-> ret = __kvm_faultin_pfn(vcpu, fault); if (ret != RET_PF_CONTINUE) return ret; if (unlikely(is_error_pfn(fault->pfn))) return kvm_handle_error_pfn(vcpu, fault);