From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D22BEC4332F for ; Fri, 3 Nov 2023 12:29:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D91228001A; Fri, 3 Nov 2023 08:29:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4895A28000F; Fri, 3 Nov 2023 08:29:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3511A28001A; Fri, 3 Nov 2023 08:29:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 22AAB28000F for ; Fri, 3 Nov 2023 08:29:01 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C6A9CC0A6D for ; Fri, 3 Nov 2023 12:29:00 +0000 (UTC) X-FDA: 81416572440.17.D624834 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 0FA9D140024 for ; Fri, 3 Nov 2023 12:28:58 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="cD5iKM/B"; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699014539; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a77meOT79I7dsPYCFbUcAK9S3K/ZvqB8pXsH6tW8Eq8=; b=4lSpXxKfjBYlrRxyNR+l9ZzedMG5MMB7paxOoVxCz3K+WMsQTyFvgd1aUkTUvEQWl6OsAt 8vA7AWCdx3Bf1rHrQPu79ojhoI+NYSEfxAXDivTNz57dFig6w5CHoxqFcNFWQPvI6tLQoh HjCwe/cLmLOlpj/V5KhMNx33UEjeZ7s= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="cD5iKM/B"; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699014539; a=rsa-sha256; cv=none; b=taWw+oFcdrNJmyLLnQATEKHwkwGqvgxFZnOZoQRd0VWkmYhD55SLpVnMwKLE/m56JNOYlN t4Ie/Vy5wAQYe5bljsEnMOQVUE5faMnMabvZX8Ssxy9rKB68EY5pBGI+TbGgOX5MM3Faoz q+c73aIzf8zk2r7oAMQ5wJ2XJJq9KuU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=a77meOT79I7dsPYCFbUcAK9S3K/ZvqB8pXsH6tW8Eq8=; b=cD5iKM/B6l25pNkN82s2dlw0zo 2JuheD/f34EG4MV2LGnlMzHIBWbW+dvhH3ikgmnDuwj812/djsSe/ZDt03LwgJJZ1/DBWMYAwf9/P djFt50UfGn0D9q5o81C2B9/5kJHlU8d+WWH+UL/EIxODhmO8e0EZeeWZYZRKS84230nuufL8PD5LH tl/0Lqf1KHEPNn69kV705BodIWmWmerpZtPeb9YbM3YCL7QzXXgC48Qle84woCcv60Dqt4uiwrNQ8 u5bGqSpKVseETjeTyLB4nAKnzRvSdTM7+Kx5rigI4sCjGhkGJa90SXMkA00ZYKltV8uIJj8vz4+u/ Zyf435Eg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qytI7-005Lgd-4u; Fri, 03 Nov 2023 12:28:47 +0000 Date: Fri, 3 Nov 2023 12:28:47 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand Subject: Re: [PATCH 4/5] fs/proc/page: use a folio in stable_page_flags() Message-ID: References: <20231103072906.2000381-1-wangkefeng.wang@huawei.com> <20231103072906.2000381-5-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231103072906.2000381-5-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: 0FA9D140024 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 9nuybhxrdm8q7699rwensw4jawr4qar3 X-HE-Tag: 1699014538-801557 X-HE-Meta: U2FsdGVkX1/eHPN9EqLVSVrIddR42MMrdqRIIYlUGYevTfHo+bakwtIfC/EZ2gy1SSMpn4drmqt7q8eT1ypYEww/jOym+skzGQoBIcBFxI35qt/NOpflDxM/a4u0VSEqzkiN0TI2BIC00A2l+ZmpF/mufBcQi8AjTa1JZKY71SwKs0aQ+TeAGrjgGmCbd4dYpwRkAE9iFiIIcqS9VfGM1naG14ReqRZ+DtrFXHRRTk2J/3xum+L6xCgnYlT7NFNrglMabfngbgCS6SgqR16gLXhL0lc6O7O/BuQu1ZCeAihoWF4yiKAPXGCnK9Wo419aaZ9fRsg2ABqGyAls+LuBqyVUZF1w12YM51d5mCM23babJjKjBRwCwR0edjHmIcWIU5TywJBUGa8iXUOtrYLOLxGyxBsO54mwtpr+lkSqoI7Ze0TP1uKCoSZDiyWYu9XSlywTIlCutekKOxZxbRpLSTuFJqfiuglztCBECmwP8M8rd6TB9Ur+lEQw/MvqCwWqxAvGLozrPorAoZtO7Me3xH17u95w+qyt3FP5lbMhckKBjaxMaGxWnZi3ZHQkpjT83T6+GfbNvvfnS+1wUHEalRLj7xnOnZ9sQs999nKfNOsCNVQqwTI3O8kJuOIXTFGJAkViWbDZ24QvxdFi20a7FQPlOJ2AFfi+23R0RuqPXFqP4iYCxdZKF/+QjlwrWMvbTBQGd5kwEaVv0EBBDOPQyQTKFZn8GY7l3FEaY6HJYQBUnOo4gRRSgewzvB/kQahuDCZaocfAlBtucICkV4o7FzAwb36rRYfy9V3dyZh3Oib+v0glSqOZu6HhB47PFpcHoABM2hBAJbtgZX+75HP+lM2+gpeRSkfUHu+TDFn8j2UhnfNKauho8OpkPzoR62TUSqDDFZ8Izk4rM4qPXvEnxnsmctGxIff57gTRb9PGExe/SW2w3/5qcA0ZdVY404HrWw+fLMf8gK22ZuVW/0h k1rXSXxn zkG6tx13MAxPAPqzxlJFZFVBT79PkAgjw9d8oVj0kNUuOfMiIdUbMPdWQ52tReZLR7Fe7K0UaREYgGdu4xK3/2d+AtTSg0657NzWLF/+G4jNUN+BMhqsLumNWjp+VKPLOzXbUPxFQYJwRN1jNH3Qy6LIsbyCUDyGy++8MpljZbZfjpybvYUbglywlrHPr+r+NmvcKs/yAE3DZXdLFJ5oyFcrBbzyfx/3obi93cXNJ2gF4PqiB8owrI1heNrT/FWum+5p30MMTlgOnpMAbJHgH7mLhJazvFiryhvr5gKsQ2e3Wo0M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 03, 2023 at 03:29:05PM +0800, Kefeng Wang wrote: > Replace ten compound_head() calls with one page_folio(). This is going to conflict with Gregory Price's work: https://lore.kernel.org/linux-mm/ZUCD1dsbrFjdZgVv@memverge.com/ Perhaps the two of you can collaborate on a patch series? > u |= kpf_copy_bit(k, KPF_SLAB, PG_slab); > - if (PageTail(page) && PageSlab(page)) > + if (PageTail(page) && folio_test_slab(folio)) > u |= 1 << KPF_SLAB; This doesn't make sense ...