From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A51FDC4332F for ; Fri, 3 Nov 2023 14:30:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AF9828001D; Fri, 3 Nov 2023 10:30:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35FFB28000F; Fri, 3 Nov 2023 10:30:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24FCB28001D; Fri, 3 Nov 2023 10:30:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 131DE28000F for ; Fri, 3 Nov 2023 10:30:40 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DDB28120A17 for ; Fri, 3 Nov 2023 14:30:39 +0000 (UTC) X-FDA: 81416878998.01.F96BB46 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 632D3180031 for ; Fri, 3 Nov 2023 14:30:37 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FbyJVXsJ; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699021838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TutFGcTUbbtZZeHXA63UR/SNK49qiEmJWb/gtgYEieI=; b=tXVrbu2aWoLtN9RJKMhtGUL82dAzn1kazqUg93rcjoOFvd8NbuJen3cJwwEiFyzJLkRPOK C+icuWdzOWRhsGZSl5whcZqNo/ekIrlm4RGmsWluf2sLjkxjPekouwnkQcKQ3tR7AkCuLl d/jcbVc9kzOcMTf6W2Z26RbmGFlL/jU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FbyJVXsJ; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699021838; a=rsa-sha256; cv=none; b=bXeWPTsuITzgKeBerjCke0/DqzKcFtoGgmgcPhf7i3Q7GfF+GNk2YQfvOEBT0rBUbLUG25 vPlE5GxSBMAVfH0R2MOWc2iQ3xH1sU9YHDNMYUYYp9AIkyWyOQd7GOk56ak+PVFPccDvLl PBfPtQYXuWoAdIvod+e9jfdlLmuQvR0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TutFGcTUbbtZZeHXA63UR/SNK49qiEmJWb/gtgYEieI=; b=FbyJVXsJzK7XKpDQhQSH2f5bbB EgnQqqd9A9MFrtDCw2kOiVC1DIyBIwkyxlhwtCFXD4kA29mLsIB2wnynfa+ilpkl4TDa+mlRCGUQe bWhB9NrNZ6N8a2BJoYER/YL5yFnOOOynx4Ntax3dLv5EjBGKpDj2bljHRIgrQ+yhvyLmlCKvwtpD5 txs3wPs/dADpxkPkUXf9pmOa/WA3wpJwY3mFWqRJarMd6nYaQf+TRGQvYWVUM5qFNc+hNSK3qeSqU Xor8VEwOvcszB2K2Ci/7a62ltupYnMXN6gdoUfddkshXy82ilrp/FDK4sJRxXmk1Fx8uhoQ2e0Yne T6r8e5EA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qyvBp-005rhq-Os; Fri, 03 Nov 2023 14:30:25 +0000 Date: Fri, 3 Nov 2023 14:30:25 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , linux-s390@vger.kernel.org Subject: Re: [PATCH rfc 00/18] mm: convert to use folio mm counter Message-ID: References: <20231103140119.2306578-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231103140119.2306578-1-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: 632D3180031 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: i4ku5id1wjses1fc56t5ogrmhmfetdi4 X-HE-Tag: 1699021837-650460 X-HE-Meta: U2FsdGVkX1+wIOsslgifI/YTEUq6SbqGLZOo2nQcsMfdLJNIDIAr6jCCjCyy4K+Sp7iZNr1mrenRAbfwOErJkNZBhVBF4EAD/yhhmM1j9eZN2dwz0fWdGOE31t6dVYe2EG9QfdLuAABx8oIFAmIR3BU0gOfNnglG3Hyo/b5v+qRdCV4B28mKGgkr7lEQ1ESwmFjNgZA/U0tTB0Qg7gElqNNsNYKBBLpidT/BfnscPiLW2mN92hxPCJEVmXIjHG/R0RcKHxNBPeCNPNoGDjRwZJBRBdlhPKNZDd5bUfqbiWZllbm+nyJBoYZ5IJ/SouklScno9C+GdmWEi+k0zx3IQLaWrtPFm8WFii9fP9jD80sbVZ06+B2/uiG0yfNOv/YzTf2MBs6bwSNZfzno7t472ShagkIwJretoYeEoRL5873rjrqqBwJSe/+QjV2rcdR30IhcMfaDu/YyR8vUZ6FKZVkQmpHAxCsY5fURCKDQzfoJ8t31hvKCo+AvdMnyR2JZwhgjcJGHmSHAx+r5Chr1+i/4xS6ZiXoHZAgOBLIaGUWnCFULtb18XTCEw/+irdMYcPSd7MnNnTunm2TWHQI/fgV9rIVNYmeHWYShOK6Y6nuAdoi01xFQgIgw8dW+ZkN0ExAmDNz89CPBRHpQWQV1q42goaVmBExyXWyGjIwSxoPL2wX/+i3fUwlsqx8Un7EoYJiVfgUZBAC4nnmqfr81lN/0C6m8KExz4yAmx4hltts8GpmKAEc8Eg9r5A/DyVAY09k8SQ8g6z1GoMAB2jkedxNNuVtbf1N8PAGeNdVAPXfjJSTZIJs18/blWO67Y1UAmA9H3aUXGhYUr7mOgO+vySdOIhWoeOO81J2rBGz2DHyAB8D9ss4ZMnAnq20ZwUp+fcMmCwH+xWZNhLZhvXPOVSsMibMPkCbvTtNagG2i3TppgCSZPZ0HCc35tRcj6yfR7fnknxA4Q22eqxDxgab hR8kaDDM PGhZNidsRyMNaPzyaiQzclYmUUonk4SsUVwFWcS6FkKk5MyfGzQm2hiNXFF3UWFYRFkdWEhaTTt0pXvoYX/exN5GtGxUKOXS+KcPrjA+1cUcXpE8f8cGpP2RjwlIhm0yU69h6KNzh0kpQy2A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 03, 2023 at 10:01:01PM +0800, Kefeng Wang wrote: > Convert mm counter page functions to folio ones. > > mm_counter() -> mm_counter_folio() > mm_counter_file() -> mm_counter_file_folio() > > Maybe it's better to rename folio mm counter function back to mm_counter() > and mm_counter_file() after all conversion? I deliberately didn't do this because it's mostly churn. Once all callers of mm_counter() and mm_counter_file() have been converted to use folios, we can do one big patch to convert all callers to pass a folio instead of a page.