From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EC1EC4167B for ; Mon, 6 Nov 2023 16:04:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09AF78E0008; Mon, 6 Nov 2023 11:04:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04AEF8E0001; Mon, 6 Nov 2023 11:04:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E543D8E0008; Mon, 6 Nov 2023 11:04:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D33308E0001 for ; Mon, 6 Nov 2023 11:04:23 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A7EFF1607D6 for ; Mon, 6 Nov 2023 16:04:23 +0000 (UTC) X-FDA: 81428001606.03.51425D1 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf03.hostedemail.com (Postfix) with ESMTP id 4D25420005 for ; Mon, 6 Nov 2023 16:04:20 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0knBFgrV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of 3gw5JZQYKCPQoaWjfYckkcha.Ykihejqt-iigrWYg.knc@flex--seanjc.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3gw5JZQYKCPQoaWjfYckkcha.Ykihejqt-iigrWYg.knc@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699286660; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vBcfSXW+7b0RYZr/CwodaGuIC1t2rSK8z82L7NdJqdg=; b=M3Gnst8EijiZtW1pEx8XhefPmFUXRsBluZnN27mZE9KEo7GXeFtGcl++7to/+9e3FtniVY +f1NO6CFE66d5hhLa2EHwxqQUuwN1wEFNANo89cnk2gtjxrjC4orqaN9GhfpNzClcqaXOD q5C1kYC0KwCREGunmdUFze7e9Kh80MA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0knBFgrV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of 3gw5JZQYKCPQoaWjfYckkcha.Ykihejqt-iigrWYg.knc@flex--seanjc.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3gw5JZQYKCPQoaWjfYckkcha.Ykihejqt-iigrWYg.knc@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699286660; a=rsa-sha256; cv=none; b=8QMsQ3bGShNesdhPJujabqK0rHq72Uay7xhBslfPcscWvBpdmbv2DCLyyrcvIIE+NLX2Mv z351Sa6qYSv+/d3D7zcPHoOCCoeTqggllx50DuvRzFAc6wJVZvmgDdF0ZIcN6V4Ci0+6Q9 jHTFet3hW3DQXF7eDK1dIq4a4tqszmA= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-5afa86b8d66so64245397b3.3 for ; Mon, 06 Nov 2023 08:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699286659; x=1699891459; darn=kvack.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=vBcfSXW+7b0RYZr/CwodaGuIC1t2rSK8z82L7NdJqdg=; b=0knBFgrVW60wl191ePEPPgODPFdv8yX+lGIXGdPHZCP6jUZLUYNoJyYJEU8a7+/W3A LdJREWJHSdVEgkbbpjQ8zgXfs6dLDTvB0iLV+Lluj08s8R3UiomEkNMC+p482Ha/FeR3 SzUPqyP4RS1wWt2tWWk5GOsChdexx59RuPl02yqWpDUQhHJcNE9SgsGvWRCHvodEhjJn cUfDn5oyzi328sERsmN55rPJ0SWyA3JwmxB8Ewpso28hUeKJSldftiTj/Isy32sy8aP7 ojrTDLiBJ9U3WoevCqmb4PxqqFTjXacOMIdx89U0j0Q22UPf4hDzS2a3i6pA4a9FAzX0 8r5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699286659; x=1699891459; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vBcfSXW+7b0RYZr/CwodaGuIC1t2rSK8z82L7NdJqdg=; b=Uhbw9QjlB1o7Gszp+QMY0qWEOFTVSnjHSlUaAyNKfGYABSchmMOS3P7STFNW7s/CS8 CAl4nZVp5+wH6yg7+dziFqeKItJkcCj0NjuNm1YO+6jW7IjiD8OKmYlyMsz0ozAA0Pxq eCFK/da/KNx0quqZyPzOWp5ccv3bGRY332A80nplMazNp3ExPEABxABBFhd0MUOzFIMQ tr5hnIKU4KYnnOc1XHwVa1hrM7zIxX+5TlLoh3lVzXp/J/+Gm0gk0hALZJ2dZzKaMohS aALO355L4oTUV2IoBDZ3zkHluNWCVyjKjsSxXuxkEMh17vwdyXLWKqb3HtFCGmLewzX0 JNBA== X-Gm-Message-State: AOJu0YwRdWk3uNjJCcB+AY0fpfHFjN1TOubLIH8J1R0S8wqLyvGNNAOL 63m1TKClaXQGGYW4vIExM4vEOpKB0ww= X-Google-Smtp-Source: AGHT+IG4M/eznhqFxpL/eWUumIXP2aANvxiOg95OzhM2lh4aiDVuodrpXWON7UbLhWxQPiRYqqCoKKt9NcE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:830d:0:b0:5a8:6162:b69 with SMTP id t13-20020a81830d000000b005a861620b69mr214046ywf.3.1699286659321; Mon, 06 Nov 2023 08:04:19 -0800 (PST) Date: Mon, 6 Nov 2023 08:04:17 -0800 In-Reply-To: Mime-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-28-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH 27/34] KVM: selftests: Introduce VM "shape" to allow tests to specify the VM type From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4D25420005 X-Stat-Signature: mrdz7rq5jh76o3syta1ne6jf4m7occap X-Rspam-User: X-HE-Tag: 1699286660-894223 X-HE-Meta: U2FsdGVkX18XgK0egSq1T9IdKoeUEXsDuzFo1iPhDNxEsMyyTc6/4qOLqGU+hwq0WR8ZkwuO7W6SuOUgcDDk5HCbNnLKWKmUnUXVElqEChTaJpTAmNnJhCi6JRNFWjK8KpPAHmmNipE9w9DeSPgAkbaIuyQ1QLQKI14D5FJgQiDemPT55Yf2pzvLa5+v2ejrFH1ZiSevdl28yfZ//TdgyQB9KlQjUSyiToqyw/pvJP1uSnXC5y6EWs+fhBFZdhp/h1T/H2Z7t3ZRNe0BjwM8UclcyLIOIPrrsv1M/meWR1wUQu6QNYA9hgMTFCkpw8zS/J44ku6c98JzUrfgPhb7v84Wh6aZNUBq055C1FeUSgch4HmQNqu/ZEX2Gg6I97EoA3wJooy4l/jwLFwAC+kGUw0RovPHOGCSKvA2jdiukIRTknuk1J6mj+ki+QeMSOuR6v64oxTn0O3CSC4D/cPiwbIuStLTUl8RUPDSGHeCDoYTY7/kpDN60MAoHXsh6xUXvT/Xz6w0p/QpiV/bt95hFQa6qGL0TcmBnE2X5TKsP80HKC0C6kkMT3l97XQ6sp7HFPyczlCADq5XNuhGHuRyDst/GXNFTGPEeuy7eFfK1dd8O5ZhrC+xZv6FIklZOGQHXAND4HvXdJ4iPgYhvzVsgqQv4CgGM4LNtu6fTLJx1VMSJLgFjtU6I139kdWvkWo1z6KjN9pPibfvPhv7w3XSGennhIr2tuEjCRxRQ2vm/soSqgj7Sh8Q3+IV620D3sa+t7OuCLSWdJ+DlwTT/BYebBvFqlbyqdEs3N9TedQggMUIILlWOt8eFItgLjtZqASntEhQUCyFALsbWFkrf3WuB1S9dTtugXyp0WZIuC1EboOyqsIzaGaf0AhDMg6mugi2LEVhGolRXsBmHFOUX74Pf+MPkQ3e1qcKPbSoqL6HwxfRmbHpJSKUHSQReXITgMsnXMZMF1ZWKmPz9mccCn4 SmK0m1Ze ld3OSN3v7HgtLNjZTuiiIMvGqCYqyv3g0EdY8mY9kOVaNY78U6sXQvCMlRBu+b3170wGl7F8f8um7mhZaiiFlfWbLfxdpe/giC7OOwsxJMbyqKJLRJEXqFBpu8Y3mBlJidXKAd7HgXFSLlcwAQrFJHsUo93iMjsatj/CE4+9aGM94K14+/+gOLX6XbTmXAzdbKcmNV70j/dywlwhdlQ56Spv/g1qzanhDPdP3BNETWeMoF5HjkV4+czgYByQuo7BCVzRpBhYvzmEyGkFdJXE5228umEaReAOqsRvSHaqSIYmlUa2KGTrjUjhqGeah1endwxPW5bTrwaN0/LrAuJssZ2C701uUFtiEU5VH4jyrs8BbUampopOX0UPxiRG7byJeMxMXHHf0CXZzzvuIZ/yd26Av6D/6EWn+2dUcILmwLPP/vRJ8giX79WtkoTpliMJghApGtwy4x3LdSYm3WkJ8dRxqaeYwVAz/qJUsXCYDmw6m5qYxfBKGHqdIlf9MM6Uopt1bQfXA+2br0EBHQ39ckXn4wRGltc8aCsJZzw7PFwuDwrDMr4uJi42Pclw1VBXwmj8cS2Eu6efI8irSl45m38kNzZ32GtaASamRDWqPFUVzrxJMnfhXDGQXLUwUwNaju1irb089oIPHUaUUdHqVfOzMcoBeRWXXkHjtvNw6Pado8MJ3hHpBsGw/NxzSYzJbgqnOq589vJGhfcM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000892, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 06, 2023, Fuad Tabba wrote: > On Sun, Nov 5, 2023 at 4:34=E2=80=AFPM Paolo Bonzini wrote: > > > > From: Sean Christopherson > > > > Add a "vm_shape" structure to encapsulate the selftests-defined "mode", > > along with the KVM-defined "type" for use when creating a new VM. "mod= e" > > tracks physical and virtual address properties, as well as the preferre= d > > backing memory type, while "type" corresponds to the VM type. > > > > Taking the VM type will allow adding tests for KVM_CREATE_GUEST_MEMFD, > > a.k.a. guest private memory, without needing an entirely separate set o= f > > helpers. Guest private memory is effectively usable only by confidenti= al > > VM types, and it's expected that x86 will double down and require uniqu= e > > VM types for TDX and SNP guests. > > > > Signed-off-by: Sean Christopherson > > Message-Id: <20231027182217.3615211-30-seanjc@google.com> > > Signed-off-by: Paolo Bonzini > > --- >=20 > nit: as in a prior selftest commit messages, references in the commit > message to guest _private_ memory. Should these be changed to just > guest memory? Hmm, no, "private" is mostly appropriate here. At this point in time, only= x86 supports KVM_CREATE_GUEST_MEMFD, and x86 only supports it for private memor= y. And the purpose of letting x86 selftests specify KVM_X86_SW_PROTECTED_VM, i= .e. the reason this patch exists, is purely to get private memory. Maybe tweak the second paragraph to this? Taking the VM type will allow adding tests for KVM_CREATE_GUEST_MEMFD without needing an entirely separate set of helpers. At this time, guest_memfd is effectively usable only by confidential VM types in the form of guest private memory, and it's expected that x86 will double down and require unique VM types for TDX and SNP guests.