From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9254AC5AD4C for ; Thu, 23 Nov 2023 07:21:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 306C86B065D; Thu, 23 Nov 2023 02:21:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B8A26B065E; Thu, 23 Nov 2023 02:21:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A7B56B065F; Thu, 23 Nov 2023 02:21:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0AA8A6B065D for ; Thu, 23 Nov 2023 02:21:59 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DE05C1CBD3B for ; Thu, 23 Nov 2023 07:21:58 +0000 (UTC) X-FDA: 81488374716.09.5DFFB72 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id AF874C0023 for ; Thu, 23 Nov 2023 07:21:55 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=rP4EHuoS; dmarc=none; spf=none (imf10.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700724117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JFbIyAbEwtb6PnVO2Q0IzmMwdTGFYa7ANNbQw/6iZHI=; b=6G1iAKV6t/42WCSbfTbl+BIlGcyxwN1zZ4/fJYJph3udB+NN8nid7MZXwQvf8w153TnQfH rUA8QETfY/xzlHO6+M0IIkSV+SX/W042FXSLCmIu7yf/UnBKMLs0lhXX+PbqEmCYRQIO1s W9et7HaDHP2tY20fEw/oTc6XhTxvcbM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=rP4EHuoS; dmarc=none; spf=none (imf10.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700724117; a=rsa-sha256; cv=none; b=FEAWLNfF7lT3NrfnnXg392Y18QvdlM/CrzBSKyC610LQFHj10tarK03frLQ+yHfP8ukEYx iWZs1bwiNPVTDomtlnjFy8SMRVx17Mq7C6BuJr88wIo8Rr2wPwqSKHM7ZSSdWFGsIqUj0N fjsPhgMt8wuusc2AmHRJTvv3jeHdy2M= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JFbIyAbEwtb6PnVO2Q0IzmMwdTGFYa7ANNbQw/6iZHI=; b=rP4EHuoSSlQQW0V8h103g/kEEr 33ysbISYUlE9yKwiU2wudbmdLm+4RetJuDrvnnlO31uiwOzMeI4Yl7E1qWyDwAvXeXRYf1WWeBLAy 3gSN4AqMoyJz3+jH2JAk2ncsNmVb3wbWqeqyNyN0G+uqjae80EURweD5lg7JhQVPpwYyvvmRHd9E6 m2qvxXGbCZRkBstP1uERXQkrmc2XkK7rpbBuTF51BVt2lzYthHeaFGsN7QkRitJNT2SvwrjdRK+Zy 6HxWugsUozHHJ2DJQ9OuEwLabey62FWT0XVdtMQf4+8fGDIuIrRW6iiNSd6c6i9/SQpmK1W7DivSY 6eJkE2uA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r6422-0040uN-2m; Thu, 23 Nov 2023 07:21:50 +0000 Date: Wed, 22 Nov 2023 23:21:50 -0800 From: Christoph Hellwig To: Peter Xu Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , James Houghton , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , John Hubbard , Yang Shi , Rik van Riel , Hugh Dickins , Matthew Wilcox , Jason Gunthorpe , Axel Rasmussen , "Kirill A . Shutemov" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Subject: Re: [PATCH RFC 06/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-7-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AF874C0023 X-Stat-Signature: py9qh3g3zhdebqp8hab8k98g6n6eo953 X-Rspam-User: X-HE-Tag: 1700724115-665322 X-HE-Meta: U2FsdGVkX19gOrsBjtnxbGLqUz7HtDzXiPNC2yramc2H8l6cCp5/HQPNWORPFuALyqdx/b5AIkxDztLmHMihh8haK5UbO4Id9tLj8rB8Zjzz6fxraNaoz5nx3YOlMzNW4PuudBuSmfhlqXupGBx67/tSxOn8RfBDdtzNlAZmIxmfKzP2ZBkvmglKIafOVvY6SROviPKrc8tG+4Q+2FgpuwbOKZNFQHhynGnAKlLTIXS6TUTBh57e8QR/SqKw1YkSesZkAETSx0/JfvKo2MeTU7s5pGsDHdSqm6kPp2CHumMityYrGWGG0ranoNwujr8qQnUnvAtdCLza0O1LtxZSVHWLjQ7bwcSdE54iE5SI19DaDKYthKcv5fIV3EDtmXA1Ck1jGAwbRnKq9SR5OOmisvmu663r7GMqSa3D58XOMbpsOXGzwiE/X+sCCaikWJ9jaW+XixTQhsEEHb2CdtrJh/+9sQlPgba0sa96h3hHkjZtz2/DTnwLGk+IkyEwZzBwL9V1AzRzLjKRZ8UYBl7ZyW+ou8280Xwhq++hcGj80GzpVIz25E7DurQqdAVCsayomumvV8BQOfDv1gc4/o5lKGa7WChXI/Uo7NjA9gNi3r3K/b6D9h5dBVs1DsNH5/dksVXvhcDcyRE2SVJi7BSe5tljvvpx3jgPHHEL17yW9vgbmvW3rXblH4pfDmL/LSZHlLqkrpyzC7w5l6F8Cb79DhkYo5teA1ySTg3YrXw4XIBZpFQ3qS7aFCXVp0ZtthlxYjw94glsVvK3k6Yi3yWe03ICstaFwg0w/vlQdEQQr+VLh/3C0tvGc9BnREw4AqRab1X9q+A+QTxiZYFx4rG84Qzc20dBOGu/FsHswxKOKZIAKrbGYCOMVikVmsH1wJaLHyfG8nf6zTG1hjFbq04h66NdbZcjQ4Lq5CVMxwVS8MYnevuwEgyu7j7g2h0/HEggHqGYOTOhA+A96XwnWLM 8bdqqLwd bmR2zB/t2tDAJlSVYWC0wx01dxGCibtLhBX5IjCqLp0vdmSaa/JW9i34PIvloNC/Kir+XpyQbQ6wt5iriR6QJduC9xNJFB59Lua31ViRLRWWg3SdepfI9xk1KJdKe9R5iwkJqsiNDPYGlJmI7sDCOD2Pzlh/YwClRB130p8bfGeKiN5hTDjaqOyxNiE2Fj0k64hORY1kSYIVzqwUPEHz6/UF4p9NdY6I3134VMe03jP3yYljKbwkuXiVDIQEZ8w4O1qqZJ42OQRzaUkeWfMNP23UCzOQIl9mpOKpUoa6rwYKKtu6bnaY42ZqopK8MOVJZq+2qLEqqNzPWShJnuPh9+ZJz+uESOzvwTa3VoU7ySaN0tucJZ7k8nw68/UDIZHZM1mPC/Ra1L0nPRvKrbIj0OmIp9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 22, 2023 at 10:22:11AM -0500, Peter Xu wrote: > The other reason I feel like hugepd may or may not be further developed for > new features like large folio is that I saw Power9 started to shift to > radix pgtables, and afaics hugepd is only supported in hash tables > (hugepd_ok()). But again, I confess I know nothing about Power at all. That alone sounds like a good reason to not bother. So unless more qualified people have a different opinion I'm fine with this patch as long as you leave a comment in place, and ammend the commit message with some of the very useful information from your mail.