From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1285C4167B for ; Mon, 13 Nov 2023 18:30:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 909E16B024E; Mon, 13 Nov 2023 13:30:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 892D76B0254; Mon, 13 Nov 2023 13:30:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 734946B0255; Mon, 13 Nov 2023 13:30:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 61D026B024E for ; Mon, 13 Nov 2023 13:30:52 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 13B7340900 for ; Mon, 13 Nov 2023 18:30:52 +0000 (UTC) X-FDA: 81453772344.21.26644EB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 0053940009 for ; Mon, 13 Nov 2023 18:30:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jIXR0VxM; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699900250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MHY5DgRsGlef0gPl4g05l9qLDqCoWUNy1TAlPD0LkNg=; b=bpJKlLDQQ6I4MEE6pzyoC3Yom4P52Dj5gILDtqq+ZqEzNqmC2Z1R+4VWsA/350OvJJInc3 UpOKUxuxB92lBD4zh/6Qp80SCWy/cpJSZ8ZJ8JrtXzTn4167qdNUzTVxlUfTuXEY84KrKY hqJJoKZjFKlsb3HGEBZrHnYYdt7Rn4A= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jIXR0VxM; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699900250; a=rsa-sha256; cv=none; b=NOBVHL/DlFBTZA4rVH1O10pVQATv1FbKzaWED6+ps6nr5hDLe80RMEc+WonlNlarZ/aFcy CN16GxVZAjpJlsHDaokVSb+7T1KS4PC5O2jqVHIqcR7xJG9xJtM8sFQv1cwxBJeTCFp+eo i5PbyFhOkPvQdC5hT1zojbIvs2mjfQE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MHY5DgRsGlef0gPl4g05l9qLDqCoWUNy1TAlPD0LkNg=; b=jIXR0VxMBYaxT4FZjUlh/ah+Mc 8YG9RNZ0biVkigNeUCTjla2ktm4jdMGXLBDygyIiNq/bvROgLOse1rYvU6MUbOD5X8XP5fSmv7w69 +vVDY4mGqC1LBYoP7EL0SStRmGkbX9QQTlT2fBNwuVRIULs6OBBx5wREUtXHfoyiZBahXVNE7qpF5 M6u7oBAYD2wCwizYnyM9wV3dVgZrM9Nuruihyutyl5q2ItLNHBuvfRVNauOldRoU4UtBv/F3YZFSS Y8zyikH8upeDkcKuCwvRvEwc9sKYewpFUxxyUg0aeOSHRQkQEkAqjW2UxS2JximD+DKtH01KUrPJW sZMLgDkw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r2bhk-00Fmtf-Tu; Mon, 13 Nov 2023 18:30:37 +0000 Date: Mon, 13 Nov 2023 18:30:36 +0000 From: Matthew Wilcox To: Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Huang, Ying" , Ryan Roberts , Andrew Morton , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: Re: [PATCH v1 1/4] mm/compaction: enable compacting >0 order folios. Message-ID: References: <20231113170157.280181-1-zi.yan@sent.com> <20231113170157.280181-2-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113170157.280181-2-zi.yan@sent.com> X-Rspamd-Queue-Id: 0053940009 X-Rspam-User: X-Stat-Signature: jdfn3pmoz1kqjd3gd9j617f997pcx57y X-Rspamd-Server: rspam01 X-HE-Tag: 1699900249-279867 X-HE-Meta: U2FsdGVkX1/3HIPHezHLVXdgeiVUxi+OFxZTJ3FpaBlFowORDgF+jIch3nMJkyM9pRvm3aGtDQi+1u2PpRF0IqDZuGD0nET/fnVe8n23ZEctZDadxbSnIMJirUI9czSmwdFSmRJZI1U+ImkkIZPwKp8KbLBeJMim6Tk3VAIxnfQKgsBskDdszTgrMQP0TSR5NwgOjnQR1vJM+nuSNj6aOEzHDmeGO0XYkGOknRv+xhkKizaA7y52Qb/LLtSSr3HnV2Elzpn9bvS3PcriHFqNEJEcateYPnxanECsBnwj9MzM3FYFhXRW8pwsEVZbRDKkF4XbZDX0fxAycg10h4BHPFTBCXlXMKr48YCwkUU/c2QzK0Ea26cfuX2jj/Tw8lEJb716bOnjsVOzvUX3lvr/1bbA9gq3afNJebYr4P+sbLyN5fP5mrrVn3iqzKkTDh6sGPOTv6FQJ6fn0m0Jl3j4jyaS4cDH/cGqSj31hq/+7d0APYhTBPjvxpqM0gcwwc6TuEo5VP4Br2tWHZPgGbYsglzLHBH4+a1lecHYfS6X1W113tEC3+UB5HftRMMoq1/0xR/fR6IVhD5KaEijdMh5DkUL3BVkjJr690aDShvQMsB3d4qBkQpeue5fi5y87IsLuNx3zalBmrY7OMl9LaJhEGW1W5dYH+3nCrqXLNkUrqxoheznBxKfZ58cN17nY55WeeJH4WISHMr8Tn9iLplexRCm/HRSJoa80/U1Cm1uObM/r33ez+/zqjV34U6Ek1/nYxrAg8E/TikRBWB0JF1PVEjjuKf/fBiBOJLLVt4HuS0eq/uH5Ari6BDPrQrFUZRspfCtLsOYjDXloPuHa7YKmh/WmIbre+HrKYUrD7DKrplmDxdJeUYNaGu/nDIBfawDrVO7c4Ou+4Bp240siYiror++xIs5MFwCr3jnCdYSB7skzIm+LNFj9AlHs8zxH789ySqZmUyZ1FuS0CeNMgn nC5YLEup 6QXO3yVff4QveFbddDVqeBx+5/7ZBIMYTy5NsDR5cXogvyEGvOm9Zj/22TgMF6Td6iMs8lmG4VkLwnpR6lFZhgVsQk0Ofd9OymuxXyQiUHh63iu0po3fif9+PaBqijChKnDoTi2YjzKcZ/5fNJLaV9hR+ziZnRW9Pu4WmNhJiosQ7GlrG8M4A0FPUYc1TCw7E7uo3ftv9JsL9v9PxCOuxkdrMKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 12:01:54PM -0500, Zi Yan wrote: > + /* this makes migrate_pages() split the source page and retry */ > + if (folio_order(src) > 0) > + return NULL; Nit: folio_test_large() is more efficient than folio_order() > 0. The former simply tests the bit, while the second tests the bit, then loads folio->_order to check it's >0. We know it will be, but there's no way to tell gcc that if the bit is set, this value is definitely not 0.