From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC08C54FB9 for ; Thu, 16 Nov 2023 12:52:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F1056B044C; Thu, 16 Nov 2023 07:52:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A0FD6B044E; Thu, 16 Nov 2023 07:52:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7694E6B0450; Thu, 16 Nov 2023 07:52:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 685096B044C for ; Thu, 16 Nov 2023 07:52:32 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 40A41120BE9 for ; Thu, 16 Nov 2023 12:52:32 +0000 (UTC) X-FDA: 81463806144.26.F331353 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf06.hostedemail.com (Postfix) with ESMTP id 541B118000E for ; Thu, 16 Nov 2023 12:52:29 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=CJrsqk56; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700139149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZVDDhjRstd/kU/0OqghBmhN2HaoOfhbkDnF6K+OWoms=; b=uA+OOs/77H0WVe8jNa1sY3LR1DqW7SKQ503S19kThyAvHGsCPvQ42T9/SsjbZrhJYkTqtT q+E8cSo0f4q+EiOGvde3eVdlMk583RKuPrij6DsEpPiPGgcpCky5IGaTSHNb/e/gIItfMm 1t4uEqUGxrV0WdK3/ufxyNfAmE4QFqk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=CJrsqk56; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700139149; a=rsa-sha256; cv=none; b=4Gb0jSJ397L75G6LldfTdIa299Thyp6tvItVAG41ohWeuY1AC1wPROIS4s+AXntfkSYezC S3cmHiOsLZ2jJvINKpNRy4VhTuzJdMU3hHoCjGmYOp2ACEps25SLU09HwlKQn1UfenZdBx OAS7lq9NsFi8h2mw8n2piLeYJeQK8bY= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4249D22917; Thu, 16 Nov 2023 12:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1700139147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZVDDhjRstd/kU/0OqghBmhN2HaoOfhbkDnF6K+OWoms=; b=CJrsqk56sxOYEro5aDypNUHOVOSoMMi1i5G9GzGkaKu5HexSd3PoU8yUA/+l3+aVcRQs7X +Q2wWwWK5tVt2kpxGhXhzYd3Ih9PGrdBzwgLmczAWQhu6BJixLUqi9R73BKECsJhQp5LQ5 i2HOCJeMm0MQyhW6aL5bONn4GYzomjk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0AC161377E; Thu, 16 Nov 2023 12:52:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nkJKAIsQVmW7egAAMHmgww (envelope-from ); Thu, 16 Nov 2023 12:52:27 +0000 Date: Thu, 16 Nov 2023 13:52:26 +0100 From: Michal Hocko To: Mel Gorman Cc: Charan Teja Kalla , akpm@linux-foundation.org, david@redhat.com, vbabka@suse.cz, hannes@cmpxchg.org, quic_pkondeti@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/3] mm: page_alloc: correct high atomic reserve calculations Message-ID: References: <905d99651423ee85aeb7a71982b95ee9bb05ee99.1699104759.git.quic_charante@quicinc.com> <20231116095901.72oqtjoiqzt3tfhj@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231116095901.72oqtjoiqzt3tfhj@techsingularity.net> X-Rspamd-Queue-Id: 541B118000E X-Rspam-User: X-Stat-Signature: 8y98e8xb8mr6uejy838kpghm4kwi4jhk X-Rspamd-Server: rspam01 X-HE-Tag: 1700139149-819450 X-HE-Meta: U2FsdGVkX1/+UUBhCTSraF45G4lN9RQofj8+FQGJ+X9nC2nlVGbhoCIE/+AM8oZGit2ZJc/Hf23WW81RsecUF8GjPwWg1b5cWFWo0HLeZcD4Q0KiRItN7EdCEW1kYsBlKiCyaGUmT4szrC3S6XKhRzFngsaANs4IG9P6zBzUfMIJAx21KAx5CGzRU818EgOzoi7+k8BhGxHZQZz6GXsgJGmqHb1L5VSB5ow8dmz2dre9tOIc0tIN0DIThe11UF0PVLDG6u+6Hlv1aOBx8HMVhR59qE9f6Ki0Y/qGtCTQ193A5BVqCBl7n0NI0IKyv2Bb8CvsaDBErKNl71t7ASaq9J12FJ2TFL/DID6TwEFJB2/MYjQKCEynMg+sGb/UQJXa3I3/kGE1ueZb7aPdSKZ51cUB1dGt9R0BQNqJKclJY229xntXKDzitaYsFh8MuQfwETX3tlCAJfGihigC1sI+r2Y2jyOcJwWBZVHgzgqPzILxt8zq6/aNwuc16eZLbvFoxhIwjZEN4+DX3SMjv8NVJFjyOrhQ6TKC3hRNet+G6d8WvIg+zvJK+5uCmVo0nxksnnp6aoe/bLz5MaeCjPJgfVpeyz/ysOkH5cVUwacZOvf/y27fnl9+yAwbPvHNfB1oEp05iZ6mt2jJRvEekwO3fGVMTxXw0PA8ZUVvVo+fKNtjFCxplmnCF7gT0FFvdUhx8bKv7KvuyUCEEbmtua3c84XzvPz7vkuCr+b6uQZD5P3UYdUP4BCNAacbFm5//mgWYIjxP//J12VlNYO7hS6YTj8G6QhP/sTxyakX1P0tZ7MsEmV5bAPy3dXRwdS72xebhrzNUOsvue/GClEw/SwcqYhKxJ1P5rd+CfJXGvY9mQeEMg3N+4KnBlK9iyzTTDso02qxDpw/HNmnYlthCxQQqT8WIN0A/EzYnXtO3U65pSqUCHoLQeccgKM0jQXaQ5/7nEYq/1QJW4XpLkQ+8x7 X/3dGtmX e9d8Mk82x09GIoBCRqWUMeyV/Q+AKmLpaRuZLu2LM93Qhqfkl/I40zAArYuLGMagwp/hiMyrwtFHOLU22dFa8iYC9WlFSHryOyYYlbsusQ2ONUAw6wAj2cxDdR7uqI8Wgrcbp+E8BwxKbDtwDmWC+7T101q4/yNooKOgWcdnRjZ6KlCyGMZZogZnjTsvXDkSeqh46gdE1A9/Zg/ShuQtazS82fqMZ5acUOZUPnBZwS2ko8tw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 16-11-23 09:59:01, Mel Gorman wrote: [...] > This patch in isolation seems fine with the caveat that such a small > system may find the atomic reserves to be borderline useless. Yes, exactly what I had in mind. Would it make sense to reserve the the pageblock only if it really is less than 1% of available memory? -- Michal Hocko SUSE Labs