From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E34A2C61DF4 for ; Fri, 24 Nov 2023 15:54:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60CEA6B0607; Fri, 24 Nov 2023 10:54:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 596EF6B0608; Fri, 24 Nov 2023 10:54:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 436E26B0609; Fri, 24 Nov 2023 10:54:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 319D26B0607 for ; Fri, 24 Nov 2023 10:54:03 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0A47CA0C03 for ; Fri, 24 Nov 2023 15:54:03 +0000 (UTC) X-FDA: 81493293966.05.46D5379 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 9D03216000A for ; Fri, 24 Nov 2023 15:54:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hjzmSFaD; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700841241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yp/TRPnJUCRddcn2pwqpadteZMnyKo+3JgWlmsfeyA8=; b=o7KvT5JDQPjazNzuGT2fKRRQYTF3XbQu+rKSBEe+dkrZY8kKNlgDxXsMPWV8gHAp3sY8y6 pfMV2PxGhIUFT1Lm2zIr0c8Ko6LhlNAvInIgbMQ84HB3AwpgCyqzQrY2AIdscLPcYu1gBz NOiX2Ey/n3rBkkrqWcUAxbiXrmnekZU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hjzmSFaD; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700841241; a=rsa-sha256; cv=none; b=dxFC+rBk91uqFh/q3hnCoV//9YGzE30Hs6T27EV2qL+1ovH6JHKfcPmHDTGkOnf+4g5cMc iA7RRXBXYo3u22o+rIOYyhsuiymN0f4+Ks7aVyiyXG9scsuHKVbf/w36bS+tYoe7pQcAgH QUeC18HZ6ZaGsFZNK62E/fLU6FieIFw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Yp/TRPnJUCRddcn2pwqpadteZMnyKo+3JgWlmsfeyA8=; b=hjzmSFaDj2EPMwg3j4Voli4wxk plO+mX85rqcIAExFojWw6zdP/4cQlZcoxhiqc/dZHaKeTy1dFmH6FGcUFX9UIh68Vtxk8ii3n/uqN /mW6X4/Asm/QMk7rs/H+oKD/H2s9KxNy2KiyIeq+6VMt+DrVDnyvF0UOpHMOmRfY9j4sI30NAaJsM KYPnt6dI6ZHzWFYk4hDSWR4ZfnhQryFDRZDI9fdi6YzGRsnbMly3QaU+KR3vL9cQefGVTXL2HADdz /uwm8AppmQCyNYeOvWJ4JC90e0208Tmwop3wGQi8w3dI+hBiJndFqYLAlKn+yFjFd8htpKXLT9b5f Rk61PzVA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r6YUS-008icA-JD; Fri, 24 Nov 2023 15:53:12 +0000 Date: Fri, 24 Nov 2023 15:53:12 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: Ryan Roberts , Andrew Morton , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v7 00/10] Small-sized THP for anonymous memory Message-ID: References: <20231122162950.3854897-1-ryan.roberts@arm.com> <9c8f6d2a-7ed8-45d2-9684-d77489bd99b8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c8f6d2a-7ed8-45d2-9684-d77489bd99b8@redhat.com> X-Rspamd-Queue-Id: 9D03216000A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: i8w1kj7qxydahro6w76wstt557ydpexu X-HE-Tag: 1700841240-134084 X-HE-Meta: U2FsdGVkX1/AD87o1Z4EYPc4M/yXl+TP3eAeEW1AVF5dbhlRjt0BP5iHymzj8YwfA9nhKF1tOTfHz+O3dKDFqRerNEZVVu+bC1kkk+fja5/Zk4Qs/QorhmQH4JqW2TM22GlzNa0UEP2o5hGJolP6RDbdcPfn8PT0EgwC4lheLfAykWf5qcQ134sZqu6ywys40zLTtBYJ3khGJDW+PVy9a1MV1XXZ0lOrl0AsVhUUX/LxXKe8qCvpVXgmtWNQr5NDNj29b85A8BrCWs0uDcuC/C6mAZ5akHuDeGjN2FGbblYwahiUqGkyXSkHGC/8mgpvBg+c99xzeftzg2YA3MRoYInLUUOKhPvACB9Q0ISmatk9houPzTjSfxh8BwyQ/SQRKOuym17a2D1YCzfMspOvXfQLY5H0S1+XlxwJ+KLDELbEF/7ZoL6ZFVWgQEmNs4eD7tElyvlBzUmSvJZ0weFfFDMBOi1pH6LSbyVX4XBZDKvp1hsra5Zsg8j+vwMzCVbQxenlOvZTKrYZDXwwG/gCOfJeGQNcPpHdN5mdEh6sHqrqUYLNMaF490fik5HEKYcJJlobEcBDkPh3gyIQq3ToA6MfLroDjk+QOnepVs9kc8AmKVxyJClJpHU2jwWWFRMHyKk+GlCuDNqu8eZrQDg0+bghI9y98HYqv79nCF3jbvMzwuiI8b1wYxldRLcFd7aCUlwUYfjshIwAevhiDR8fGZ5gUHT3JdmaAbB9B65XCT9jtM1BER+Zh8NMxNYoT5DRGwSooNTGDC7YtZ96Z5XkARe7Mc5jRG0zhQuePo0eMRGmHnLSI+0LvJQ8CQm15un/eq8FdsipdWhntr9OuoFVS+AUk3hv58UslLTxJkgsCPEjHP8RBbcEfWeEXcTZRESLiW73U9AhgiMYw3FFXKTvwmsqKAYzYdFVot0JYfdX0a4EmpMv4woA0AFJ3WSSSJnmvbl7aR6taH1D88yuxXY L/FZV/eQ HXTtSPc0kvi9bynIS4OCVd+TZDlT44Iv0bsWOOsCXF5/X0Sf5TWtlvwh9vPnyFiP+oOoP/Ijs/SNvOOSdOmk2lkoaXNsOCeTJ5T20GqMut7mUwcPXuBIn1EQZRGyc2vqUN7P+MiBIilBxcVAwC8A+GMmkJR9QuaMJDG9fdCvqlfDd9f7Th6xTjkR18aX4Z49i8umQFlxZviitkccpQGXoYLxwUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 24, 2023 at 04:25:38PM +0100, David Hildenbrand wrote: > On 24.11.23 16:13, Matthew Wilcox wrote: > > On Fri, Nov 24, 2023 at 09:56:37AM +0000, Ryan Roberts wrote: > > > On 23/11/2023 15:59, Matthew Wilcox wrote: > > > > On Wed, Nov 22, 2023 at 04:29:40PM +0000, Ryan Roberts wrote: > > > > > This is v7 of a series to implement small-sized THP for anonymous memory > > > > > (previously called "large anonymous folios"). The objective of this is to > > > > > > > > I'm still against small-sized THP. We've now got people asking whether > > > > the THP counters should be updated when dealing with large folios that > > > > are smaller than PMD sized. It's sowing confusion, and we should go > > > > back to large anon folios as a name. > > > > > > I suspect I'm labouring the point here, but I'd like to drill into exactly what > > > you are objecting to. Is it: > > > > > > A) Using the name "small-sized THP" (which is currently only used in the commit > > > logs and a couple of times in the documentation). > > > > Yes, this is what I'm objecting to. > > I'll just repeat that "large anon folio" is misleading, because > * we already have "large anon folios" in hugetlb We do? Where? > * we already have PMD-sized "large anon folios" in THP Right, those are already accounted as THP, and that's what users expect. If we're allocating 1024 x 64kB chunks of memory, the user won't be able to distinguish that from 32 x 2MB chunks of memory, and yet the performance profile for some applications will be very different. > But inn the end, I don't care how we will call this in a commit message. > > Just sticking to what we have right now makes most sense to me. > > I know, as the creator of the term "folio" you have to object :P Sorry ;) I don't care if it's called something to do with folios or not. I am objecting to the use of the term "small THP" on the grounds of confusion and linguistic nonsense.