From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E69C4167B for ; Mon, 27 Nov 2023 15:10:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A9476B026B; Mon, 27 Nov 2023 10:10:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9325E6B026D; Mon, 27 Nov 2023 10:10:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D28B6B0279; Mon, 27 Nov 2023 10:10:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 65C596B026B for ; Mon, 27 Nov 2023 10:10:44 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3B598160322 for ; Mon, 27 Nov 2023 15:10:44 +0000 (UTC) X-FDA: 81504071208.28.B846D5A Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 10ABE2002C for ; Mon, 27 Nov 2023 15:10:41 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701097842; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c5toJXUJkeUfJDBhQO473IxOgquCBNGzi0UFwTCoicQ=; b=f2Oasso/SF4yseKNeItEPJocmw1W56OaaJqLPAh34ZmgrG37tFGO8UDv/4+oLPYdpXp5Kb dmgGQo9Qk4ao31MCcyhAp6ezGgSAlws3bAj/VEIWTX6quUNq1w/Eh9yBiMj2HHJz3uFNaE ad3WSA81dBI5KYRLMDgXHjeqUUd722Q= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701097842; a=rsa-sha256; cv=none; b=Ow8VRHKZT2etMKt4eSF7sCxYWt+qsaYPVQ2BkvJSkejK95Fgcyy0LmpWS/nnvzQAgCR4Rh QD0xPtPsfYV0IaOIkJtwXuhe5HuEgJHCpebREO7AdhONDSIFrwnWv+vSUkQg1BnhwuWPNh RTHwGpze5v0i6uujpIyES3tAN3s2WmQ= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CAC2F2F4; Mon, 27 Nov 2023 07:11:28 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC8E23F6C4; Mon, 27 Nov 2023 07:10:35 -0800 (PST) Date: Mon, 27 Nov 2023 15:10:33 +0000 From: Alexandru Elisei To: David Hildenbrand Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 15/27] arm64: mte: Check that tag storage blocks are in the same zone Message-ID: References: <20231119165721.9849-1-alexandru.elisei@arm.com> <20231119165721.9849-16-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 10ABE2002C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: woyhpn5n1y9yybnxmrqb5azxih8u56td X-HE-Tag: 1701097841-61070 X-HE-Meta: U2FsdGVkX18OQ/HSYpCU5iCpc3VJgaCspPnqNQUMZTxNU6YAlwJ9LpagrKk+GMnrjZ5ZicdZftHL4FFALvWZsyE//XUJ+Zuj5mpm8b8alrb7OiIWWH47SUVCXATA8mbI8N6NOl2zJIwN/LQ3bHAKI+m+nox5O3UnnD6PwGKvopIwhVTodl9tQv7qtQLyMFujnVzM023dDlSQS95757du/Dj8lcqXXwSzLP18oigqGTUhuXQxrDe0kkLxwdldM2qBsGZPbH7RcU3Ou39HXeUPGo2EHRgvdjX9DIns61e6rdnaI7pqfCUBvQ3DzjYcnmFRMiN8eAaK9NrS31lvJyOF+H9sbb51u09l6lG37+tibZiEP80pf5ucczTHk36nT4ZKuxavXGijdas9+W3sWf2RZR4MV/SXunDMIMRp0TXLvXqLL4gPmnNzrPw+CIDRZsel5UnCHZTyRXymdlYoU3KbYIcftD9iprz3h0FB4ykokKoTgXzyEpoLDWy37BqsAW7l4wdAgyGcr7tE59F7UsRJ4z3zFE/w5/j3CLqDm+F73w0cLF8xigaiAn1pzmwvreAJUptIOod3QWJlYagc+HdY5GjbXMPpZq60yCsaTjyL3mQQi4rAHlcUyUZXWO3Ly2VAK22jrtOKRCwiWVmmASfybqWNHTc4Hnv9FcjhUOj4RuTURY3z8JmdumUd5ySl80mrEjHrMZN+6VK8jGktGLc4tjgACujTuXVWJNT3PjFzZWkQNEsTvLIsvclvgB+YPAEuF/g01k7pHtphJHiSvryKuTxJ86UFHvC3ihvgi2v/l6Dg5Lb9Wu5TNdswCGnmyyzx3h76JcYaU0JHbjY+78oBwH+EIkAT0dEeYb6UZs6yh7bQBCM91JdDIsTayTsh2tFIEsS1JDDg5biqIHswy6jZarowDeqipcdwx9bZoWJZoRgHDnp8thZ9rwHbWsHYETWnVzTGw38pwI1+JrgdPPl EHT9QpwP E0sUlxOw4AMcao8t/U3g+jdedvewJw47D884kzMR3tVJlqa1vLQGuLRNyOYWxILCHTpqhYY56jF8H5QEUPFQmhIzLKXLj3gpjXCb+dygZJ5HsBweZ240oZggsrn96lzRX/hdDeGBpdTCnTLTsrQty/XjPpInPEopPyikVvCa5L3u9vNxrepqD1+MttsjRKbhLXSdhAOEcmbhaquDBRukfoUhgev67fDp01ht2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Fri, Nov 24, 2023 at 08:56:59PM +0100, David Hildenbrand wrote: > On 19.11.23 17:57, Alexandru Elisei wrote: > > alloc_contig_range() requires that the requested pages are in the same > > zone. Check that this is indeed the case before initializing the tag > > storage blocks. > > > > Signed-off-by: Alexandru Elisei > > --- > > arch/arm64/kernel/mte_tag_storage.c | 33 +++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/arch/arm64/kernel/mte_tag_storage.c b/arch/arm64/kernel/mte_tag_storage.c > > index 8b9bedf7575d..fd63430d4dc0 100644 > > --- a/arch/arm64/kernel/mte_tag_storage.c > > +++ b/arch/arm64/kernel/mte_tag_storage.c > > @@ -265,6 +265,35 @@ void __init mte_tag_storage_init(void) > > } > > } > > +/* alloc_contig_range() requires all pages to be in the same zone. */ > > +static int __init mte_tag_storage_check_zone(void) > > +{ > > + struct range *tag_range; > > + struct zone *zone; > > + unsigned long pfn; > > + u32 block_size; > > + int i, j; > > + > > + for (i = 0; i < num_tag_regions; i++) { > > + block_size = tag_regions[i].block_size; > > + if (block_size == 1) > > + continue; > > + > > + tag_range = &tag_regions[i].tag_range; > > + for (pfn = tag_range->start; pfn <= tag_range->end; pfn += block_size) { > > + zone = page_zone(pfn_to_page(pfn)); > > + for (j = 1; j < block_size; j++) { > > + if (page_zone(pfn_to_page(pfn + j)) != zone) { > > + pr_err("Tag storage block pages in different zones"); > > + return -EINVAL; > > + } > > + } > > + } > > + } > > + > > + return 0; > > +} > > + > > Looks like something that ordinary CMA provides. See cma_activate_area(). Indeed. > > Can't we find a way to let CMA do CMA thingies and only be a user of that? > What would be required to make the performance issue you spelled out in the > cover letter be gone and not have to open-code that in arch code? I've replied with a possible solution here [1]. [1] https://lore.kernel.org/all/ZWSvMYMjFLFZ-abv@raptor/ Thanks, Alex > > -- > Cheers, > > David / dhildenb >