From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 249FFC4167B for ; Tue, 28 Nov 2023 10:01:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B24266B02AF; Tue, 28 Nov 2023 05:01:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB23D6B02B2; Tue, 28 Nov 2023 05:01:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 978066B02B5; Tue, 28 Nov 2023 05:01:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 880076B02AF for ; Tue, 28 Nov 2023 05:01:21 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 57A2B160178 for ; Tue, 28 Nov 2023 10:01:21 +0000 (UTC) X-FDA: 81506920362.22.37FF4E1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf18.hostedemail.com (Postfix) with ESMTP id 0FD031C001E for ; Tue, 28 Nov 2023 10:01:18 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="Std/ba/o"; spf=pass (imf18.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701165679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b0MjlIE5+pSQxzqkC8I7wOjiha8vGuuRwI00+7CVoNo=; b=WtSRYslXJmQAjrBplctCZWaWly0aLw91YFIF891EbHH/JHiYAv7t9/12gLYOH0Tbr2DP5z 5+A1xazm1SelaKuE5Fa/b4DhbckBP7tH4iFfqF7dBCi7bDK+qSvCfqmOy2n52B9EB5clWS lzv8UG2wppg5wKmdCc4Vt7vOe4Zxaos= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701165679; a=rsa-sha256; cv=none; b=sTOXlJpKeGnFjdHeAJDlwrrERQEJFcO3f/e0w5k3HPNlezZ8wUQllyCFw1x2OM/ViW1IsD uus8OhmHK3cS6RGxl+Be/HehrXjyoCmrbiRMeJSZQPPhAIEfBcg24N5ItUX5PAHTVH9vrT SuO/o4wuy39k2nkCC20CSqZ+mKapdu0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="Std/ba/o"; spf=pass (imf18.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 623C521904; Tue, 28 Nov 2023 10:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1701165677; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b0MjlIE5+pSQxzqkC8I7wOjiha8vGuuRwI00+7CVoNo=; b=Std/ba/oUYZ6nwnpUkxVkPN1odNxP+SlbOGfRn+ACrFB2uDr9iQ8DQO8/siTX0+jxulPC4 pQMkOQNZCAVww7AnkLJz2LTe9dTkOQV1UI72px6ev5OANzWzrhf7jduONBUv/RZtFgNujo a+EYPv8x3pS3AtfxzboEQnz/9l/VNW4= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 42B1D1343E; Tue, 28 Nov 2023 10:01:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0sw8DW26ZWU4aQAAD6G6ig (envelope-from ); Tue, 28 Nov 2023 10:01:17 +0000 Date: Tue, 28 Nov 2023 11:01:16 +0100 From: Michal Hocko To: Kent Overstreet Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Qi Zheng , Roman Gushchin Subject: Re: [PATCH 2/7] mm: shrinker: Add a .to_text() method for shrinkers Message-ID: References: <20231122232515.177833-1-kent.overstreet@linux.dev> <20231122232515.177833-3-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122232515.177833-3-kent.overstreet@linux.dev> X-Rspamd-Queue-Id: 0FD031C001E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: torfaafkzgxfuac568wqc54fqykkg5gt X-HE-Tag: 1701165678-464878 X-HE-Meta: U2FsdGVkX19X06fIVdRIHq496DCer4ktKKEduayBqbM0kjIWYcLrB9rtDksfNrI7orZKdXtU7zxSROVd2LnGHdZSn21OP5J9QN4pfgPHFbKe2UPy6DZuPiOlIG6D+3MdSUomLraj2M1SopFE6rqLVRXN0taSqfLVeGqhoRzSt+7CMls0sKxBs7qZiGwp/9XE5O0YzaUzNB8n+vABjE9V9RmF+5kY61XCOj/SvqTb5Wa7Y9Pb7kKxNfH5mWxbD+xj9wLftFroAHBPaXqKDatuNSPp2gUiYBbdXtXYV7bGVj9iCPh38BuzgkNw7enukqWvQhSJTajWvgzrXHdrcdl03venL7qO9NE++LGC0EkFIWkEJJtKqtGBX6FJciEryJNq4jDpprytB9IkFqHBpzxYqCIuVOr0h3UeAT9kHgrihdnGgWOI2/QspxPVVE0XfRTlqIBHuncCENaTcgkkW0L1FuVtMT4HN0jiKc3X5Jp7xZueTZeMJXUohXcoV5j1EK5zkZfRTBwagI6yBFSQfNAQ8iMpmWXGuSxjf8g3853Tv7Rjmwzp8+w82TI2BzdKJkZf69EqS2VKawB69EoqqnsMLnVdd71po4Z6H6qEn1Ju7K2Gz3zNdvGfXqBoym0H1DtWpeNFBYp/X2L/SBvX/serriLAYUtnnsdbUnxKSEOS+ya+tOl5wV4/c5lzlpgpSVXFIPRbztPlqXukMb1GPI72CWwXx6lo9HKXN8FsRaXdmp3jUc8b8zjYBg6T10G5EsiXZtWrSzh53lerohxRK2rZCYX4icRAaSNnydaWL/NdVkHJWDvOvqG/ittVIulgImmfG95JQYeQJgVvnO07sWkcwF0jS04HIzIA12cqlul/syMzQKfYrUtNJ/59AIsaFMnUH5r2AGviPMeGGqcKOO1gNcJQr1piw03IVpYXlAAowAUdKlx8ZWiVZf88oedmoD21w2vkFY67ota0hqwMtaI odVhkN2s 7l1jgT5a4/ZSAaj4LLvwwW2iDSuuyiBuyF3Xp80SJDJpw9ykZJwhxQF2fCOJ4bGxofjcCLV+f8ZroplLWfaigNrpPGAY0FHuSkxqoWxroQkFrgChKoWGbx+h18NRHvdSZeSgTAIXR3MxNmqVuM1eb8u/t+5xcNP0J0RfM2qIC3R4Ysmes93HgJunglbqBP7dvJQyM2u60uG2gJlmo10YRyEYi4hRLqbCc8VUXfl86Ry8SuB37MeAyd+j6Y2csR2W1EPMg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 22-11-23 18:25:07, Kent Overstreet wrote: [...] > +void shrinkers_to_text(struct seq_buf *out) > +{ > + struct shrinker *shrinker; > + struct shrinker_by_mem { > + struct shrinker *shrinker; > + unsigned long mem; > + } shrinkers_by_mem[10]; > + int i, nr = 0; > + > + if (!mutex_trylock(&shrinker_mutex)) { > + seq_buf_puts(out, "(couldn't take shrinker lock)"); > + return; > + } > + > + list_for_each_entry(shrinker, &shrinker_list, list) { > + struct shrink_control sc = { .gfp_mask = GFP_KERNEL, }; This seems to be global reclaim specific. What about memcg reclaim? -- Michal Hocko SUSE Labs