From: Matthew Wilcox <willy@infradead.org>
To: zhiguojiang <justinjiang@vivo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH] mm:vmscan: fix shrink sc->nr counter values issue
Date: Thu, 30 Nov 2023 03:29:27 +0000 [thread overview]
Message-ID: <ZWgBl07bJqrLTpzZ@casper.infradead.org> (raw)
In-Reply-To: <dc01e0d2-17db-4531-bc7d-7d637d96c2f1@vivo.com>
On Thu, Nov 30, 2023 at 09:56:59AM +0800, zhiguojiang wrote:
> > > - * If kswapd scans pages marked for immediate
> > > + * If kswapd scans massive pages marked for immediate
> > I don't understand why you've added the word "massive". Do you mean
> > that the pages are large, or that kswapd has scanned a lot of pages?
> The added "massive" means that there are a large number of pages marked for
> immediate reclaim on evictable LRUs.
Then the word "many" communicates your meaning better. "massive" would
mean that each page is very big, while "many" means that there are a
lot of pages.
It was foolish to send out a v2 so swiftly. Best wait for someone who's
familiar with this code to respond to it now that you've clarified what
you were doing.
next prev parent reply other threads:[~2023-11-30 3:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 13:01 [PATCH] mm:vmscan: fix shrink sc->nr counter values issue Zhiguo Jiang
2023-11-29 15:17 ` Matthew Wilcox
2023-11-30 1:56 ` zhiguojiang
2023-11-30 3:29 ` Matthew Wilcox [this message]
2023-11-30 3:40 ` zhiguojiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWgBl07bJqrLTpzZ@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=justinjiang@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).