From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A02FC4332F for ; Tue, 12 Dec 2023 01:23:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07B4A6B026C; Mon, 11 Dec 2023 20:23:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02BA66B026D; Mon, 11 Dec 2023 20:23:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5C5C6B026E; Mon, 11 Dec 2023 20:23:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D5E826B026C for ; Mon, 11 Dec 2023 20:23:11 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9CBF080912 for ; Tue, 12 Dec 2023 01:23:11 +0000 (UTC) X-FDA: 81556417782.27.C642D34 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 9863A18001F for ; Tue, 12 Dec 2023 01:23:08 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bR2SP71R; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702344188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MmWLQ8S7dWkSauCMe9+QRo60HBpBohLa6sWyfno5d6Q=; b=fgbab6eZwfqRfeTqFFkC86CQUaH0o7Vh+xSjRk+XCtNEFgxeJ9DxSHxddR5HW5UOlmWnaa m2eLiPVdCbepoJu0CwDdPCFjKQimudiMM+QSGQrhCez4gGKQ5L4/J0RIoQ6MS5UonN2PMI hHb/O05UEGFyIR8gLZt0MJGUPQzx68k= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bR2SP71R; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702344188; a=rsa-sha256; cv=none; b=zzWSiud1YUPvFGvyD+sY/vVvBzbNkmQxQUpipRBbBjuzDXsp1Y+YCNLsmBE5pJYf/3ky0p /JaD6JCFxzRQV5oZXL2D2RaNJIDS26dWK4KGiEfdkPvn0+SXoAM57z7HsaRLOAL8SWYIid l7eDYdZ+KQHKBADEBjWxIs4LL+gWOMc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702344187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MmWLQ8S7dWkSauCMe9+QRo60HBpBohLa6sWyfno5d6Q=; b=bR2SP71R4+T4BiSkygZuaojK21zhU3FPtfh0jk6O912Lim90riXaAsPT8unYQk0GMtsKqz JfhkSLp/waygtbJeyCirk+oU3bidzT43V5GXShdnkSz3997skw0MPB8bXvMaPbur4rCRDh aZW5xMvktbms/Qm9dyRfZaZNTmB/Vko= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-o1RwP8zqOfKVizhJ0VPGhg-1; Mon, 11 Dec 2023 20:23:06 -0500 X-MC-Unique: o1RwP8zqOfKVizhJ0VPGhg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EBAA21C05AA0; Tue, 12 Dec 2023 01:23:05 +0000 (UTC) Received: from localhost (unknown [10.72.112.218]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47DF12166B31; Tue, 12 Dec 2023 01:23:04 +0000 (UTC) Date: Tue, 12 Dec 2023 09:23:02 +0800 From: Baoquan He To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Subject: Re: [linux-next:master 6231/6992] kernel/events/core.c:7477 perf_virt_to_phys() warn: always true condition '(virt >= (0)) => (0-u64max >= 0)' Message-ID: References: <202312120428.kUWabWlC-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202312120428.kUWabWlC-lkp@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Stat-Signature: bxxp1nym1hd7ahhx49zq6psukuczdico X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9863A18001F X-HE-Tag: 1702344188-800664 X-HE-Meta: U2FsdGVkX1+j85KP99CIxQ+e5Rm73WRYDCi5utIgodKzwFpy+u/U4h7QEeN+r0K7UIbujwfuMFwrw8nXmTeAV75la8KDod0TcHkgc1fo7CaWmhjCxXlj7Be489RIOSaTsgA6VLqQfAcE9NRXvpUMTSCLcRP7K9PHJ9bsAKZg1oqCBjgHaWx8CtGzNToPatJyj9bhLYoAvFpELz0b5aKBHBeJVlsiFjU2bBFeoJUfLuAdt/wPdfNXtWGUvuVucpxROBvtr1jpMj+0XydSMkI+UgwPzM2avqe8czVU4o+mk1n41N9CD6anz9TIgipnFDAUNa4xeDZQ+7tq7IxEoVIcPE7ty8vOYs58SmRGkEaCLYhJozsD05aTsTUltTCs9LRyfizBn3+/qkSc/f1J/+6wwqYaEUieCJxPIiHOrsBLcai4FcTEr6PTWBXd/UX1N6p8YVp346Ve81s4w8RJLvzYYilb73slcYPc52dMUfnAbEn/KU93kwuohLmfTS99NYT4vUblH4KTFQCkPlRYnUE4wFccd2NIooWebPxznFZCVV8N2kgdGFr7g7wapwmYPAClm7w6pUKGoQo7Xb2Wef2Pv9oyyqRxFsNBBs0DCAKhxbjsPBXNfYaa5Zd8QG1GRpb2Ary0xrNL4c7y2bIKzh09wkN46gwX7RW8avryd+j4JfRpWpTEatxnqxVXsvRsYRetRJI4bH0pUatIg9/KZlqy1whk0Y5hMLom0XeZnsC7DaMK4TtZ7P8HRKXfkYuoRGaE3d9vkRXiK3Xbqd7ssZFkWEFVNn/Ofyayz3iDdGGypmWvkETEOaBWs8SX8Fy/zfytiaMwICFlXF4qBEOaqt7uEUrt0z/XvNOU6oIfuceqeV7QAxRFmCRUOgtVNhwnDlkLPgHoy2UzEbCJh9mD4zahR5aDW8LEF9JdZUAPFexSqaSlPmQNr2f3/O57AxFpr6F4T5QT1fM3BnLzHdty1eh XpAkrxDT cz6c10k5J9nR+ahVyrHIyyBH077oyYsC2+bDLnRNywAjGvfaAj3o9jM3w1BJmjiog9e1LfHLwNlhK+fQ7QPqVkWmSNS2l86QTYH5S3VWkIZDOuvTVb00OV7LF945qY5rU3JFnczYNX98Q0CyUGBgS24lI/Y3UGDYzdfB/i6qdP0HvCf/kjv7tEFBo0/3/cPi4nPg75j7F/WYr6/QX8mesMxsE+HsS51JgntaYxeW6a1R4vohbj2J1jPG49teZQDOiwMibaogqtxEdCDkVPToh9CeYB12dcEy1qd3otxhNsbK5oe8eGpfRPzAUqCOH/YjQuZyTUUWSCt1t+LF4nCotfQkC7U8q9Zu6KIQA2KRIp83f7A3qOkv3QePV4TdfR/hKbdPTLRhAkclF5N+uNJ07828NGc93behE/LAN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/12/23 at 04:37am, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: bbd220ce4e29ed55ab079007cff0b550895258eb > commit: 8a651e8f1fca74c7c2b033d9a0ad5214ac5d46e4 [6231/6992] riscv: fix VMALLOC_START definition > config: riscv-randconfig-r071-20231211 (https://download.01.org/0day-ci/archive/20231212/202312120428.kUWabWlC-lkp@intel.com/config) > compiler: riscv64-linux-gcc (GCC) 13.2.0 > reproduce: (https://download.01.org/0day-ci/archive/20231212/202312120428.kUWabWlC-lkp@intel.com/reproduce) Thanks for reporting this. While I can't open the reproduce link, can you double check it? > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202312120428.kUWabWlC-lkp@intel.com/ > > New smatch warnings: > kernel/events/core.c:7477 perf_virt_to_phys() warn: always true condition '(virt >= (0)) => (0-u64max >= 0)' > drivers/clk/ingenic/tcu.c:455 ingenic_tcu_probe() warn: 'tcu->clk' from clk_prepare_enable() not released on lines: 455. > > Old smatch warnings: > arch/riscv/include/asm/atomic.h:225 arch_atomic64_fetch_add_unless() warn: inconsistent indenting > arch/riscv/include/asm/atomic.h:204 arch_atomic_fetch_add_unless() warn: inconsistent indenting >From the config, it has: ------------------------ # CONFIG_MMU is not set ------------------------ On RISC-V, we have definitions as below. So this sounds like a redundant warning. I will see if I can mute it anyway. arch/riscv/include/asm/pgtable.h: #ifdef CONFIG_MMU ...... #else /* CONFIG_MMU */ #define PAGE_SHARED __pgprot(0) #define PAGE_KERNEL __pgprot(0) #define swapper_pg_dir NULL #define TASK_SIZE 0xffffffffUL #define VMALLOC_START 0 #define VMALLOC_END TASK_SIZE #endif /* !CONFIG_MMU */ > > vim +7477 kernel/events/core.c > > 5622f295b53fb6 kernel/perf_counter.c Markus Metzger 2009-09-15 7466 > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7467 static u64 perf_virt_to_phys(u64 virt) > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7468 { > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7469 u64 phys_addr = 0; > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7470 > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7471 if (!virt) > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7472 return 0; > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7473 > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7474 if (virt >= TASK_SIZE) { > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7475 /* If it's vmalloc()d memory, leave phys_addr as 0 */ > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7476 if (virt_addr_valid((void *)(uintptr_t)virt) && > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 @7477 !(virt >= VMALLOC_START && virt < VMALLOC_END)) > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7478 phys_addr = (u64)virt_to_phys((void *)(uintptr_t)virt); > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7479 } else { > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7480 /* > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7481 * Walking the pages tables for user address. > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7482 * Interrupts are disabled, so it prevents any tear down > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7483 * of the page tables. > dadbb612f6e50b kernel/events/core.c Souptick Joarder 2020-06-07 7484 * Try IRQ-safe get_user_page_fast_only first. > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7485 * If failed, leave phys_addr as 0. > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7486 */ > d3296fb372bf74 kernel/events/core.c Jiri Olsa 2020-04-07 7487 if (current->mm != NULL) { > 4716023a8f6a0f kernel/events/core.c Greg Thelen 2021-11-10 7488 struct page *p; > 4716023a8f6a0f kernel/events/core.c Greg Thelen 2021-11-10 7489 > d3296fb372bf74 kernel/events/core.c Jiri Olsa 2020-04-07 7490 pagefault_disable(); > 4716023a8f6a0f kernel/events/core.c Greg Thelen 2021-11-10 7491 if (get_user_page_fast_only(virt, 0, &p)) { > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7492 phys_addr = page_to_phys(p) + virt % PAGE_SIZE; > 4716023a8f6a0f kernel/events/core.c Greg Thelen 2021-11-10 7493 put_page(p); > 4716023a8f6a0f kernel/events/core.c Greg Thelen 2021-11-10 7494 } > d3296fb372bf74 kernel/events/core.c Jiri Olsa 2020-04-07 7495 pagefault_enable(); > d3296fb372bf74 kernel/events/core.c Jiri Olsa 2020-04-07 7496 } > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7497 } > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7498 > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7499 return phys_addr; > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7500 } > fc7ce9c74c3ad2 kernel/events/core.c Kan Liang 2017-08-28 7501 > > :::::: The code at line 7477 was first introduced by commit > :::::: fc7ce9c74c3ad232b084d80148654f926d01ece7 perf/core, x86: Add PERF_SAMPLE_PHYS_ADDR > > :::::: TO: Kan Liang > :::::: CC: Ingo Molnar > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki >