From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A36C3DA6E for ; Sun, 31 Dec 2023 13:07:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D2596B00A5; Sun, 31 Dec 2023 08:07:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 982BF6B024D; Sun, 31 Dec 2023 08:07:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 898686B020F; Sun, 31 Dec 2023 08:07:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 76B496B024D for ; Sun, 31 Dec 2023 08:07:25 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 548591A020A for ; Sun, 31 Dec 2023 13:07:25 +0000 (UTC) X-FDA: 81627139650.27.762C379 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 04FC4180005 for ; Sun, 31 Dec 2023 13:07:22 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vd+WJ1ej; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704028043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qgrieap/ole6x6jYsISD/ePi3BdA5BVA5GTXQ+NppF8=; b=8TQppBCSwg8wZ7XXqwW/gr1Mv3rdFwQ0xJGtscpWVktFXBSzTF4d96nRYXYQC2Eoh9U8OA 4yMTDThlKtI8ORzD1ivytwN4QJ6tiQO9qD5yB0P5BeVJ8HYWcfE59hbJtHMC+4bEuSdvcx kYQIQaDdHhFuRLfobrB/FjzoKAoCkJo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704028043; a=rsa-sha256; cv=none; b=JYonCQM5ahvh1K7w0/N3k2IBl6fhSdth4+On73b0+OV59ZO8031w7+DOHFqdKV933HHhnR IMEboMh1ilhhRJU5uIpOw/cZm4Q6NG+6HVNVzsEGlwLLCZv5EMBaBW6Z9eanJrirosQX83 QONZAk42LOuv0fBahs1HpkEBtDDNNQE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vd+WJ1ej; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Qgrieap/ole6x6jYsISD/ePi3BdA5BVA5GTXQ+NppF8=; b=vd+WJ1ejSpDkbMALMRIQ/s2vTl LL0gwyRqKsqKp8i+9VpptdcjB4juRO5y6b8zARSBmABKf8PGUAMle9KVhdTXYTf0Am/saSQXw04uU 6FKKnvptyzbh+H/34h9ASMoZ9/1umfKgtOX/JXOJOScchowUFOR0tRuRao5DVTKh2Fy1AWQvpuz5K 3FLRaIY25URYIf9cbU4DrsqLzrDYRc5T1JT9HKZFAzOhsA47apLLIhtJhj6zxqZc0i634KOliIqYg cdmqun3zNvB981cxyf71clmsF97kLsiBoyDdV+29moFlm6vtwuPtkcM185TGn/GRbXFMIK00u+C9F ed/sgQcw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rJvWx-007p83-SY; Sun, 31 Dec 2023 13:07:03 +0000 Date: Sun, 31 Dec 2023 13:07:03 +0000 From: Matthew Wilcox To: Hillf Danton Cc: Genes Lists , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: 6.6.8 stable: crash in folio_mark_dirty Message-ID: References: <8bb29431064fc1f70a42edef75a8788dd4a0eecc.camel@sapience.com> <20231231012846.2355-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231231012846.2355-1-hdanton@sina.com> X-Stat-Signature: uexas4qtcqbe5i8j9f8t4ur93bwswrhz X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 04FC4180005 X-Rspam-User: X-HE-Tag: 1704028042-757812 X-HE-Meta: U2FsdGVkX1+ji/9s354j8IxjYUkPm3z3VZSUeDbF5VLRSwC03KaBQMBQp45+NOwhJyC19sY+akMbMd9SFz5PiDWBtFCIjfo2g3jycixlw13iP6/5KOvVvWE9dNr+LbeWLcc2Q3KeAhQqrIo9P4d0+KAGykh2RHpyrKpBL+bUbcbIQ+9tdGHLsdRP/xd8WbgZQw1G8zInBpGeaAz44FqNq02RvrSJiCtG/YQLK8JqJWAaBO+/bdGoDHme1Manmj+i2g8kXa2BYWyUck+BIlAw5zAhobgY7mK8RLJy6uBaJJwrpGtAq2Ddn1DUT4rSjsTdr71gX7th3ItA+X6krZU+uo+xbGxVFxgzhEN893Y1O6sYkquxtK2YIZMEV4fuPgvexry3M5ymVfQs5R+GBmOa43mdJNxtcosvPIEs7fvt018T0GZHh/BpVi2qxrWyVvu576loKaUIIFQh1qEiY/300XFLpPyct1N1gapU63DEn+sCMHd2qan0OdkpxEL4dHYqZ5Wa1hKb7iA440adjzVWVm/2xY21qruJaZUpuKG8ZGcZ5SZvmyi9l9o8J+Qx4+KODHBgh61I7GQI56JXyBmCfJjK8CnALqp9ZOdvIVMiV6w4DxNN7FBrr0pEDzpz/L7mwDzFwp/1dlgD9gaeUruqPwZzwdGkG6HZHhYgp0gOrCJTt7iOLsGMWn9g/gMGeVAgu8kwYcpVOMnrWq4MhxCTL5leK4z/3DbLfZVZL8S+IZZelbsY1KuFni9b3nMNZm19vWb+MuoVZ+k2M0CtGAoKYUd0qi1DaGoS70Huy4gCvVar+Lu7NaXs3Amt28RiBdXCddwQVVS5vOOjeaG7tsSIlU0ZgT7DVSbom477/Q9pM8uvN3wpOSvlHFaMFwRPv2VnATuh+ITc5aqXBIBpc1omG6xvNoVfB9eqX86iLEfQKeqDep94T1W1aJAi4O8oXn6uUN6Jvv2AUAjdknBb7Nz b1yTSUiD 8NKYOhyiA0HxB53qlSupBBrzuEaIxeQebrU82hM0f9wySR74Q8ngBp7bTp3/gi1e/7ecMr/yhj3J+ao7w1VVIa5w8ovEuWy+gaxEhwBrCcUniqarpIFw/pDRhMnSoJjArSQk0G+4r9G3s/qy2L0Cq6LenRWDZsfpjvVr2OnhUl9QufUmIPu08hHQJavxbWOR9mvpebL+yPIZ4B03aN7HOzu0qbI6H47TXBiv7g+BacqWAly0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 31, 2023 at 09:28:46AM +0800, Hillf Danton wrote: > On Sat, Dec 30, 2023 at 10:23:26AM -0500 Genes Lists > > Apologies in advance, but I cannot git bisect this since machine was > > running for 10 days on 6.6.8 before this happened. > > > > Dec 30 07:00:36 s6 kernel: ------------[ cut here ]------------ > > Dec 30 07:00:36 s6 kernel: WARNING: CPU: 0 PID: 521524 at mm/page-writeback.c:2668 __folio_mark_dirty (??:?) > > Dec 30 07:00:36 s6 kernel: CPU: 0 PID: 521524 Comm: rsync Not tainted 6.6.8-stable-1 #13 d238f5ab6a206cdb0cc5cd72f8688230f23d58df > > Dec 30 07:00:36 s6 kernel: block_dirty_folio (??:?) > > Dec 30 07:00:36 s6 kernel: unmap_page_range (??:?) > > Dec 30 07:00:36 s6 kernel: unmap_vmas (??:?) > > Dec 30 07:00:36 s6 kernel: exit_mmap (??:?) > > Dec 30 07:00:36 s6 kernel: __mmput (??:?) > > Dec 30 07:00:36 s6 kernel: do_exit (??:?) > > Dec 30 07:00:36 s6 kernel: do_group_exit (??:?) > > Dec 30 07:00:36 s6 kernel: __x64_sys_exit_group (??:?) > > Dec 30 07:00:36 s6 kernel: do_syscall_64 (??:?) > > See what comes out if race is handled. > Only for thoughts. I don't think this can happen. Look at the call trace; block_dirty_folio() is called from unmap_page_range(). That means the page is in the page tables. We unmap the pages in a folio from the page tables before we set folio->mapping to NULL. Look at invalidate_inode_pages2_range() for example: unmap_mapping_pages(mapping, indices[i], (1 + end - indices[i]), false); folio_lock(folio); folio_wait_writeback(folio); if (folio_mapped(folio)) unmap_mapping_folio(folio); BUG_ON(folio_mapped(folio)); if (!invalidate_complete_folio2(mapping, folio)) ... and invalidate_complete_folio2() is where we set ->mapping to NULL in __filemap_remove_folio -> page_cache_delete().