From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4B78C4706F for ; Tue, 2 Jan 2024 03:38:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31E1E6B0279; Mon, 1 Jan 2024 22:38:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F46C6B027A; Mon, 1 Jan 2024 22:38:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E3A06B027B; Mon, 1 Jan 2024 22:38:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0FD6E6B0279 for ; Mon, 1 Jan 2024 22:38:46 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A2CE41C0ED6 for ; Tue, 2 Jan 2024 03:38:45 +0000 (UTC) X-FDA: 81632964210.03.55F30B0 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf21.hostedemail.com (Postfix) with ESMTP id 901C91C0010 for ; Tue, 2 Jan 2024 03:38:43 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="DbN/lWB+"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of jszhang@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jszhang@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704166724; a=rsa-sha256; cv=none; b=ZbTS2jYZktJItH1fw7JqmiV28MtiGevsllLj4tc5QQ7xabmwqrrY9JXwO+E0sIiemSPAid p0Uvtc4CzEWSRkdShEdJP0ozpt0eKgIAmLKUb56kpwQOg7lscKbPGqI+t1Qs6PAos3mitc bMoiasmN15mPJVu+hBIj8JbS0BmE39Y= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="DbN/lWB+"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of jszhang@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jszhang@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704166724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kcTdkEAbGCppfv+ACYR8FvNGo0MMHUvFLqTzw3QX8ZQ=; b=GM1OuYx5qWAW9wNa7J1X7D5atSAKSAj69eBpo2t6tMTlmrTgyZHfdn3Tuj/iUPnBSq9qd0 ZonMjFL/zrwS4Y1ZOcTvZ9yKR0Sz0p+QQJZIJHAxImxqe0XHplROGg1AudWg70nqAvY6pk bt1nYmX4SFe95xQi6EPkQ5t5NlxltEs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 83D21CE0B79; Tue, 2 Jan 2024 03:38:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AB25C433C8; Tue, 2 Jan 2024 03:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704166719; bh=sqjF+WOs+/Ej1dm+kRiv34bMwdUQi5o86nzg58LpkDc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DbN/lWB+mMNkcDOyfAmuvldxhZoz4+kmWPEmLA5B/1PxsWD+5Xj9PbHL/KBycP2s7 MbSOthA8nrqgEAtFNpFEVqdPKCLGdpuXc5yrseVEOo8mywulDkMIwrtjFRLZ5Z0ow6 +dG4bf9OIEIhFG8PZqpj2Ot0E2qYPmEPF6uxR7qV+wvk+6Yc+KBGZ8F0USKJ6ug7+G fb6Wftzh6J+fChGZOY7FDMItIJNS7+qUpEkZRH6THKmgmAILrvooJ27F1waBhFNnHl f0/EiSV4Uox/QrDzrFAniIXnpNTapL7vWjUpw/uTFe3s3lHIKEXedq+RFWmB6jNZ/9 Vs4F5EdGiP8Ew== Date: Tue, 2 Jan 2024 11:25:57 +0800 From: Jisheng Zhang To: Alexandre Ghiti Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/4] riscv: enable HAVE_FAST_GUP if MMU Message-ID: References: <20231219175046.2496-1-jszhang@kernel.org> <20231219175046.2496-5-jszhang@kernel.org> <3d36ca3c-9a91-41a7-9e68-288982c2c8a8@ghiti.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3d36ca3c-9a91-41a7-9e68-288982c2c8a8@ghiti.fr> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 901C91C0010 X-Stat-Signature: e9rbosjw7ofinneesggextd71spfr3tc X-HE-Tag: 1704166723-427225 X-HE-Meta: U2FsdGVkX1+O3QwS2NGNbN0uGUEoVnmfzQ0RbU8JwZW3+bz+Xesbq9jzBTBhXzkyFLErzw1f/jNZXoZtA1yoLaTnJ7l3VFzT9h3pF6krCTtYdjfruNVjHKE6EE0EgqTUssWtrSzZh11qMVWoiD0QZalmIi1KMi3DPXv7SQFIRgcG9az9MlcJH9KkBf3yWTiiTVsgxUmnidkbN9VxYUf1cIPZC8sEtIwIqwMJ+3Faf75Zw8vhACAYdHIfGpsA2xAYvqraatY7QHXIYuhs5PAmrtNgXrrc2voAovZ8JtfvUl1EnI9dh2Pn/MdwJtJKY19Z6FIjdxOBrn4VvKSih2SewfYfbxM9u/3YqtoiYh+9mZJ1c2VpZuAYlV0ROXKGw7tHq4hkSDIH3cF+iEhAilh+ygHTnzwWsuyCDElIGVK+uOvzNcIoyOnsQkV8X18dZ85n2NP+4lBHLD/3Rl/+TI7BEbBWiTtC+ZfVXcFVQQUbhC49YMcGk3IvE7kWHOFALkU+31SKgHl3l7rmP0GhFYD1ApGGNGzd52wCa/lP+dBWVMZTPzgrCmVFCvlJaSfJaV3M4LA6DTLIEXU2M7j/vI9zW7fpL+m3iBLnrgsljbs4bsUqBNwmEtd53izpl051KKirGM8sLZ9vnRf455alxzrxgkr68xWn37Bz5sHdkVf2e5+yQpe6TinALWk7J0Oo+kX+G5jldbxU5nbQO4Q+CW8ClEgjQL1Hyph0QZ+BpNWxTOdZLw80Kvq4/Gdgxt35srGOHNI5XpTh+1uorIWeIPqEyuNP+G48zQscetKBRmJ/nAAjt4ohX/RC18SyFvACM3ZhPxnHjs0txeu7tOeFAcO9orXbGDdzxp4DV4afr9HvYwHEbQAEV1m1XRnLy3RNTNjEsErAVCce1WYn73vqsbcIsXEBLV7DPa/MICn56kVVqeiO+lQVUyTgl6YPD4mId/taLoXvn6DHGUGzgLmvmie +HLlT8uz V9bdA8GU42k06kckS7dNF3jl/um2z/lQCl0o6o9X2D9EKUct7r3/nmzDEIOoLHGY962OO2BYwS3YxqupHEGidiRqRWLNrXR1hiqhl5IvQyTk2SNDKNre8nXLWAahYUuNuwlmruPe6UlkfAnxmM9UdS4Wpl3UxAzocjoXj+uE5OesGT6ejb76+z4UeQUDaAQ1qhHfb+tvQU7uePCOyoZOeMe1eCLb509SN5fDmydxQovA+PS+GcPe4bptIJ+m9xKv950lp6+qdt8navWKjknDe0TBsicsLGGlM9g6C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 31, 2023 at 07:37:33AM +0100, Alexandre Ghiti wrote: > On 19/12/2023 18:50, Jisheng Zhang wrote: > > Activate the fast gup for riscv mmu platforms. Here are some > > GUP_FAST_BENCHMARK performance numbers: > > > > Before the patch: > > GUP_FAST_BENCHMARK: Time: get:53203 put:5085 us > > > > After the patch: > > GUP_FAST_BENCHMARK: Time: get:17711 put:5060 us > > > On which platform did you run this benchmark? T-HEAD th1520(cpufreq isn't enabled since the clk/pll isn't upstreamed, so cpu is running at the default freq set by u-boot) > > > > > > The get time is reduced by 66.7%! IOW, 3x get speed! > > > Well done! > > Thanks, > > Alex > > > > > > Signed-off-by: Jisheng Zhang > > --- > > arch/riscv/Kconfig | 1 + > > arch/riscv/include/asm/pgtable.h | 6 ++++++ > > 2 files changed, 7 insertions(+) > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > index d3555173d9f4..04df9920282d 100644 > > --- a/arch/riscv/Kconfig > > +++ b/arch/riscv/Kconfig > > @@ -119,6 +119,7 @@ config RISCV > > select HAVE_FUNCTION_GRAPH_RETVAL if HAVE_FUNCTION_GRAPH_TRACER > > select HAVE_FUNCTION_TRACER if !XIP_KERNEL && !PREEMPTION > > select HAVE_EBPF_JIT if MMU > > + select HAVE_FAST_GUP if MMU > > select HAVE_FUNCTION_ARG_ACCESS_API > > select HAVE_FUNCTION_ERROR_INJECTION > > select HAVE_GCC_PLUGINS > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > > index ab00235b018f..c6eb214139e6 100644 > > --- a/arch/riscv/include/asm/pgtable.h > > +++ b/arch/riscv/include/asm/pgtable.h > > @@ -673,6 +673,12 @@ static inline int pmd_write(pmd_t pmd) > > return pte_write(pmd_pte(pmd)); > > } > > +#define pud_write pud_write > > +static inline int pud_write(pud_t pud) > > +{ > > + return pte_write(pud_pte(pud)); > > +} > > + > > static inline int pmd_dirty(pmd_t pmd) > > { > > return pte_dirty(pmd_pte(pmd));