From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B97C3DA6E for ; Wed, 3 Jan 2024 08:14:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D30F86B0291; Wed, 3 Jan 2024 03:14:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBB516B0292; Wed, 3 Jan 2024 03:14:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B34FE6B0293; Wed, 3 Jan 2024 03:14:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9DE676B0291 for ; Wed, 3 Jan 2024 03:14:06 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6CC6C40233 for ; Wed, 3 Jan 2024 08:14:06 +0000 (UTC) X-FDA: 81637286892.21.2A8D549 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf01.hostedemail.com (Postfix) with ESMTP id 127B140010 for ; Wed, 3 Jan 2024 08:14:02 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c6DUitPQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cCyZ7Ti8; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HlW+xlJ2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=L5gPJvUG; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704269643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EHzT6aEuunaF8l957oLeyQUzYLU5v+V8f8tLm26sh6Q=; b=yAr/sH9w0LPtWP9kZeezL6taqsZonNhLRvyoh21WrxwbZVgQPFNEmXUDt5YpszrAWyZPHm vJCuW/+giPKGY8ZOiVDK0CRi4zMS1dMbGw1mAxQ/0jVEys8uaTnz7BN4nQva+iJIz9/ts1 sQa/O/0+ofq0Cc4DbnRefjvJScDkKp0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c6DUitPQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cCyZ7Ti8; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HlW+xlJ2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=L5gPJvUG; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704269643; a=rsa-sha256; cv=none; b=vfdjAQVUHi2imtFIk2LsPoPpEjvdd7ShRY198nT96h8EPiEc0eik5DuF1f7Vpn8B3dfszo vXWAinu0l66bTyhk3Gr5yuVvUckqr8kej34wAt1E+m+uzv27djy4tPStoh9Ap/fEwP9M5b xR4HgD5ALWYm4yH2i1tLHpNHfAdVuv4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1C6341F798; Wed, 3 Jan 2024 08:14:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704269641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EHzT6aEuunaF8l957oLeyQUzYLU5v+V8f8tLm26sh6Q=; b=c6DUitPQDMRwF+0goNIS1n9Q0sr99l84uw2rTrxYLUZo4553qSO56Q41HlH0GbKdkhZJTW 22mJpS+H/qKDYwIXq4K3gRk2ACrmx+/pVmT2qgyy9HNqPV4PPfHrCVBJMYwfLqg5heHr6D BOnBATflnsTYq51QctE/eIt9Z66sDMA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704269641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EHzT6aEuunaF8l957oLeyQUzYLU5v+V8f8tLm26sh6Q=; b=cCyZ7Ti86IGLu4B9k6WFjJGXYPDYEwA0tSo34nnmEYMDnfOVvQg4gahtNBJUY/XwwOXb6W jihSN0D4Xwq8/QCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704269640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EHzT6aEuunaF8l957oLeyQUzYLU5v+V8f8tLm26sh6Q=; b=HlW+xlJ2flYs8Ie3LfqBXcZLLCXsPnlmeyNwYByRNLwgoM/NqpmqVOmOTW6EWgr0HgsGlE U/BGuf1rkvii764yUoymTTCYqRIz/dvsCiS/q6IwlvtN58Evu4ckpYClx2JK+u2i2O4+NQ JWQDEi0tdlBlblgJ6L5H63stSix/Kt4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704269640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EHzT6aEuunaF8l957oLeyQUzYLU5v+V8f8tLm26sh6Q=; b=L5gPJvUGmCkrGVVkF3WH2nqdQl2bjBdu+Y7S8tPHLacvvIRiMeQCoTJdmpe5zD/a/aUD3d 6cnsmAFtEUCM4BBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4E2851340C; Wed, 3 Jan 2024 08:13:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SfDJD0cXlWWaWgAAD6G6ig (envelope-from ); Wed, 03 Jan 2024 08:13:59 +0000 Date: Wed, 3 Jan 2024 09:14:49 +0100 From: Oscar Salvador To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH v4 01/22] lib/stackdepot: print disabled message only if truly disabled Message-ID: References: <73a25c5fff29f3357cd7a9330e85e09bc8da2cbe.1700502145.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73a25c5fff29f3357cd7a9330e85e09bc8da2cbe.1700502145.git.andreyknvl@google.com> X-Rspamd-Queue-Id: 127B140010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rcgpbuwk9w4u5ee59uhe6ymnsx3s1z7a X-HE-Tag: 1704269642-327691 X-HE-Meta: U2FsdGVkX19ZXgEUupIsKm8RKplk2aVXnuyTN4NlOtEV2cUHpJQMkhSeH9BHNmZ5IkJ2ygthqZfQRhVWVGFzioPtiJI4ghGyN/8Yz2ECdtsWKDtA42EW4mO+V6U7tPOf+Wwh7O944bouIYGR6qcGV5pALlgTdWQyFSEIDgQ5OSOmECo9fc2UUIUEYuZKPE3UzjIu/6cVI8kWPmkN+QT60j1kT2V7o16hxdqTzjZ2qLa3c8Q+MjR9or7LOzmnDrMrnBDBQXCtxd/jnCJE2o2C8zvV2ytkuUTzxPl7ym7QApB+dIEaBo1XyXMbUixOmzWLAsQeQfW2dQuO7UaM6czCXRt1+3obE7mFN9O0DpmSMTuCi6lX3EjCeCGo6GxmZdeiEDsFE3T1K8Xjp7Er4wUOKOnAqx1hEeiEThFiXlkjJgYqiN/RkOendImYslGEyInwaOVA07Xa5eMXst9UNpAbkvwGZlACS92C1k4q7yL5v979m57AGLS1PwNUYnhs1n3O214AG9Qk8NVnbbJK1Z8Wr/08eweC2G7oSKyBgn90zFQUtmn7EEGphWbAsiIM88O6Zbn2lIBgX0aWAFB5ug+weJDMcopjkzxAcRRKZraXosKw27bC/n8r/qo26u1hT4o6SivNBi0dLMOj2dCEHUKeLHn26AuTWF9uHooyNW/aDZR+vXNlxOxXTZ5GswYANZ9+03A5HcVc4PpGHeBzlZWlxoYI+MlucpOUcOck6rPigjR4+QhKNAAWBBr+0q97yLnTNkjizbqvaps8AcyYxDc4hkQMgn5oC8w6cNAtizqeeo3tmvEYIC/60B/x7llyL361je2LQ7eF182Fk4Zcx3JpZcCgb9MDU7LsKmrAVkMuYSTgAc9wYYu6YsY/n5/7vMSoH4cwcZRA8Qh3GNSEB1WcBbhbjZ98dU3Kogh9QMOZTuqA3gbrWOXy8TlvFvDIiv6Y9Az09eCSY4HvqMZQepy /x13UrdK RyfD15tNhtccSy9xBtR9VY6paguyH++EEy7BBA0OD01g/KY/2XB7K3vkZNHA+f9jANBo8Lt5CdJk2b9GjklvboAJs3u4hD0ojxD+kWDYuIJgfW8kXzatW+vDMXGv+k5+oHNojDY9ilH/ykYgYJPz3CgrHzpcEN9UWQo4lSZnx8ARAtyNR8u4SJ3fy+ZrFTsrVu7bs+2DKxtmxpSc7yt3tQiBKFRjXRjzizymWQabpK8Zpjlzom2ysOxQs4ErJHXMaLQvmkyJQ2uHtucRHzF6/gV46WOiq/1JwdEOa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 06:46:59PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Currently, if stack_depot_disable=off is passed to the kernel > command-line after stack_depot_disable=on, stack depot prints a message > that it is disabled, while it is actually enabled. > > Fix this by moving printing the disabled message to > stack_depot_early_init. Place it before the > __stack_depot_early_init_requested check, so that the message is printed > even if early stack depot init has not been requested. > > Also drop the stack_table = NULL assignment from disable_stack_depot, > as stack_table is NULL by default. > > Fixes: e1fdc403349c ("lib: stackdepot: add support to disable stack depot") > Reviewed-by: Marco Elver > Signed-off-by: Andrey Konovalov Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs