From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32564C369A5 for ; Thu, 10 Apr 2025 14:42:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 015152800BF; Thu, 10 Apr 2025 10:42:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F07512800B5; Thu, 10 Apr 2025 10:42:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCFCE2800BF; Thu, 10 Apr 2025 10:42:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BDF312800B5 for ; Thu, 10 Apr 2025 10:42:03 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2AB92140DE9 for ; Thu, 10 Apr 2025 14:42:04 +0000 (UTC) X-FDA: 83318398968.22.95F968D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id ABFAD120009 for ; Thu, 10 Apr 2025 14:42:02 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fJxdA78Q; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744296122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GkdVtNWVGZXtJCD/Cgl0sIM2AFsYuUtepuJiagRyEyI=; b=o7D/GaCcYPrxWj03C48vlRKLttjqmZNtvtr0N25EQbPofSlUAQT60R0Sq98FwyAilw6ISI ryrlIZJXvL2EyjzD1B2I2XomLPIodhrk78DcN8S57QMsIv9EGYKMzXp3CcX+gzdJPS3xve rTjRhujbV7N8aFGunGPdMOjDs5qalsQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744296122; a=rsa-sha256; cv=none; b=nLbESCHOYqnS4Iqy/nZJMhG4qUvuxmn83Ru/q6iRVf8fhZnCcJTYqPvQ2jjCmHF4S5ubFP Jf+dIUjZIboYYECttn8YC2cUxSQfK2KS3T0tWxZaUOcij7L63putFF0JnPbfaVadyk8Exi L2ZoT7EgdhDrzvBh39TBPUl7Ld+ercw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fJxdA78Q; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 33108A4A80D; Thu, 10 Apr 2025 14:36:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9045C4CEDD; Thu, 10 Apr 2025 14:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744296121; bh=jXB7ckivh7blHEfjcI2FFxFe4jYKAOApDfdeibGdXJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fJxdA78QVwDOXDsYIzOeZ0oU57Kui8FU2LVRLlJIMztkv4qSlVOqtwl8Cx1V8pDZB 820u71vwDm4vFod5Fk8heNfIBco9GpGRhvGZlVwqyUhrPm5s+YXhbHoZw9avvycJd4 x7RPc8mGA1ls26fyhnLVETLTd4J2hd1P/F3gZ+KbTzO55zbcfGuSUFhGGuFS87ypF5 fXhaILtkmZU4hrFTKTgtu2f1P+zW3uFJVwoBF4HKz8PrOXAj7761TroZjgvUHclZVc j7C6ydNLoe+nGA1WTohxyyvM9r5tqThMGUH8xCCowImqyQmOXDmahv68Oto1x/oN+v eeeoqNnz1oxhQ== Date: Thu, 10 Apr 2025 17:41:55 +0300 From: Mike Rapoport To: gaoxu Cc: Andrew Morton , "surenb@google.com" , Barry Song <21cnbao@gmail.com>, "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , yipengxiang Subject: Re: [PATCH] mm: simplify zone_idx() Message-ID: References: <2d42decac5194c2c8d897b0424f0dcf3@honor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d42decac5194c2c8d897b0424f0dcf3@honor.com> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: ABFAD120009 X-Stat-Signature: fxpm1s1q7a7wq1otjees7eu585xy1osy X-HE-Tag: 1744296122-652074 X-HE-Meta: U2FsdGVkX19gUPVe3E4qIpL2GacTdjs8nYGhT/niDZ4/z1HbdIdbs2upTDHm8Jk11pVl7kr/nIrgXqslN3O4YOk+6eP3WooYS+roqASdhKqUtV2mXm8GAv50jI5AX30pCaH1H2bdJubjvGC0IxoDzgRRO2aVzBvzxFSk9cbRAuha/JgsU/s27JClYkZrg1X5fE+RFtwLBxUAnDztsO+8mAq/vBPeF1EZwfeZ7Emn5pwaUf9f1WMWsyLO7Dhe13Hz05ZeI5/yx6hf/oN9e2nmlPwxgOxXjfvnX8BFFQ/Lq/40t7k8b7PoZr3XRFesF0uMJeBZPQwGTnAw4uyTKSGGs22GWmRTQ2AbyAjhg19y3EA72Yy6+HBcyHglOgyfUZ1g+kooQt/1+s5wgaq/qqrP96nfyxLE/6lbDQFfosmh6WfiQJTsCiYOfJoS7qIhxZIbIIUzWRigcc6+eKk1uSmslIS9u/NRu99cWOAUchxI/LWTFLqydRShc/3bAV0tHmeDXiZjAdPWItkNt4z6iTjNQGf0HcQH3DkT1cYdt0B6oylY/RvIddx0aPdJkEMEsigXWKnrE7O7Oh5nLxDhlMLTm/4tDkRU2ddv7glr4bpAZew7Etj2OXVt0hlAC21LerimuE1QGS7o4hWwxLnxuQ1yW1jjiwt3jXQTzTxQmQAhfl6BkwfbnQQRz5Zqb1uKrwQnz0jrWnfYA0iD/CVeqlj9p1scnOpldp1sL+shYIjjHrdUCIu2B2NQt1p/qXbj2Q+EgYDtAmXZvxnmC2VgmYDeceSBm6GaUV7IFU2aN6e7+sWnubc/JFcNOBwxMyBnUQvpAJjo0kDZNzrbNgakX6LF13YLHpndMwWd5J++RCXjC1c0AmBpgRnyHDL4vbAgcze118IbPJcVo5SfGfnKVM+a5H3rEziWEWxXOKCyv0hj93VBb6fSWSUM6D5CvDaCrFb3QNpU0klJWTt+WIClAsU jBhYRefd DgRqDb//LOePQIGT5ud8sk/3QJSnxJ49iZaUIBDwsExt/1xI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Thu, Apr 10, 2025 at 12:03:00PM +0000, gaoxu wrote: > store zone_idx directly in struct zone to simplify and optimize zone_idx() Do you see an actual speed up somewhere? > Signed-off-by: gao xu > --- > include/linux/mmzone.h | 3 ++- > mm/mm_init.c | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 4c95fcc9e..7b14f577d 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -941,6 +941,7 @@ struct zone { > #endif > > const char *name; > + enum zone_type zone_idx; > > #ifdef CONFIG_MEMORY_ISOLATION > /* > @@ -1536,7 +1537,7 @@ static inline int local_memory_node(int node_id) { return node_id; }; > /* > * zone_idx() returns 0 for the ZONE_DMA zone, 1 for the ZONE_NORMAL zone, etc. > */ > -#define zone_idx(zone) ((zone) - (zone)->zone_pgdat->node_zones) > +#define zone_idx(zone) ((zone)->zone_idx) > > #ifdef CONFIG_ZONE_DEVICE > static inline bool zone_is_zone_device(struct zone *zone) > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 9659689b8..a7f7264f1 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1425,6 +1425,7 @@ static void __meminit zone_init_internals(struct zone *zone, enum zone_type idx, > atomic_long_set(&zone->managed_pages, remaining_pages); > zone_set_nid(zone, nid); > zone->name = zone_names[idx]; > + zone->zone_idx = idx; > zone->zone_pgdat = NODE_DATA(nid); > spin_lock_init(&zone->lock); > zone_seqlock_init(zone); > -- > 2.17.1 -- Sincerely yours, Mike.