From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A988C369B2 for ; Mon, 14 Apr 2025 11:15:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AE5C28004B; Mon, 14 Apr 2025 07:15:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 435C6280036; Mon, 14 Apr 2025 07:15:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D6AB28004B; Mon, 14 Apr 2025 07:15:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0D040280036 for ; Mon, 14 Apr 2025 07:15:09 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E7FD0B21D5 for ; Mon, 14 Apr 2025 11:15:08 +0000 (UTC) X-FDA: 83332392696.29.18C494C Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf18.hostedemail.com (Postfix) with ESMTP id 1C20A1C0008 for ; Mon, 14 Apr 2025 11:15:06 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lIiY88Lq; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of mingo@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mingo@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744629307; a=rsa-sha256; cv=none; b=je+0BCDkr/BMwUoOPgRw5qeX1R0H7nM0PG3rELVGI/oOo3c6hDZZmsVLudbdsFxcCCWZhh glSExYdhqmtUdKUY8t3cQ+qXDAegztCo28cpLNb0RCqsJYDhagn90le3K9bEzPUuzrZzXG R/CrN34ZCFnYXZ1FTqi2OokWO0M8pSc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lIiY88Lq; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of mingo@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mingo@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744629307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JxvrbF8pWFr+Y+w6S2Vs9l3kN6Suqy7JQuPVNn87CJs=; b=Qqghxce769KY6eVHFJP79IyHF0eOYYe2FMdk2Kwy2Myj8veACGYYRCeOp/qd9Xznx/azn4 RrsbQ5hu61N22m4pMo6Djaw4JEFBKibg+UeW/oQ4mvV6pHkRAl+GnPbAkJxtgSrQNi1Nxh 0rcYG+09NcIo98rGJH5zfYA3ydsRgVM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id BBEC649C58; Mon, 14 Apr 2025 11:15:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 225BDC4CEE2; Mon, 14 Apr 2025 11:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744629305; bh=8yHKkbWoft8F9o9x75jDIA+cD6IIJndCHKNdCRxUXB8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lIiY88LqfgtcHo/NfiDeMJp/NkC1MUfTzb8mUF3W9UC47qtCUJXwswFVuszSOoYDj mAv4NgnZHBDNgK76G8J9imNBkukYlejO+ypo8D5CJasPRzSqGZHp3Z/qQAAvIdFYSu ABiv1sHU2mOjushl3E5q+VzsnpQ6sKKrm8OqCdtpb29739iONLKqyYJgLywqct9z+W iLIdkLfVhFXfLq8UBH4CpWW5bB5a1osu+yVn5b8n+Xf4OGgnA4sORfaPltYPqCtm0U gbcqTN1ElfPLwaam8/IMSK7mc+Ehom0vE9bJ7jnjcM13u4YBQPQCFNi32db1f+cIgB kJNytXd9WS9Zg== Date: Mon, 14 Apr 2025 13:14:58 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: Ankur Arora , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, luto@kernel.org, paulmck@kernel.org, rostedt@goodmis.org, tglx@linutronix.de, willy@infradead.org, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com Subject: Re: [PATCH v3 1/4] x86/clear_page: extend clear_page*() for multi-page clearing Message-ID: References: <20250414034607.762653-1-ankur.a.arora@oracle.com> <20250414034607.762653-2-ankur.a.arora@oracle.com> <20250414110259.GF5600@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250414110259.GF5600@noisy.programming.kicks-ass.net> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1C20A1C0008 X-Stat-Signature: uhdky47fx3qbnx357ngubyx3k8jt7776 X-Rspam-User: X-HE-Tag: 1744629306-156317 X-HE-Meta: U2FsdGVkX19IlHuroAlXP0M3rA2u9KRrxfNEGiX3ZfHQ+AuhxIAdUo4YsfAPU3/jZ1ELtjPWUOFKhEn+PwQhkdIGpqnHk75sN6WiqBuoimcM5/h5OtvjGjdKePBLrkKMvu61PqLep4zbokDuBEP+X8UUHXAJM8XkrYC3P/VISBGHVSgK7UHm+1w9okulJpsaYp0NYBq/uAtTY9Ub8+MqIpk5CbbRjg2yseTeIZE1VcHVpLMrUf1Kp7Hd/HCUZ+AFLXamznQcLnnXxXQRWjguthTwyzuaTvKCAXV0Nk2cR3u/iCz1LOTAWKH0zXYbOO0bGmNv/qfoRgYlGsCnSwzWb/Yv3wru6r/b87JcFyFh1RasN4EVY9cdRgaRRkL6LMc+al/nkcnU6L3jYx49oHG6A3qYYWh7reNtJtkEbDV3R+JlAuMiFjkOAJaXLjpXzw1/52sn/yW0qZlq7mUopT/q/xByS1uJE8WAUiN1r4STbFp0wUp0IH8+TRmq+tWfboe004BaTyMd5Dwya42HwaRDSI1fDeydKShI0pBgQFbNT85LLAISIHOfOYGUXrV7GnK7Nt77rDnLd4aBGhtTVSyH6htw4HL9emxsFP0UPJmnbFxVEetLH+jGkqEpXk1wFWYwR8e7DkvUY3/LS2CzT2qQe0wWgGPUmr1MV8GDXoPLlYrb/66zxVIQ9WD8KNi/TGFz3JYLHpbEWw7jOVVVElVrpc2+anUBWzkxQoX3Qm1f/nhOnYgasm0Jpbhuo86K0p4RxCKb39/e6bVYlpcBNFew/9or33eIuYd1eTFvLAM+4+A431luYFhwg10JMnBoilFx9SI/i1BtffAnovDJe1o67uNSCSJumaIrYBRzG+I+owFTzDZj9cEnI/kpHIhgROZuw0uHLSChl97IjlY7ozHek+TYeitb4/7ri+cgUcQ0EO13jNplNrVe984eOdFYwSXpB4mZNwGCTMbtGd5qGj8 6q3hNp0g mCXiAPRqdataifaF8HmDvWIiscGqJv7ki7WmR/S7eIlbj/JqIfmTmNlkRItNogGoqu1PifheM/ytvrE3qP1B4RferYEbU0gvbpz7O5DN9tmX+sB+9+TX/lYcSGCVFka8hOfMPC82nLynVXhMYmQsPlFRdNTLCsnNPcYgj+2LorVaw/Qj6veZlbjnqxzcbWA3MH+bljT+T9hFQ+DjHYGxRe9F+J00/2iqRisfSZdIGatfWT9EHl0fa5ZxV4W91vPw5nCtzBkzpBp0FkjgEJvROYqv+HoLSj5Haph3+rbxlgBDhXuWHDrlHjWPRLH2pxX7HoJBw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Peter Zijlstra wrote: > On Mon, Apr 14, 2025 at 08:32:29AM +0200, Ingo Molnar wrote: > > > > static inline void clear_page(void *page) > > > { > > > + unsigned int length = PAGE_SIZE; > > > /* > > > - * Clean up KMSAN metadata for the page being cleared. The assembly call > > > + * Clean up KMSAN metadata for the pages being cleared. The assembly call > > > * below clobbers @page, so we perform unpoisoning before it. > > > > > */ > > > - kmsan_unpoison_memory(page, PAGE_SIZE); > > > - alternative_call_2(clear_page_orig, > > > - clear_page_rep, X86_FEATURE_REP_GOOD, > > > - clear_page_erms, X86_FEATURE_ERMS, > > > + kmsan_unpoison_memory(page, length); > > > + > > > + alternative_call_2(clear_pages_orig, > > > + clear_pages_rep, X86_FEATURE_REP_GOOD, > > > + clear_pages_erms, X86_FEATURE_ERMS, > > > "=D" (page), > > > - "D" (page), > > > + ASM_INPUT("D" (page), "S" (length)), > > > "cc", "memory", "rax", "rcx"); > > > } > > > > > > diff --git a/arch/x86/lib/clear_page_64.S b/arch/x86/lib/clear_page_64.S > > > index a508e4a8c66a..bce516263b69 100644 > > > --- a/arch/x86/lib/clear_page_64.S > > > +++ b/arch/x86/lib/clear_page_64.S > > > @@ -13,20 +13,35 @@ > > > */ > > > > > > /* > > > - * Zero a page. > > > - * %rdi - page > > > + * Zero kernel page aligned region. > > > + * > > > + * Input: > > > + * %rdi - destination > > > + * %esi - length > > > + * > > > + * Clobbers: %rax, %rcx > > > */ > > > -SYM_TYPED_FUNC_START(clear_page_rep) > > > - movl $4096/8,%ecx > > > +SYM_TYPED_FUNC_START(clear_pages_rep) > > > + movl %esi, %ecx > > > xorl %eax,%eax > > > + shrl $3,%ecx > > > rep stosq > > > RET > > > -SYM_FUNC_END(clear_page_rep) > > > -EXPORT_SYMBOL_GPL(clear_page_rep) > > > +SYM_FUNC_END(clear_pages_rep) > > > +EXPORT_SYMBOL_GPL(clear_pages_rep) > > > > > > -SYM_TYPED_FUNC_START(clear_page_orig) > > > +/* > > > + * Original page zeroing loop. > > > + * Input: > > > + * %rdi - destination > > > + * %esi - length > > > + * > > > + * Clobbers: %rax, %rcx, %rflags > > > + */ > > > +SYM_TYPED_FUNC_START(clear_pages_orig) > > > + movl %esi, %ecx > > > xorl %eax,%eax > > > - movl $4096/64,%ecx > > > + shrl $6,%ecx > > > > So if the natural input parameter is RCX, why is this function using > > RSI as the input 'length' parameter? Causes unnecessary register > > shuffling. > > This symbol is written as a C function with C calling convention, even > though it is only meant to be called from that clear_page() alternative. > > If we want to go change all this, then we should go do the same we do > for __clear_user() and write it thusly: > > asm volatile(ALTERNATIVE("rep stosb", > "call rep_stos_alternative", ALT_NOT(X86_FEATURE_FSRS) > : "+c" (size), "+D" (addr), ASM_CALL_CONSTRAINT > : "a" (0)) > > And forget about all those clear_page_*() thingies. Yeah. Thanks, Ingo